27 Apr, 2015
1 commit
-
IRQ handler touches info->edev, so if interrupt occurs before extcon
device initialization it can cause NULL pointer dereference. Doing extcon
initialization before IRQ handler registration fixes this problem.Signed-off-by: Robert Baldyga
Acked-by: Roger Quadros
Signed-off-by: Chanwoo Choi
22 Apr, 2015
1 commit
-
Pull char/misc driver updates from Greg KH:
"Here's the big char/misc driver patchset for 4.1-rc1.Lots of different driver subsystem updates here, nothing major, full
details are in the shortlog.All of this has been in linux-next for a while"
* tag 'char-misc-4.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (133 commits)
mei: trace: remove unused TRACE_SYSTEM_STRING
DTS: ARM: OMAP3-N900: Add lis3lv02d support
Documentation: DT: lis302: update wakeup binding
lis3lv02d: DT: add wakeup unit 2 and wakeup threshold
lis3lv02d: DT: use s32 to support negative values
Drivers: hv: hv_balloon: correctly handle num_pages>INT_MAX case
Drivers: hv: hv_balloon: correctly handle val.freeram directory
coresight-tmc: Adding a status interface to sysfs
coresight: remove the unnecessary configuration coresight-default-sink
...
23 Mar, 2015
2 commits
-
Since extcon.c is using raw_notifiers it must protect the notifier
list itself when [un]registering notifiers to avoid the list changing while
extcon_update_state is walking the list (through raw_notifier_call_chain).Signed-off-by: Hans de Goede
[cw00.choi: Apply this patch to extcon.c driver instead of old extcon-class.c]
Signed-off-by: Chanwoo Choi -
The i2c_new_dummy() return the NULL if error happen. So, If i2c_new_dummy()
return NULL, max77843_init_muic_regmap() return the proper error value
(-ENOMEM);Signed-off-by: Dan Carpenter
[cw00.choi: Use -ENOMEM instead of -ENODEV and modify patch description]
Signed-off-by: Chanwoo Choi
16 Mar, 2015
1 commit
-
This patch fixes the variable type of 'ret' from 'unsigned int' to 'int' type
because the return type of regmap_update_bits() is 'int' type.Fixes: 27a28d32b4f2 ('extcon: max77843: Add max77843 MUIC driver')
Signed-off-by: Dan Carpenter
[cw00.choi: Fix the patch description]
Signed-off-by: Chanwoo Choi
07 Mar, 2015
2 commits
-
This patch fixes the checkpatch warning about coding style.
Signed-off-by: Chanwoo Choi
-
This patch renames the extcon core driver from extcon-class.c
to extcon.c because '-class' postfix is not necessary.Signed-off-by: Chanwoo Choi
04 Mar, 2015
2 commits
-
wm5110 requires slightly different configuration of the headphone
clamps to other Arizona devices. Otherwise headphone detection accuracy
will be way off. This patch adds the needed clamping.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
arizona_extcon_do_magic does not lend a lot of clarity to the purpose
of the function, and as all the registers used are described in the
datasheet there is no need to obfuscate the code. This patch renames the
function to arizona_extcon_hp_clamp, as it controls clamping on the
headphone output.Signed-off-by: Charles Keepax
Acked-by: Lee Jones
Signed-off-by: Chanwoo Choi
26 Feb, 2015
1 commit
-
Signed-off-by: Richard Fitzgerald
Acked-by: Chanwoo Choi
Signed-off-by: Charles Keepax
Signed-off-by: Lee Jones
24 Feb, 2015
4 commits
-
This patch adds MAX77843 extcon driver to support for MUIC(Micro
USB Interface Controller) device by using EXTCON subsystem to handle
various external connectors.Signed-off-by: Jaewon Kim
Signed-off-by: Chanwoo Choi -
This driver observes the USB ID pin connected over a GPIO and
updates the USB cable extcon states accordingly.The existing GPIO extcon driver is not suitable for this purpose
as it needs to be taught to understand USB cable states and it
can't handle more than one cable per instance.For the USB case we need to handle 2 cable states.
1) USB (attach/detach)
2) USB-HOST (attach/detach)This driver can be easily updated in the future to handle VBUS
events in case it happens to be available on GPIO for any platform.Signed-off-by: Roger Quadros
Reviewed-by: Felipe Balbi
Acked-by: Felipe Balbi
Signed-off-by: Chanwoo Choi -
This patch unifies the term called 'USB_OTG' and 'USB_HOST'
into USB_HOST. OTG(On-The-Go) function supports USB host and
this driver sents 'USB-Host event. So, unifies term to USB_HOST.Signed-off-by: Jaewon Kim
[cw00.choi: Fix patch title to indicate the correct meaning of patch]
Signed-off-by: Chanwoo Choi -
This patch fixes extcon cable name of MHL-TA instead of MHL_TA
to unify cable name style.Signed-off-by: Jaewon Kim
Signed-off-by: Chanwoo Choi
26 Jan, 2015
3 commits
-
The regmap_config struct may be const because it is not modified by the
driver and regmap_init() accepts pointer to const.Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
Release IIO channel acquired during driver probe.
Signed-off-by: Ivan T. Ivanov
Signed-off-by: Chanwoo Choi -
Remove duplicated "of.h" header file.
Signed-off-by: Wei Yongjun
Signed-off-by: Chanwoo Choi
15 Dec, 2014
1 commit
-
Pull char/misc driver updates from Greg KH:
"Here's the big char/misc driver update for 3.19-rc1Lots of little things all over the place in different drivers, and a
new subsystem, "coresight" has been added. Full details are in the
shortlog"* tag 'char-misc-3.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (73 commits)
parport: parport_pc, do not remove parent devices early
spmi: Remove shutdown/suspend/resume kernel-doc
carma-fpga-program: drop videobuf dependency
carma-fpga: drop videobuf dependency
carma-fpga-program.c: fix compile errors
i8k: Fix temperature bug handling in i8k_get_temp()
cxl: Name interrupts in /proc/interrupt
CXL: Return error to PSL if IRQ demultiplexing fails & print clearer warning
coresight-replicator: remove .owner field for driver
coresight: fixed comments in coresight.h
coresight: fix typo in comment in coresight-priv.h
coresight: bindings for coresight drivers
coresight: Adding ABI documentation
w1: support auto-load of w1_bq27000 module.
w1: avoid potential u16 overflow
cn: verify msg->len before making callback
mei: export fw status registers through sysfs
mei: read and print all six FW status registers
mei: txe: add cherrytrail device id
mei: kill cached host and me csr values
...
24 Nov, 2014
3 commits
-
Fix a typo in name of company in copyright comment.
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
When JIG was set to "boot on" mode, the UART connection did not work
because it was assigned to Dock-Car cable (path: audio), not JIG-UART-ON
cable.This was introduced in 39bf369e4ed3 ("extcon: max77693: Add support dock
device and buttons") while adding dock features.Assign the JIG-UART-ON back to UART path.
Signed-off-by: Krzysztof Kozlowski
[cw00.choi: Modify the patch name to remove specific board name]
Signed-off-by: Chanwoo Choi -
Platform bus is not the only way to have extcon devices, so current
implementation of of_extcon_get_extcon_dev() is broken. Also using
parent device node only to get device name is quite ugly.This patch reimplements of_extcon_get_extcon_dev() to do exactly the
same as extcon_get_extcon_dev() but instead of comparing names, compare
node pointers.Signed-off-by: Tomasz Figa
[mszyprow: simplified the code]
Signed-off-by: Marek Szyprowski
Signed-off-by: Chanwoo Choi
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
22 Sep, 2014
9 commits
-
This patch fixes following minor cleanup:
- Order the include files in alphabetical order.
- Fix description of state_off in extcon_gpio.h
- Add a descrition for check_on_resume in extcon_gpio.hSigned-off-by: George Cherian
[Modify the name/description of patch to keep standary codiyg style by Chanwoo Choi]
Signed-off-by: Chanwoo Choi -
When it writes some value other than 0 to BTLDset and JIGset, muic device
will be reset automatically. And it happens during updating ADC debounce time,
because it shares same register. To update ADC debounce time without reset,
set value only to ADCDbset and 0 to BTLDset and JIGset.Signed-off-by: Jonghwa Lee
[Remove un-needed masking operation by Chanwoo Choi]
Signed-off-by: Chanwoo Choi -
Don't include when the driver does not use anything
from this header file.Signed-off-by: Jean Delvare
Acked-by: MyungJoo Ham
Signed-off-by: Chanwoo Choi
Cc: Chanwoo Choi
Cc: MyungJoo Ham -
Use resource managed interrupt line devm_request_threaded_irq() to
simplify a little cleanup paths:
- no goto to cleanup label,
- simpler remove function.Overall the driver size is decreased by 11 line of code.
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi -
This patch add support for Richtek RT8973A which is Micro USB Switch OVP
and i2c interface. The RT8973A is a USB port accessory detector and switch
that is optimized to protect low voltage system from abnormal high input
voltage (up to 28V) and supports high speed USB operation. Also, RT8973A
support 'auto-configuration' mode. If auto-configuration mode is enabled,
RT8973A would control internal h/w patch for USB D-/D+ switching.Signed-off-by: Chanwoo Choi
Signed-off-by: Seung-Woo Kim
Acked-by: Kyungmin Park -
This patch just clean up codes by using checkpatch script and fix warning
message about if statement.- the result of checkpatch script as following:
WARNING: void function return statements are not generally useful
+ return;
+}WARNING: quoted string split across lines
+ dev_err(info->dev, "failed: irq request (IRQ: %d,"
+ " error :%d)\n", muic_irq->irq, ret);- warning message about coding style.
drivers/extcon/extcon-sm5502.c:398 sm5502_muic_cable_handler()
warn: we tested 'attached' before and it was 'false'Signed-off-by: Chanwoo Choi
-
This patch move sm5502.h header file from 'include/linux/extcon' to
'driver/extcon' because sm5502.h is used for driver/extcon/extcon-sm5502.c.
and remove duplicate license description.Signed-off-by: Chanwoo Choi
-
This patch add I2C configuration dependency to fix following build break.
If specific kernel build I2C as module, extcon-sm5502 have to depend on
I2C configuration.drivers/built-in.o: In function `regmap_smbus_byte_reg_read':
regmap-i2c.c:(.text+0x5030a): undefined reference to `i2c_smbus_read_byte_data'
drivers/built-in.o: In function `regmap_smbus_byte_reg_write':
regmap-i2c.c:(.text+0x50338): undefined reference to `i2c_smbus_write_byte_data'
drivers/built-in.o: In function `regmap_smbus_word_reg_read':
regmap-i2c.c:(.text+0x50356): undefined reference to `i2c_smbus_read_word_data'
drivers/built-in.o: In function `regmap_smbus_word_reg_write':
regmap-i2c.c:(.text+0x50384): undefined reference to `i2c_smbus_write_word_data'
drivers/built-in.o: In function `regmap_i2c_read':
regmap-i2c.c:(.text+0x503cf): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `regmap_i2c_gather_write':
regmap-i2c.c:(.text+0x50442): undefined reference to `i2c_transfer'
drivers/built-in.o: In function `regmap_i2c_write':
regmap-i2c.c:(.text+0x50474): undefined reference to `i2c_master_send'
drivers/built-in.o: In function `sm5502_muic_i2c_init':
extcon-sm5502.c:(.init.text+0x6630): undefined reference to `i2c_register_driver'Signed-off-by: Chanwoo Choi
-
This patch fix bug when checking cable type. SM5502 have to use ADC value
to get correct cable type.Signed-off-by: Chanwoo Choi
23 Jul, 2014
6 commits
-
This patch changes internal hardware DP_CON/DM_CON switch according to
cable type. The SM5502 MUIC device can set hardware switch as following:
- OPEN (not connected state) / USB / UART / AUDIO
Also, this patch set VBUSIN switch according to cable type.Signed-off-by: Chanwoo Choi
-
This patch detect whether cable is connected or not and the cable type
after completing kernel/platform booting using system_power_efficient_wq.Signed-off-by: Chanwoo Choi
-
This patch add new SM5502 MUIC(Micro-USB Interface Controller) device by using
EXTCON subsystem. The extcon-sm5502 driver is capable of identifying the type
of the external power source and attached accessory. An external power sources,
such as Deticated Charger or a standard USB port, are able to charge the battery
in the smart phone via the connector.Signed-off-by: Chanwoo Choi
-
Previously we would do a regulator get against the main Arizona device
to obtain the MICVDD regulator. Arizona is an MFD device and normally
MICVDD will be supplied by one of its children (the arizona-micsupp
regulator). As devres destruction for the MFD device will run after all
its children have been destroyed, the regulator will be destroyed before
devres calls regulator_put. This causes a warning from both the
destruction of the child node, as the regulator is still open, and from
the put of the regulator as the regulator device has already been
destroyed.A simple fix here is to get the regulator against the extcon device
itself such that devres runs when the child is destroyed. This has the
additional benefit that if for some reason the extcon driver is unloaded
the regulator reference won't hang around until the MFD is unloaded.Signed-off-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. The following
checkpatch warning is also removed.WARNING: Possible unnecessary 'out of memory' message
Signed-off-by: Jingoo Han
[Acked by Charles Keepax for arizona part]
Acked-by: Charles Keepax
Signed-off-by: Chanwoo Choi -
…nel/git/lee/mfd into extcon-next
Immutable branch between MFD, Extcon and Regulator due for v3.17
17 Jun, 2014
2 commits
-
This patch modifies mfd driver to use regmap for handling interrupts.
It allows to simplify irq handling process. This modifications needed
to make small changes in function drivers, which use interrupts.Signed-off-by: Robert Baldyga
Reviewed-by: Krzysztof Kozlowski
Acked-by: Chanwoo Choi
Signed-off-by: Lee Jones -
This patch removes wrapper functions used to access regmap, and
make driver using regmap_*() functions instead.Signed-off-by: Robert Baldyga
Reviewed-by: Krzysztof Kozlowski
Acked-by: Mark Brown
Acked-by: Chanwoo Choi
Signed-off-by: Lee Jones
16 Jun, 2014
1 commit
-
This patch set the parent device of extcon device using first parameter of
devm_extco_dev_allocate() to remove duplicate code on all of extcon provider
drivers.Signed-off-by: Chanwoo Choi
Reported-by: Charles Keepax
Tested-by: Charles Keepax
Cc: Charles Keepax
Cc: Mark Brown
Cc: Graeme Gregory
Cc: Kishon Vijay Abraham I
Cc: Krzysztof Kozlowski