25 Aug, 2009

2 commits


14 Jul, 2008

1 commit

  • Initialize I2C pins on boards with CPM1/CPM2 controllers and document the
    i2c bus in booting-without-of.

    The boards don't have any I2C chips connected to the I2C bus, so unless
    some external chips are connected to the boards, this code is just an
    example of setting everything else up.

    Signed-off-by: Jochen Friedrich
    Signed-off-by: Kumar Gala

    Jochen Friedrich
     

06 Feb, 2008

1 commit

  • Of_get_parent and of_find_compatible_node do a of_node_get, and thus a
    corresponding of_code_put is needed in both the error case and the normal
    return case.

    The problem was found using the following semantic match.
    (http://www.emn.fr/x-info/coccinelle/)

    //
    @@
    type T,T1,T2;
    identifier E;
    statement S;
    expression x1,x2,x3;
    int ret;
    @@

    T E;
    ...
    * E = \(of_get_parent\|of_find_compatible_node\)(...);
    if (E == NULL) S
    ... when != of_node_put(...,(T1)E,...)
    when != if (E != NULL) { ... of_node_put(...,(T1)E,...); ...}
    when != x1 = (T1)E
    when != E = x3;
    when any
    if (...) {
    ... when != of_node_put(...,(T2)E,...)
    when != if (E != NULL) { ... of_node_put(...,(T2)E,...); ...}
    when != x2 = (T2)E
    (
    * return;
    |
    * return ret;
    )
    }
    //

    Signed-off-by: Julia Lawall
    Cc: Stephen Rothwell
    Cc: Benjamin Herrenschmidt
    Cc: Paul Mackerras
    Cc: Kumar Gala
    Signed-off-by: Andrew Morton
    Signed-off-by: Paul Mackerras

    Julia Lawall
     

28 Jan, 2008

1 commit


05 Oct, 2007

3 commits