11 Nov, 2011
1 commit
-
The report functions use NLA_PUT so we need to ensure that NET
is enabled.Reported-by: Luis Henriques
Signed-off-by: Herbert Xu
21 Oct, 2011
1 commit
-
Signed-off-by: Steffen Klassert
Signed-off-by: Herbert Xu
06 Aug, 2010
1 commit
-
If a scatterwalk chain contains an entry with an unaligned offset then
hash_walk_next() will cut off the next step at the next alignment point.However, if the entry ends before the next alignment point then we a loop,
which leads to a kernel oops.Fix this by checking whether the next aligment point is before the end of the
current entry.Signed-off-by: Szilveszter Ördög
Acked-by: David S. Miller
Signed-off-by: Herbert Xu
03 Mar, 2010
1 commit
-
The correct way to calculate the start of the aligned part of an
unaligned buffer is:offset = ALIGN(offset, alignmask + 1);
However, crypto_hash_walk_done() has:
offset += alignmask - 1;
offset = ALIGN(offset, alignmask + 1);which actually skips a whole block unless offset % (alignmask + 1) == 1.
This patch fixes the problem.
Signed-off-by: Szilveszter Ördög
Signed-off-by: Herbert Xu
24 Jul, 2009
1 commit
-
ahash_op_unaligned() and ahash_def_finup() allocate memory atomically,
regardless whether the request can sleep or not. This patch changes
this to use GFP_KERNEL if the request can sleep.Signed-off-by: Steffen Klassert
Signed-off-by: Herbert Xu
15 Jul, 2009
2 commits
-
When the alignment check was made unconditional for ahash we
may end up crashing on shash algorithms because we're always
calling alg->setkey instead of tfm->setkey.This patch fixes it.
Signed-off-by: Herbert Xu
-
This patch exports the finup operation where available and adds
a default finup operation for ahash. The operations final, finup
and digest also will now deal with unaligned result pointers by
copying it. Finally export/import operations are will now be
exported too.Signed-off-by: Herbert Xu
14 Jul, 2009
5 commits
-
We currently use GFP_ATOMIC in the unaligned setkey function
to allocate the temporary aligned buffer. Since setkey must
be called in a sleepable context, we can use GFP_KERNEL instead.Signed-off-by: Herbert Xu
-
Some unaligned buffers on the stack weren't zapped properly which
may cause secret data to be leaked. This patch fixes them by doing
a zero memset.It is also possible for us to place random kernel stack contents
in the digest buffer if a digest operation fails. This is fixed
by only copying if the operation succeeded.Signed-off-by: Herbert Xu
-
Now that all ahash implementations have been converted to the new
ahash type, we can remove old_ahash_alg and its associated support.Signed-off-by: Herbert Xu
-
This patch adds support for creating ahash instances and using
ahash as spawns.Signed-off-by: Herbert Xu
-
This patch converts crypto_ahash to the new style. The old ahash
algorithm type is retained until the existing ahash implementations
are also converted. All ahash users will automatically get the
new crypto_ahash type.Signed-off-by: Herbert Xu
31 May, 2009
1 commit
-
A quirk that we've always supported is having an sg entry that's
bigger than a page, or more generally an sg entry that crosses
page boundaries. Even though it would be better to explicitly have
to sg entries for this, we need to support it for the existing users,
in particular, IPsec.The new ahash sg walking code did try to handle this, but there was
a bug where we didn't increment the page so kept on walking on the
first page over an dover again.This patch fixes it.
Tested-by: Martin Willi
Signed-off-by: Herbert Xu
19 Feb, 2009
1 commit
-
crypto_ahash_show changed to use cra_ahash for digestsize reference.
Signed-off-by: Lee Nipper
Signed-off-by: Herbert Xu
25 Dec, 2008
3 commits
-
Since most cryptographic hash algorithms have no keys, this patch
makes the setkey function optional for ahash and shash.Signed-off-by: Herbert Xu
-
This patch allows shash algorithms to be used through the old hash
interface. This is a transitional measure so we can convert the
underlying algorithms to shash before converting the users across.Signed-off-by: Herbert Xu
-
It is often useful to save the partial state of a hash function
so that it can be used as a base for two or more computations.The most prominent example is HMAC where all hashes start from
a base determined by the key. Having an import/export interface
means that we only have to compute that base once rather than
for each message.Signed-off-by: Herbert Xu
10 Jul, 2008
4 commits
-
This patch adds the walking helpers for hash algorithms akin to
those of block ciphers. This is a necessary step before we can
reimplement existing hash algorithms using the new ahash interface.Signed-off-by: Herbert Xu
-
The base field in ahash_tfm appears to have been cut-n-pasted from
ablkcipher. It isn't needed here at all. Similarly, the info field
in ahash_request also appears to have originated from its cipher
counter-part and is vestigial.Signed-off-by: Herbert Xu
-
The digest size check on hash algorithms is incorrect. It's
perfectly valid for hash algorithms to have a digest length
longer than their block size. For example crc32c has a block
size of 1 and a digest size of 4. Rather than having it lie
about its block size, this patch fixes the checks to do what
they really should which is to bound the digest size so that
code placing the digest on the stack continue to work.HMAC however still needs to check this as it's only defined
for such algorithms.Signed-off-by: Herbert Xu
-
This patch adds asynchronous hash and digest support.
Signed-off-by: Loc Ho
Signed-off-by: Herbert Xu
