31 Mar, 2011

1 commit


25 May, 2010

1 commit


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

08 Mar, 2010

1 commit

  • A pointer to cfag12864bfb_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König
    Acked-by: Miguel Ojeda
    Cc: Andrew Morton
    Cc: Avuton Olrich
    Cc: Antonino Daplas
    Signed-off-by: Greg Kroah-Hartman

    Uwe Kleine-König
     

01 Apr, 2009

1 commit

  • Remove PARPORT dependency for Auxiliary Display support.

    This is not needed since the dependency for the KS0108 driver is
    PARPORT_PC.

    Signed-off-by: H Hartley Sweeten
    Cc: Miguel Ojeda Sandonis
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    H Hartley Sweeten
     

25 Jul, 2008

1 commit

  • - Use BUILD_BUG_ON for CFAG12864B_SIZE instead of runtime-check

    - Use get_zeroed_page()

    Signed-off-by: Akinobu Mita
    Cc: Miguel Ojeda Sandonis
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Akinobu Mita
     

05 Jul, 2008

1 commit


23 Aug, 2007

1 commit

  • This one-liner patch fixes a bug in drivers/auxdisplay/cfag12864b.c

    At cfag12864b_init(), the driver tries to kalloc some memory in the
    variable cfag12864b_cache.

    Then, as usual, it checks if the call failed. However, it checks
    cfag12864b_buffer instead.

    This patch changes the "cfag12864b_buffer" to "cfag12864b_cache" so the
    correct variable is checked.

    Signed-off-by: Miguel Ojeda
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Miguel Ojeda
     

19 Aug, 2007

1 commit


17 Jul, 2007

1 commit

  • Make a "menuconfig" out of the Kconfig objects "menu, ..., endmenu",
    so that the user can disable all the options in that menu at once
    instead of having to disable each option separately.

    Signed-off-by: Jan Engelhardt
    Acked-by: Miguel Ojeda Sandonis
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jan Engelhardt
     

01 Jun, 2007

1 commit

  • Because the framebuffer memory is allocated system RAM, use the sys_ drawing
    libraries. It also fixes the following compile error:

    LD .tmp_vmlinux1
    drivers/built-in.o:(.data+0x8b48): undefined reference to `cfb_fillrect'
    drivers/built-in.o:(.data+0x8b50): undefined reference to `cfb_copyarea'
    drivers/built-in.o:(.data+0x8b58): undefined reference to `cfb_imageblit'

    [adaplas]
    Use fb_sys_read/write for the same reasons as above.

    Signed-off-by: Avuton Olrich
    Signed-off-by: Antonino Daplas
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Avuton Olrich
     

10 May, 2007

1 commit


21 Feb, 2007

1 commit

  • The problem comes when ks0108/cfag12864b are built-in and no parallel port is
    present. ks0108_init() is called first, as it should be, but fails to load
    (as there is no parallel port to use).

    After that, cfag12864b_init() gets called, without knowing anything about
    ks0108 failed, and calls ks0108_writecontrol(), which dereferences an
    uninitialized pointer.

    Init order is OK, I think. The problem is how to stop cfag12864b_init() being
    called if ks0108 failed to load. modprobe does it for us, but, how when
    built-in?

    Signed-off-by: Miguel Ojeda Sandonis
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Miguel Ojeda
     

12 Feb, 2007

1 commit

  • Add support for auxiliary displays, the ks0108 LCD controller, the
    cfag12864b LCD and adds a framebuffer device: cfag12864bfb.

    - Add a "auxdisplay/" folder in "drivers/" for auxiliary display
    drivers.

    - Add support for the ks0108 LCD Controller as a device driver. (uses
    parport interface)

    - Add support for the cfag12864b LCD as a device driver. (uses ks0108
    LCD Controller driver)

    - Add a framebuffer device called cfag12864bfb. (uses cfag12864b LCD
    driver)

    - Add the usual Documentation, includes, Makefiles, Kconfigs,
    MAINTAINERS, CREDITS...

    - Miguel Ojeda will maintain all the stuff above.

    [rdunlap@xenotime.net: workqueue fixups]
    [akpm@osdl.org: kconfig fix]
    Signed-off-by: Miguel Ojeda Sandonis
    Cc: Greg KH
    Acked-by: Paulo Marques
    Cc: "Randy.Dunlap"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Miguel Ojeda Sandonis