Eric Lee / smarc-fsl-linux-kernel

19 Nov, 2011

1 commit

  • fe7484834   USB: convert some miscellanies drivers to use module_usb_driver() ... Browse Code »

    This converts the remaining USB drivers in the kernel to use the
    module_usb_driver() macro which makes the code smaller and a bit
    simpler.

    Added bonus is that it removes some unneeded kernel log messages about
    drivers loading and/or unloading.

    Cc: Guenter Roeck
    Cc: Jean Delvare
    Cc: Ben Dooks
    Cc: Till Harbaum
    Cc: Karsten Keil
    Cc: Chris Ball
    Cc: David Woodhouse
    Cc: Lauro Ramos Venancio
    Cc: Aloisio Almeida Jr
    Cc: Samuel Ortiz
    Cc: Steve Glendinning
    Cc: Florian Tobias Schandinat
    Cc: Evgeniy Polyakov
    Cc: Wim Van Sebroeck
    Cc: "David S. Miller"
    Cc: Jesper Juhl
    Cc: Artem Bityutskiy
    Cc: Jamie Iles
    Cc: Andrew Morton
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

01 Nov, 2011

1 commit

21 Jun, 2011

1 commit

12 Jun, 2011

1 commit

07 Jun, 2011

1 commit

26 May, 2011

1 commit

  • 367bbf2aa   isdn: netjet - blacklist Digium TDM400P ... Browse Code »

    [2nd try ... 1st attempt didn't make it to netdev mailing list]

    A quick google search reveals that people with this card are blacklisting it
    in the initramfs and in the module blacklist based on a statement that it
    is unsupported. Since the older Digium is also unsupported I'm pretty
    confident that this newer card is also not supported.

    lspci -xxx -vv shows

    04:07.0 Communication controller: Tiger Jet Network Inc. Tiger3XX Modem/ISDN interface
    Subsystem: Device b100:0003
    P.

    ----8
    Signed-off-by: David S. Miller

    Prarit Bhargava
     

18 Apr, 2011

2 commits

31 Mar, 2011

1 commit

14 Jan, 2011

1 commit

  • 008d23e48   Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial ... Browse Code »

    * 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (43 commits)
    Documentation/trace/events.txt: Remove obsolete sched_signal_send.
    writeback: fix global_dirty_limits comment runtime -> real-time
    ppc: fix comment typo singal -> signal
    drivers: fix comment typo diable -> disable.
    m68k: fix comment typo diable -> disable.
    wireless: comment typo fix diable -> disable.
    media: comment typo fix diable -> disable.
    remove doc for obsolete dynamic-printk kernel-parameter
    remove extraneous 'is' from Documentation/iostats.txt
    Fix spelling milisec -> ms in snd_ps3 module parameter description
    Fix spelling mistakes in comments
    Revert conflicting V4L changes
    i7core_edac: fix typos in comments
    mm/rmap.c: fix comment
    sound, ca0106: Fix assignment to 'channel'.
    hrtimer: fix a typo in comment
    init/Kconfig: fix typo
    anon_inodes: fix wrong function name in comment
    fix comment typos concerning "consistent"
    poll: fix a typo in comment
    ...

    Fix up trivial conflicts in:
    - drivers/net/wireless/iwlwifi/iwl-core.c (moved to iwl-legacy.c)
    - fs/ext4/ext4.h

    Also fix missed 'diabled' typo in drivers/net/bnx2x/bnx2x.h while at it.

    Linus Torvalds
     

16 Nov, 2010

1 commit

02 Nov, 2010

1 commit

  • b595076a1   tree-wide: fix comment/printk typos ... Browse Code »

    "gadget", "through", "command", "maintain", "maintain", "controller", "address",
    "between", "initiali[zs]e", "instead", "function", "select", "already",
    "equal", "access", "management", "hierarchy", "registration", "interest",
    "relative", "memory", "offset", "already",

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Jiri Kosina

    Uwe Kleine-König
     

28 Oct, 2010

1 commit

  • 4101e976e   drivers/isdn: delete double assignment ... Browse Code »

    Delete successive assignments to the same location. In the first case, the
    hscx array has two elements, so change the assignment to initialize the
    second one. In the second case, the two assignments are simply identical.
    Furthermore, neither is necessary, because the effect of the assignment is
    only visible in the next line, in the assignment in the if test. The patch
    inlines the right hand side value in the latter assignment and pulls that
    assignment out of the if test.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @@
    expression i;
    @@

    *i = ...;
    i = ...;
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

10 Aug, 2010

1 commit

05 Aug, 2010

1 commit

  • 3cfc2c42c   Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial ... Browse Code »

    * 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (48 commits)
    Documentation: update broken web addresses.
    fix comment typo "choosed" -> "chosen"
    hostap:hostap_hw.c Fix typo in comment
    Fix spelling contorller -> controller in comments
    Kconfig.debug: FAIL_IO_TIMEOUT: typo Faul -> Fault
    fs/Kconfig: Fix typo Userpace -> Userspace
    Removing dead MACH_U300_BS26
    drivers/infiniband: Remove unnecessary casts of private_data
    fs/ocfs2: Remove unnecessary casts of private_data
    libfc: use ARRAY_SIZE
    scsi: bfa: use ARRAY_SIZE
    drm: i915: use ARRAY_SIZE
    drm: drm_edid: use ARRAY_SIZE
    synclink: use ARRAY_SIZE
    block: cciss: use ARRAY_SIZE
    comment typo fixes: charater => character
    fix comment typos concerning "challenge"
    arm: plat-spear: fix typo in kerneldoc
    reiserfs: typo comment fix
    update email address
    ...

    Linus Torvalds
     

16 Jul, 2010

3 commits

12 Jul, 2010

1 commit

01 Jun, 2010

1 commit

  • b42d9165e   drivers/isdn/hardware/mISDN: Use GFP_ATOMIC when a lock is held ... Browse Code »

    The function inittiger is only called from nj_init_card, where a lock is held.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @gfp exists@
    identifier fn;
    position p;
    @@

    fn(...) {
    ... when != spin_unlock_irqrestore
    when any
    GFP_KERNEL@p
    ... when any
    }

    @locked@
    identifier gfp.fn;
    @@

    spin_lock_irqsave(...)
    ... when != spin_unlock_irqrestore
    fn(...)

    @depends on locked@
    position gfp.p;
    @@

    - GFP_KERNEL@p
    + GFP_ATOMIC
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

29 May, 2010

1 commit

  • e72e9f381   drivers/isdn/hardware/mISDN: Add missing spin_unlock ... Browse Code »

    Add a spin_unlock missing on the error path. The return value of write_reg
    seems to be completely ignored, so it seems that the lock should be
    released in every case.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @@
    expression E1;
    @@

    * spin_lock(E1,...);

    * spin_unlock(E1,...);
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     

23 Apr, 2010

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

29 Mar, 2010

1 commit

16 Mar, 2010

1 commit

  • d00561a2f   ISDN: Add PCI ID for HFC-2S/4S Beronet Card PCIe ... Browse Code »

    A few subdevice IDs seem to have been dropped when hfc_multi was
    included upstream, just compare the list at
    http://www.openvox.cn/viewvc/misdn/trunk/hfc_multi.c?revision=75&view=annotate#l175
    with the IDs in drivers/isdn/hardware/mISDN/hfcmulti.c

    Added PCIe 2 Port card and LED settings (same as PCI)
    Do not use /KKe

    Signed-off-by: Lars Ellenberg
    Signed-off-by: Karsten Keil
    Signed-off-by: David S. Miller

    Lars Ellenberg
     

08 Mar, 2010

1 commit

05 Feb, 2010

1 commit

04 Feb, 2010

3 commits

  • 650b2ef5d   mISDN: positive error return should be negative in mode_hfcmulti() ... Browse Code »

    The error return should be negative. Its only caller that acts upon its
    return, handle_bmsg(), transmits the positive error but can also return
    negative errors.

    Signed-off-by: Roel Kluin
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Roel Kluin
     
  • 3e5981774   isdn: mISDN, don't compile unused stuff ... Browse Code »

    Remove these compiler warnings:

    drivers/isdn/hardware/mISDN/w6692.c:534: warning: `setvolume' defined but not used
    drivers/isdn/hardware/mISDN/w6692.c:561: warning: `enable_pots' defined but not used

    by moving the functions inside #if 0 ... #endif. And an alternative is
    to remove them completely if nobody has plans to use them.

    Signed-off-by: Jiri Slaby
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Jiri Slaby
     
  • f0f4d641d   hardware/mISDN/mISDNinfineon.c: bail out of loop on error ... Browse Code »

    If setup_instance() fails we kfree() the card, and then use it in the next
    loop iteration. So lets bail out of the loop instead.

    Coverity CID: 13357

    Signed-off-by: Darren Jenkins
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Darren Jenkins
     

04 Jan, 2010

1 commit

  • 073bd90f0   drivers/isdn: eliminate duplicated test ... Browse Code »

    The code checked slot_rx twice. Check slot_tx by analogy with the bank
    case.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @@
    expression E;
    @@

    (
    *E && E
    |
    *E || E
    )
    //

    Signed-off-by: Julia Lawall
    Cc: Karsten Keil
    Signed-off-by: Andrew Morton
    Signed-off-by: David S. Miller

    Julia Lawall
     

10 Dec, 2009

1 commit

  • 4ef58d4e2   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (42 commits)
    tree-wide: fix misspelling of "definition" in comments
    reiserfs: fix misspelling of "journaled"
    doc: Fix a typo in slub.txt.
    inotify: remove superfluous return code check
    hdlc: spelling fix in find_pvc() comment
    doc: fix regulator docs cut-and-pasteism
    mtd: Fix comment in Kconfig
    doc: Fix IRQ chip docs
    tree-wide: fix assorted typos all over the place
    drivers/ata/libata-sff.c: comment spelling fixes
    fix typos/grammos in Documentation/edac.txt
    sysctl: add missing comments
    fs/debugfs/inode.c: fix comment typos
    sgivwfb: Make use of ARRAY_SIZE.
    sky2: fix sky2_link_down copy/paste comment error
    tree-wide: fix typos "couter" -> "counter"
    tree-wide: fix typos "offest" -> "offset"
    fix kerneldoc for set_irq_msi()
    spidev: fix double "of of" in comment
    comment typo fix: sybsystem -> subsystem
    ...

    Linus Torvalds
     

08 Dec, 2009

1 commit

04 Dec, 2009

1 commit

  • af901ca18   tree-wide: fix assorted typos all over the place ... Browse Code »

    That is "success", "unknown", "through", "performance", "[re|un]mapping"
    , "access", "default", "reasonable", "[con]currently", "temperature"
    , "channel", "[un]used", "application", "example","hierarchy", "therefore"
    , "[over|under]flow", "contiguous", "threshold", "enough" and others.

    Signed-off-by: André Goddard Rosa
    Signed-off-by: Jiri Kosina

    André Goddard Rosa
     

17 Nov, 2009

1 commit

16 Nov, 2009

1 commit

11 Nov, 2009

1 commit

29 Sep, 2009

1 commit

  • 8823ad31c   isdn: fix netjet/isdnhdlc build errors ... Browse Code »

    Commit cb3824bade2549d7ad059d5802da43312540fdee didn't fix this problem.

    Fix build errors in netjet, using isdnhdlc module:

    drivers/built-in.o: In function `mode_tiger':
    netjet.c:(.text+0x1ca0c7): undefined reference to `isdnhdlc_rcv_init'
    netjet.c:(.text+0x1ca0d4): undefined reference to `isdnhdlc_out_init'
    drivers/built-in.o: In function `fill_dma':
    netjet.c:(.text+0x1ca2bd): undefined reference to `isdnhdlc_encode'
    drivers/built-in.o: In function `read_dma':
    netjet.c:(.text+0x1ca614): undefined reference to `isdnhdlc_decode'
    drivers/built-in.o: In function `nj_irq':
    netjet.c:(.text+0x1cb07a): undefined reference to `isdnhdlc_encode'

    drivers/built-in.o: In function `isdnhdlc_decode':
    (.text+0x1c2088): undefined reference to `crc_ccitt_table'
    drivers/built-in.o: In function `isdnhdlc_encode':
    (.text+0x1c2339): undefined reference to `crc_ccitt_table'

    Signed-off-by: Randy Dunlap
    Signed-off-by: David S. Miller

    Randy Dunlap
     

27 Jul, 2009

2 commits