31 Dec, 2011

4 commits


25 Sep, 2011

2 commits


07 Sep, 2011

1 commit


04 Sep, 2011

1 commit

  • Usage of these flags has been deprecated for nearly 4 years by:

    commit f77bf01425b11947eeb3b5b54685212c302741b8
    Author: Sam Ravnborg
    Date: Mon Oct 15 22:25:06 2007 +0200

    kbuild: introduce ccflags-y, asflags-y and ldflags-y

    Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
    line use. By default, gmake(1) do not override command line setting, so this is
    likely to result in build failure or unexpected behavior.

    Replace their usage by Kbuild's `{as,cc,ld}flags-y'.

    Cc: Sam Ravnborg
    Cc: Mauro Carvalho Chehab
    Cc: linux-media@vger.kernel.org
    Signed-off-by: Arnaud Lacombe
    Acked-by: Laurent Pinchart
    Signed-off-by: Mauro Carvalho Chehab

    Arnaud Lacombe
     

22 Jun, 2011

1 commit

  • Remove linux/mm.h inclusion from netdevice.h -- it's unused (I've checked manually).

    To prevent mm.h inclusion via other channels also extract "enum dma_data_direction"
    definition into separate header. This tiny piece is what gluing netdevice.h with mm.h
    via "netdevice.h => dmaengine.h => dma-mapping.h => scatterlist.h => mm.h".
    Removal of mm.h from scatterlist.h was tried and was found not feasible
    on most archs, so the link was cutoff earlier.

    Hope people are OK with tiny include file.

    Note, that mm_types.h is still dragged in, but it is a separate story.

    Signed-off-by: Alexey Dobriyan
    Signed-off-by: David S. Miller

    Alexey Dobriyan
     

07 Jun, 2011

1 commit


20 May, 2011

3 commits


31 Mar, 2011

1 commit


03 Mar, 2011

1 commit

  • mantis_pci.c is including asm/pgtable.h and it's leading to a build failure on
    arm. It has been noticed here :

    https://buildd.debian.org/fetch.cgi?pkg=linux-2.6&arch=armel&ver=2.6.38~rc6-1~experimental.1&stamp=1298430952&file=log&as=raw

    As this header doesn't seem to be used, I'm removing it. I've build tested it
    with arm and x86.

    Signed-off-by: Arnaud Patard
    Signed-off-by: Mauro Carvalho Chehab

    Arnaud Patard (Rtp)
     

08 Jan, 2011

1 commit

  • * 'for-2.6.38' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq: (33 commits)
    usb: don't use flush_scheduled_work()
    speedtch: don't abuse struct delayed_work
    media/video: don't use flush_scheduled_work()
    media/video: explicitly flush request_module work
    ioc4: use static work_struct for ioc4_load_modules()
    init: don't call flush_scheduled_work() from do_initcalls()
    s390: don't use flush_scheduled_work()
    rtc: don't use flush_scheduled_work()
    mmc: update workqueue usages
    mfd: update workqueue usages
    dvb: don't use flush_scheduled_work()
    leds-wm8350: don't use flush_scheduled_work()
    mISDN: don't use flush_scheduled_work()
    macintosh/ams: don't use flush_scheduled_work()
    vmwgfx: don't use flush_scheduled_work()
    tpm: don't use flush_scheduled_work()
    sonypi: don't use flush_scheduled_work()
    hvsi: don't use flush_scheduled_work()
    xen: don't use flush_scheduled_work()
    gdrom: don't use flush_scheduled_work()
    ...

    Fixed up trivial conflict in drivers/media/video/bt8xx/bttv-input.c
    as per Tejun.

    Linus Torvalds
     

29 Dec, 2010

9 commits

  • Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • Remote keytables had different names all over the place. Part of the fault
    is due to a bad naming when rc subsystem was created, but there were lots
    of old names that were still here.

    Use a common standard for everything.

    Patch generated by this script:

    for i in `find drivers/staging -type f -name *.[ch]` `find include/media -type f -name *.[ch]` `find drivers/media -type f -name *.[ch]`; do sed s,ir_scancode,rc_map_table,g a && mv a $i; done
    for i in `find drivers/staging -type f -name *.[ch]` `find include/media -type f -name *.[ch]` `find drivers/media -type f -name *.[ch]`; do sed s,ir_codes_,rc_map_,g a && mv a $i; done
    for i in `find drivers/staging -type f -name *.[ch]` `find include/media -type f -name *.[ch]` `find drivers/media -type f -name *.[ch]`; do sed s,rc_key_map,rc_map_table,g a && mv a $i; done
    for i in `find drivers/staging -type f -name *.[ch]` `find include/media -type f -name *.[ch]` `find drivers/media -type f -name *.[ch]`; do sed s,rc_map_table_size,rc_map_size,g a && mv a $i; done

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • for i in `find drivers/staging -type f -name *.[ch]` `find include/media -type f -name *.[ch]` `find drivers/media -type f -name *.[ch]`; do sed s,IR_TYPE,RC_TYPE,g a && mv a $i; done
    for i in `find drivers/staging -type f -name *.[ch]` `find include/media -type f -name *.[ch]` `find drivers/media -type f -name *.[ch]`; do sed s,ir_type,rc_type,g a && mv a $i; done

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • The Remote Controller subsystem is meant to be used not only by Infra Red
    but also for similar types of Remote Controllers. The core is not specific
    to Infra Red. As such, rename:
    - ir-core.h to rc-core.h
    - IR_CORE to RC_CORE
    - namespace inside rc-core.c/rc-core.h

    To be consistent with the other changes.

    No functional change on this patch.

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • This function is declared extern and exported, and should not be given
    a generic name which may conflict with gpiolib in future.

    Signed-off-by: Ben Hutchings
    Signed-off-by: Manu Abraham
    Signed-off-by: Mauro Carvalho Chehab

    Ben Hutchings
     
  • Convert the driver to use the dvb_attach macro to avoid the hard dependency
    on the frontend drivers. The hard dependecy will result in loading a
    number of unused frontends, and unwanted automatic dereferencing.

    This fixes a bug where unloading the mantis driver will derefence any
    attached frontend twice, which will cause an oops if the same frontend is
    used by another driver.

    Signed-off-by: Bjørn Mork
    Signed-off-by: Manu Abraham
    Signed-off-by: Mauro Carvalho Chehab

    Bjørn Mork
     
  • After dvb-core has called mantis-fe->stop_feed(dvbdmxfeed)
    the last time (count to zero), no data should ever be copied
    with dvb_dmx_swfilter() by a tasklet: the target structure
    might be in an unusable state. Caller of mantis_fe->stop_feed()
    assumes that feeding is stopped after stop_feed() has been
    called, ie. dvb_dmx_swfilter() isn't running, and won't be called.

    There is a risk that dvb_dmx_swfilter() references freed resources
    (memory or spinlocks or ???) causing instabilities. Thus
    tasklet_disable(&mantis->tasklet) must be called inside of
    mantis-fe->stop_feed(dvbdmxfeed) when necessary.

    Signed-off-by: Marko Ristola
    Signed-off-by: Manu Abraham
    Signed-off-by: Mauro Carvalho Chehab

    Marko Ristola
     
  • use the macro to make modules auto-loadable

    Thanks to Ozan Çağlayan for pointing it out

    Signed-off-by: Manu Abraham
    Signed-off-by: Mauro Carvalho Chehab

    Manu Abraham
     
  • This patch merges the ir_input_dev and ir_dev_props structs into a single
    struct called rc_dev. The drivers and various functions in rc-core used
    by the drivers are also changed to use rc_dev as the primary interface
    when dealing with rc-core.

    This means that the input_dev is abstracted away from the drivers which
    is necessary if we ever want to support multiple input devs per rc device.

    The new API is similar to what the input subsystem uses, i.e:
    rc_device_alloc()
    rc_device_free()
    rc_device_register()
    rc_device_unregister()

    [mchehab@redhat.com: Fix compilation on mceusb and cx231xx, due to merge conflicts]
    Signed-off-by: David Härdeman
    Acked-by: Jarod Wilson
    Tested-by: Jarod Wilson
    Signed-off-by: Mauro Carvalho Chehab

    David Härdeman
     

24 Dec, 2010

1 commit

  • flush_scheduled_work() is deprecated and scheduled to be removed.

    * Flush the used works directly.

    * Replace the deprecated cancel_rearming_delayed_work() +
    flush_scheduled_work() -> cancel_delayed_work_sync().

    * Make sure mantis->uart_work isn't running on exit.

    Signed-off-by: Tejun Heo
    Cc: Mauro Carvalho Chehab
    Cc: linux-media@vger.kernel.org

    Tejun Heo
     

21 Oct, 2010

2 commits


25 Aug, 2010

1 commit

  • This build bug triggers:

    drivers/built-in.o: In function `mantis_exit':
    (.text+0x377413): undefined reference to `ir_input_unregister'
    drivers/built-in.o: In function `mantis_input_init':
    (.text+0x3774ff): undefined reference to `__ir_input_register'

    If MANTIS_CORE is enabled but IR_CORE is not. Add the correct
    dependency.

    Signed-off-by: Ingo Molnar
    Acked-by: Randy Dunlap
    Signed-off-by: Linus Torvalds

    Ingo Molnar
     

03 Aug, 2010

2 commits


19 May, 2010

1 commit


18 May, 2010

2 commits


30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

27 Feb, 2010

2 commits


17 Jan, 2010

3 commits

  • >
    >
    >
    > CONFIG_INPUT=n

    As reported by Randy Dunlap :
    > ERROR: "ir_input_register" [drivers/media/dvb/mantis/mantis_core.ko] undefined!
    > ERROR: "ir_input_unregister" [drivers/media/dvb/mantis/mantis_core.ko] undefined!
    > ERROR: "ir_input_init" [drivers/media/dvb/mantis/mantis_core.ko] undefined!
    > ERROR: "input_free_device" [drivers/media/dvb/mantis/mantis_core.ko] undefined!
    > ERROR: "input_allocate_device" [drivers/media/dvb/mantis/mantis_core.ko] undefined!

    Signed-off-by: Manu Abraham
    Acked-by: Randy Dunlap
    Signed-off-by: Mauro Carvalho Chehab

    Manu Abraham
     
  • WARNING: drivers/media/dvb/mantis/built-in.o(.devinit.text+0x13d7): Section mismatch in reference from the function mantis_pci_probe() to the function .devexit.text:mantis_i2c_exit()
    The function __devinit mantis_pci_probe() references
    a function __devexit mantis_i2c_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_i2c_exit() so it may be used outside an exit section.

    WARNING: drivers/media/dvb/mantis/built-in.o(.devinit.text+0x1433): Section mismatch in reference from the function mantis_pci_probe() to the function .devexit.text:mantis_pci_exit()
    The function __devinit mantis_pci_probe() references
    a function __devexit mantis_pci_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_pci_exit() so it may be used outside an exit section.

    WARNING: drivers/media/dvb/mantis/built-in.o(.devinit.text+0x185e): Section mismatch in reference from the function hopper_pci_probe() to the function
    .devexit.text:mantis_i2c_exit()
    The function __devinit hopper_pci_probe() references
    a function __devexit mantis_i2c_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_i2c_exit() so it may be used outside an exit section.

    WARNING: drivers/media/dvb/mantis/built-in.o(.devinit.text+0x18ba): Section mismatch in reference from the function hopper_pci_probe() to the function .devexit.text:mantis_pci_exit()
    The function __devinit hopper_pci_probe() references
    a function __devexit mantis_pci_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_pci_exit() so it may be used outside an exit section.

    WARNING: drivers/media/dvb/built-in.o(.devinit.text+0x68b8): Section mismatch in reference from the function mantis_pci_probe() to the function .devexit.text:mantis_i2c_exit()
    The function __devinit mantis_pci_probe() references
    a function __devexit mantis_i2c_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_i2c_exit() so it may be used outside an exit section.

    WARNING: drivers/media/dvb/built-in.o(.devinit.text+0x6914): Section mismatch in reference from the function mantis_pci_probe() to the function .devexit.text:mantis_pci_exit()
    The function __devinit mantis_pci_probe() references
    a function __devexit mantis_pci_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_pci_exit() so it may be used outside an exit section.

    WARNING: drivers/media/dvb/built-in.o(.devinit.text+0x6d3f): Section mismatch in reference from the function hopper_pci_probe() to the function .devexit.text:mantis_i2c_exit()
    The function __devinit hopper_pci_probe() references
    a function __devexit mantis_i2c_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_i2c_exit() so it may be used outside an exit section.

    WARNING: drivers/media/dvb/built-in.o(.devinit.text+0x6d9b): Section mismatch in reference from the function hopper_pci_probe() to the function .devexit.text:mantis_pci_exit()
    The function __devinit hopper_pci_probe() references
    a function __devexit mantis_pci_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_pci_exit() so it may be used outside an exit section.

    WARNING: drivers/media/built-in.o(.devinit.text+0x14634): Section mismatch in reference from the function mantis_pci_probe() to the function .devexit.text:mantis_i2c_exit()
    The function __devinit mantis_pci_probe() references
    a function __devexit mantis_i2c_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_i2c_exit() so it may be used outside an exit section.

    WARNING: drivers/media/built-in.o(.devinit.text+0x14690): Section mismatch in reference from the function mantis_pci_probe() to the function .devexit.text:mantis_pci_exit()
    The function __devinit mantis_pci_probe() references
    a function __devexit mantis_pci_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_pci_exit() so it may be used outside an exit section.

    WARNING: drivers/media/built-in.o(.devinit.text+0x14abb): Section mismatch in reference from the function hopper_pci_probe() to the function .devexit.text:mantis_i2c_exit()
    The function __devinit hopper_pci_probe() references
    a function __devexit mantis_i2c_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_i2c_exit() so it may be used outside an exit section.

    WARNING: drivers/media/built-in.o(.devinit.text+0x14b17): Section mismatch in reference from the function hopper_pci_probe() to the function .devexit.text:mantis_pci_exit()
    The function __devinit hopper_pci_probe() references
    a function __devexit mantis_pci_exit().
    This is often seen when error handling in the init function
    uses functionality in the exit path.
    The fix is often to remove the __devexit annotation of
    mantis_pci_exit() so it may be used outside an exit section.

    Acked-by: Manu Abraham
    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     
  • drivers/media/dvb/mantis/mantis_pci.c: In function ‘mantis_pci_init’:
    drivers/media/dvb/mantis/mantis_pci.c:76: warning: ‘DMA_nnBIT_MASK’ is deprecated

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab