Eric Lee / smarc-fsl-linux-kernel

19 Nov, 2011

1 commit

  • ecb3b2b35   USB: convert drivers/media/* to use module_usb_driver() ... Browse Code »

    This converts the drivers in drivers/media/* to use the
    module_usb_driver() macro which makes the code smaller and a bit
    simpler.

    Added bonus is that it removes some unneeded kernel log messages about
    drivers loading and/or unloading.

    Cc: Mauro Carvalho Chehab
    Cc: Luca Risolia
    Cc: Jean-Francois Moine
    Cc: Frank Zago
    Cc: Olivier Lorin
    Cc: Erik Andren
    Cc: Hans de Goede
    Cc: Brian Johnson
    Cc: Leandro Costantino
    Cc: Antoine Jacquet
    Cc: Jarod Wilson
    Cc: Florian Mickler
    Cc: Antti Palosaari
    Cc: Michael Krufky
    Cc: "David Härdeman"
    Cc: Florent Audebert
    Cc: Sam Doshi
    Cc: Manu Abraham
    Cc: Olivier Grenie
    Cc: Patrick Boettcher
    Cc: "Igor M. Liplianin"
    Cc: Derek Kelly
    Cc: Malcolm Priestley
    Cc: Steven Toth
    Cc: "André Weidemann"
    Cc: Martin Wilks
    Cc: Tejun Heo
    Cc: Jose Alberto Reguero
    Cc: David Henningsson
    Cc: Paul Gortmaker
    Cc: Joe Perches
    Cc: Jesper Juhl
    Cc: Lucas De Marchi
    Cc: Hans Verkuil
    Cc: Alexey Khoroshilov
    Cc: Anssi Hannula
    Cc: Rafi Rubin
    Cc: Dan Carpenter
    Cc: Paul Bender
    Cc: Devin Heitmueller
    Cc: "Márcio A Alves"
    Cc: Julia Lawall
    Cc: Laurent Pinchart
    Cc: Chris Rankin
    Cc: Lee Jones
    Cc: Andy Walls
    Cc: Andrew Morton
    Cc: Mike Frysinger
    Cc: Dean Anderson
    Cc: Pete Eberlein
    Cc: Arvydas Sidorenko
    Cc: Andrea Anacleto
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

07 Sep, 2011

1 commit

28 Jul, 2011

2 commits

20 May, 2011

3 commits

22 Mar, 2011

1 commit

  • 2b97e2201   [media] double mutex lock in drivers/media/radio/si470x/radio-si470x- ... Browse Code »

    KERNEL_VERSION: 2.6.37
    common.c in function ssize_t si470x_fops_read.

    1. First mutex_lock on &radio->lock in line 441
    2. Second in line 462

    I think that mutex in line 462 is not needed.

    433static ssize_t si470x_fops_read(struct file *file, char __user *buf,
    434 size_t count, loff_t *ppos)
    435{
    ....
    441 mutex_lock(&radio->lock);
    442 if ((radio->registers[SYSCONFIG1] & SYSCONFIG1_RDS) == 0)
    443 si470x_rds_on(radio);
    444
    445 /* block if no new data available */
    446 while (radio->wr_index == radio->rd_index) {
    447 if (file->f_flags & O_NONBLOCK) {
    448 retval = -EWOULDBLOCK;
    449 goto done;
    450 }
    451 if (wait_event_interruptible(radio->read_queue,
    452 radio->wr_index != radio->rd_index) < 0) {
    453 retval = -EINTR;
    454 goto done;
    455 }
    456 }
    457
    458 /* calculate block count from byte count */
    459 count /= 3;
    460
    461 /* copy RDS block out of internal buffer and to user buffer */
    462 mutex_lock(&radio->lock);

    Found by Linux Device Drivers Verification Project

    Remove second mutex.

    Signed-off-by: Alexander Strakh
    Signed-off-by: Mauro Carvalho Chehab

    iceberg
     

19 Jan, 2011

2 commits

29 Dec, 2010

1 commit

  • b9218f2f1   [media] saa6588: rename rds.h to saa6588.h ... Browse Code »

    The naming of the media/rds.h header suggested that it was a generic
    RDS header, when in fact it is just a saa6588 module API that is
    internal to the kernel.

    Rename the header and the struct and defines in it to make this clear.

    Also removed the header include in radio-si470x.h (not used anymore)
    and from ioctl-number.txt (it's internal to the kernel and never called
    from userspace).

    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     

18 Nov, 2010

1 commit

23 Oct, 2010

1 commit

21 Oct, 2010

2 commits

30 Sep, 2010

1 commit

03 Aug, 2010

1 commit

  • 73c994e4f   V4L/DVB: si470x: -EINVAL overwritten in si470x_vidioc_s_tuner() ... Browse Code »

    This patch to the si470x_vidioc_s_tuner function was developed in
    cooperation with Roel Kluin . It sets the default
    retval to 0 instead of -EINVAL, identical to what is done in all other
    set/get functions of v4l2_ioctl_ops. This is just as cosmetic change, as
    retval is directly overwritten by the si470x_disconnect_check() anyway.

    Signed-off-by: Tobias Lorenz
    Signed-off-by: Mauro Carvalho Chehab

    Tobias Lorenz
     

03 Jun, 2010

1 commit

  • fbae3fb15   i2c: Remove all i2c_set_clientdata(client, NULL) in drivers ... Browse Code »

    I2C drivers can use the clientdata-pointer to point to private data. As I2C
    devices are not really unregistered, but merely detached from their driver, it
    used to be the drivers obligation to clear this pointer during remove() or a
    failed probe(). As a couple of drivers forgot to do this, it was agreed that it
    was cleaner if the i2c-core does this clearance when appropriate, as there is
    no guarantee for the lifetime of the clientdata-pointer after remove() anyhow.
    This feature was added to the core with commit
    e4a7b9b04de15f6b63da5ccdd373ffa3057a3681 to fix the faulty drivers.

    As there is no need anymore to clear the clientdata-pointer, remove all current
    occurrences in the drivers to simplify the code and prevent confusion.

    Signed-off-by: Wolfram Sang
    Acked-by: Mark Brown
    Acked-by: Greg Kroah-Hartman
    Acked-by: Richard Purdie
    Acked-by: Dmitry Torokhov
    Signed-off-by: Jean Delvare

    Wolfram Sang
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

27 Feb, 2010

3 commits

16 Dec, 2009

4 commits

12 Sep, 2009

5 commits