21 Oct, 2010
2 commits
-
Add an ext_lock argument to the videobuf init functions. This allows
drivers to pass the vdev->lock pointer (or any other externally held lock)
to videobuf. For now all drivers just pass NULL.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Currently videobuf uses the vb_lock mutex to lock its data structures.
But this locking will (optionally) move into the v4l2 core, which means
that in that case vb_lock shouldn't be used since the external lock is already
held.Prepare for this by adding a pointer to such an external mutex and
don't lock if that pointer is set.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
03 Aug, 2010
3 commits
-
The videobuf_dmabuf and videobuf_vmalloc_memory fields have a vmalloc
field to store the kernel virtual address of vmalloc'ed buffers. Rename
the field to vaddr.Signed-off-by: Laurent Pinchart
Signed-off-by: Mauro Carvalho Chehab -
The fields are assigned but never used, remove them.
Signed-off-by: Laurent Pinchart
Signed-off-by: Mauro Carvalho Chehab -
These functions allocate videobuf_buffer structures only. Renaming in order
to prevent confusion with functions allocating actual video buffer memory.Rename the functions in videobuf-core.h videobuf-dma-sg.c as well.
Signed-off-by: Pawel Osciak
Signed-off-by: Laurent Pinchart
Signed-off-by: Kyungmin Park
Signed-off-by: Mauro Carvalho Chehab
19 May, 2010
6 commits
-
videobuf-core checks if .sync ops is defined before calling.
So, we don't need a do-nothing function.
Signed-off-by: Mauro Carvalho Chehab
-
mmap_mapper should operate on a buffer, not on a complete queue. So let
the videobuf-core find the correct buffer instead of duplicating that
code in each mmap_mapper implementation.The dma-sg implementation has backwards compatibility code for handling
the V4L1_COMPAT layer. This code is now under the v4L1_COMPAT config option.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
The video_copy_to_user and copy_stream ops are almost identical for all
videobuf memtype variants. All that is needed is to use the new vaddr
op and these functions can be moved into the core, ensuring we have just
one single implementation instead of three.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Rename the .vmalloc op in struct videobuf_qtype_ops to .vaddr. This op returns
the virtual kernel address of a buffer. vaddr is a lot less confusing than
vmalloc since this callback does do any allocations.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
videobuf_alloc() returned a void *. Change to struct videobuf_buffer *
to get better type checking.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab -
Remove the mmap_free callback from struct videobuf_qtype_ops.
All implementations of this callback do the same trivial check: return
-EBUSY if any buffer is mmapped. That can also be tested in the
videobuf core.Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
18 May, 2010
1 commit
-
Make videobuf pass checkpatch; minor code cleanups.
Signed-off-by: Pawel Osciak
Reviewed-by: Kyungmin Park
Signed-off-by: Mauro Carvalho Chehab
27 Feb, 2010
1 commit
-
Signed-off-by: Pawel Osciak
Signed-off-by: Mauro Carvalho Chehab
06 Dec, 2009
2 commits
-
For whatever reason, the device structure pointer to
videobuf_queue_vmalloc_init is typed "void *", even though it's passed
right through to videobuf_queue_core_init(), which expects a struct
device pointer. The other videobuf implementations use struct device *;
I think vmalloc should too.Signed-off-by: Jonathan Corbet
Signed-off-by: Mauro Carvalho Chehab -
The videobuf_queue_ops function vector is not declared constant, but
there's no need for the videobuf layer to ever change it. Make it const
so that videobuf users can make their operations const without warnings.Signed-off-by: Jonathan Corbet
Signed-off-by: Andrew Morton
Signed-off-by: Mauro Carvalho Chehab
28 Sep, 2009
1 commit
-
* mark struct vm_area_struct::vm_ops as const
* mark vm_ops in AGP codeBut leave TTM code alone, something is fishy there with global vm_ops
being used.Signed-off-by: Alexey Dobriyan
Signed-off-by: Linus Torvalds
30 Mar, 2009
1 commit
-
videobuf_vmalloc_free() is never freeing the video buffer memory. Due to
that, after multiple open/closes, user can suffer a panic:Kernel BUG at mm/slab.c:2650
invalid opcode: 0000 [1] SMP
last sysfs file: /class/video4linux/video0/dev
CPU 4
Modules linked in: vivi(U) videodev(U) v4l1_compat(U) v4l2_compat_ioctl32(U) videobuf_vmalloc(U) videobuf_core(U) ipv6 xfrm_nalgo autofs4 vmnet(U) vmblock(U) vmci(U) vmmon(U) ip_conntrack_netbios_ns ipt_REJECT xt_state ip_conntrack nfnetlink xt_tcpudp iptable_filter ip_tables x_tables cpufreq_ondemand dm_mirror dm_log dm_multipath scsi_dh dm_mod video backlight sbs i2c_ec button battery asus_acpi acpi_memhotplug ac lp testmgr_cipher testmgr aead crypto_blkcipher crypto_algapi crypto_api arc4 snd_hda_intel nvidia(PFU) snd_seq_dummy snd_seq_oss snd_seq_midi_event rt73usb crc_itu_t snd_seq snd_seq_device snd_pcm_oss snd_mixer_oss tg3 sr_mod snd_pcm snd_timer snd_page_alloc snd_hwdep pcspkr rt2500usb cdrom rt2x00usb rt2x00lib libphy snd parport_pc soundcore shpchp serio_raw i2c_i801 i5400_edac parport ata_piix sg mac80211 edac_mc i2c_core cfg80211 ahci libata sd_mod scsi_mod ext3 jbd uhci_hcd ohci_hcd ehci_hcd
Pid: 6215, comm: v4l-stress-buff Tainted: PF 2.6.18-118.el5 #1
RIP: 0010:[] [] cache_grow+0x1e/0x395
RSP: 0018:ffff810128a35d28 EFLAGS: 00010006
RAX: 0000000000000000 RBX: 00000000000080d0 RCX: 00000000ffffffff
RDX: 0000000000000000 RSI: 00000000000080d0 RDI: ffff8101042d8340
RBP: ffff8101042ce5e0 R08: ffff81012fc1e8c0 R09: ffff8101042eac00
R10: 0000000000000000 R11: ffffffff882a5139 R12: ffff8101042d8340
R13: ffff8101042ce5c0 R14: 0000000000000000 R15: ffff8101042d8340
FS: 0000000000000000(0000) GS:ffff81012fc24d40(0063) knlGS:00000000f7f706c0
CS: 0010 DS: 002b ES: 002b CR0: 000000008005003b
CR2: 00000000f7f9a000 CR3: 0000000117ad0000 CR4: 00000000000006e0
Process v4l-stress-buff (pid: 6215, threadinfo ffff810128a34000, task ffff810128fcb820)
Stack: ffffc20012a39000 0000004415173ff8 ffff810000011c10 000280d200000000
0000000000000002 00000000ffffffff ffff8101042ce5e0 ffff81012fc1e8c0
ffff8101042ce5c0 000000000000000c ffff8101042d8340 ffffffff8005bdde
Call Trace:
[] cache_alloc_refill+0x136/0x186
[] kmem_cache_alloc_node+0x98/0xb2
[] __vmalloc_area_node+0x62/0x153
[] vmalloc_user+0x15/0x50
[] :videobuf_vmalloc:__videobuf_iolock+0xe6/0x155
[] :vivi:buffer_prepare+0xb9/0xe6
[] :videobuf_core:__videobuf_read_start+0xa2/0x10f
[] :videobuf_core:videobuf_read_stream+0x9c/0x1f3
[] vfs_read+0xcb/0x171
[] sys_read+0x45/0x6e
[] sysenter_do_call+0x1b/0x67Code: 0f 0b 68 af 1e 2a 80 c2 5a 0a f6 c7 20 0f 85 53 03 00 00 89
RIP [] cache_grow+0x1e/0x395
RSP
Kernel panic - not syncing: Fatal exceptionThanks to Douglas Schilling Landgraf for writing a
stress tool for testing and to Robert Krakora
to trace the code and discover the point where the bug were happening.
Thanks also to Magnus Damm that provided us a fix for
a similar bug on videobuf-dma-contig.Signed-off-by: Mauro Carvalho Chehab
27 Jul, 2008
1 commit
-
Signed-off-by: Hans Verkuil
Signed-off-by: Mauro Carvalho Chehab
20 Jul, 2008
1 commit
-
Use "scatter gather" instead of "scatter gatter".
Signed-off-by: Magnus Damm
Signed-off-by: Guennadi Liakhovetski
Signed-off-by: Mauro Carvalho Chehab
25 Apr, 2008
8 commits
-
videobuf-dvb were still using a function that were videobuf-dma-sg
dependent. This patch creates a generic handler for this function. This
way, videobuf-dvb can now work with all videobuf implementations.Signed-off-by: Mauro Carvalho Chehab
-
Before the patch, there were a risk of freeing and unmapping userspace memory,
while there were pending requests.Signed-off-by: Mauro Carvalho Chehab
-
There were a small bug on videobuf-vmalloc that were preventing STREAMOFF to
work. The issue is that vmalloc'ed mmaped memory should only be freed after
being sure that there aren't any mmap usage. Otherwise, the memory remap will
stop working, and the userspace won't receive any frames.This bug were affecting some userspace applications, like tvtime.
After this patch, tvtime started to work again with the drivers that use
videobuf-vmalloc.Signed-off-by: Mauro Carvalho Chehab
-
There were some bugs on videobuf-vmalloc.
Basically, remap were called with a wrong parameter. Due to that, a later remap
were needed, generating the need of some hacks on videobuf-vmalloc and
videobuf-core.This patch fixes the remap and removes the hacks.
TODO:
- V4L2_MEMORY_USERPTR is not implemented yet. This method should be
properly implemented, in order to work with a few userspace applications.- The driver also doesn't implement V4L2_MEMORY_OVERLAY. This method is used
only by a few applications, and are becaming obsolete, due to the increment
of cpu performance. So, most apps prefer to retrieve data to an internal
buffer, doing some processing like de-interlacing.Signed-off-by: Mauro Carvalho Chehab
-
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: Michael Krufky
Signed-off-by: Mauro Carvalho Chehab -
Remove the buf_release on vm_close because it will lead to a buffer being
released multiple times since all buffers are already freed under the two
possible cases: device close or STREAMOFF.Signed-off-by: Brandon Philips
Signed-off-by: Mauro Carvalho Chehab -
videobuf-dma-sg does not need to depend on PCI. Switch it to using generic
DMA API, convert all affected drivers, relax Kconfig restriction, improve
compile-time type checking, fix some Coding Style violations while at it.Signed-off-by: Guennadi Liakhovetski
Signed-off-by: Mauro Carvalho Chehab -
- Static memory is always initialized with 0.
- Replaced in some cases C99 comments for /* */Signed-off-by: Douglas Schilling Landgraf
Signed-off-by: Mauro Carvalho Chehab
18 Feb, 2008
2 commits
-
Signed-off-by: Brandon Philips
Signed-off-by: Mauro Carvalho Chehab -
This helps to identify where vb_lock is being used, and find missusages of the
locks.Signed-off-by: Mauro Carvalho Chehab
26 Jan, 2008
1 commit
-
Signed-off-by: Brandon Philips
Signed-off-by: Mauro Carvalho Chehab
12 Dec, 2007
1 commit
-
This is pretty serious bug. map->count is never initialized after the
call to kmalloc making the count start at some random trash value. The
end result is leaking videobufs.Also, fix up the debug statements to print unsigned values.
Pushed to http://ifup.org/hg/v4l-dvb too
Signed-off-by: Brandon Philips
Signed-off-by: Mauro Carvalho Chehab
14 Oct, 2007
1 commit
-
Breaks on any target that has copy_to_user() defined as a non-trivial
macro.Signed-off-by: Al Viro
Signed-off-by: Linus Torvalds
10 Oct, 2007
6 commits
-
In the past, videobuf_queue_init were used to initialize PCI DMA videobuffers.
This patch renames it, to avoid confusion with the previous kernel API, doing:
s/videobuf_queue_init/void videobuf_queue_core_init/Also, the operations is now part of the function parameter. The function will
also add a test if this is defined, otherwise producing BUG.Signed-off-by: Mauro Carvalho Chehab
-
Signed-off-by: Mauro Carvalho Chehab
http://thread.gmane.org/gmane.comp.video.video4linux/34978/focus=34981
Reviewed-by: Ricardo Cerqueira -
Release code should happen before the cleaning of map variable.
Signed-off-by: Mauro Carvalho Chehab
-
Signed-off-by: Mauro Carvalho Chehab
-
Signed-off-by: Mauro Carvalho Chehab
-
Adds a newer videobuf-vmalloc module. This module uses the same
videobuf controls, but implements memory allocation based on vmalloc
methods.With this method, an USB driver can use video-buf, without needing to
request memory from the DMA-safe area.Signed-off-by: Mauro Carvalho Chehab