02 Jan, 2012

1 commit


08 Aug, 2011

1 commit


28 Apr, 2011

1 commit


23 Mar, 2011

1 commit


24 Dec, 2010

1 commit

  • Workqueue creation API has been updated and flush_scheduled_work() is
    deprecated and scheduled to be removed.

    * core/core.c: Use alloc_ordered_workqueue() instead of
    create_singlethread_workqueue(). This removes an unnecessary
    rescuer.

    * host/omap.c: Create, use and flush mmc_omap_wq instead of the
    system_wq.

    * Flush host->mmc_carddetect_work directly on removal instead of using
    flush_scheduled_work().

    Signed-off-by: Tejun Heo
    Cc: Chris Ball
    Cc: linux-mmc@vger.kernel.org

    Tejun Heo
     

23 Oct, 2010

1 commit


05 Jun, 2010

1 commit

  • Remove a BUG_ON for when interrupts are disabled during an MMC request.

    During boot, interrupts can be disabled when a request is made, causing
    this bug to be triggered. In reality, there's no reason this should halt
    the kernel, as the driver has proved reliable in spite of disabled
    interrupts, and additionally, there's nothing in this code that would
    require interrupts to be enabled.

    The only setup I've managed to make it trigger on is on the HTC Herald
    during bootup when the driver is built into the kernel (mostly because
    that's all I have). I believe it's related to the fact that on bootup I
    get many timeout errors on "CMD5" while initializing the card. Each CMD5
    timeout triggers that bug (I changed it to a WARN_ON to get it to boot in)
    due to the fact that part of the timeout code involves sending the request
    again. With interrupts turned off, that BUG would be triggered.

    Signed-off-by: Cory Maccarrone
    Acked-by: Tony Lindgren
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Cory Maccarrone
     

28 May, 2010

2 commits

  • Even though many mmc host drivers pass a pm_message_t argument to
    mmc_suspend_host() that argument isn't used the by MMC core. As host
    drivers are converted to dev_pm_ops they'll have to construct
    pm_message_t's (as they won't be passed by the PM subsystem any more) just
    to appease the mmc suspend interface.

    We might as well just delete the unused paramter.

    Signed-off-by: Matt Fleming
    Acked-by: Anton Vorontsov
    Acked-by: Michal Miroslaw ZZ
    Acked-by: Sascha Sommer
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Matt Fleming
     
  • The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring
    a modification of the register addresses in the mmc-omap driver. To
    resolve this, a bit shift is performed on base register addresses, either
    by 1 or 2 bits depending on the CPU in use. This yields the correct
    registers for each CPU.

    Signed-off-by: Marek Belisko
    Signed-off-by: Cory Maccarrone
    Signed-off-by: Tony Lindgren
    Cc: Ladislav Michl
    Cc: Ben Dooks
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Marek BElisko
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

16 Dec, 2009

1 commit


23 Nov, 2009

1 commit


12 Nov, 2009

1 commit


21 Oct, 2009

1 commit

  • Move the remaining headers under plat-omap/include/mach
    to plat-omap/include/plat. Also search and replace the
    files using these headers to include using the right path.

    This was done with:

    #!/bin/bash
    mach_dir_old="arch/arm/plat-omap/include/mach"
    plat_dir_new="arch/arm/plat-omap/include/plat"
    headers=$(cd $mach_dir_old && ls *.h)
    omap_dirs="arch/arm/*omap*/ \
    drivers/video/omap \
    sound/soc/omap"
    other_files="drivers/leds/leds-ams-delta.c \
    drivers/mfd/menelaus.c \
    drivers/mfd/twl4030-core.c \
    drivers/mtd/nand/ams-delta.c"

    for header in $headers; do
    old="#include

    Tony Lindgren
     

14 Jun, 2009

1 commit

  • A pointer to mmc_omap_probe which lives in .init.text is passed to the
    core via platform_driver_register and so the kernel might oops if probe
    is called after the init code is discarded.

    As requested by David Brownell platform_driver_probe is used instead of
    moving the probe function to .devinit.text. This saves some memory, but
    might have the downside that a device being registered after the call to
    mmc_omap_init but before the init sections are discarded will not be
    bound anymore to the driver.

    Signed-off-by: Uwe Kleine-König
    Acked-by: David Brownell
    Signed-off-by: Pierre Ossman

    Uwe Kleine-König
     

04 Jun, 2009

1 commit

  • disable_irq() should wait for all running handlers to complete
    before returning. As such, if it's used to disable an interrupt
    from that interrupt's handler it will deadlock. This replaces
    the dangerous instances with the _nosync() variant which doesn't
    have this problem.

    Signed-off-by: Ben Nizette
    Acked-by: Tony Lindgren
    Signed-off-by: Pierre Ossman

    Ben Nizette
     

24 Apr, 2009

1 commit


09 Feb, 2009

2 commits


11 Dec, 2008

2 commits

  • Add low-level initialization for hsmmc controller. Merged into
    this patch patch are various improvments and board support by
    Grazvydas Ignotas and David Brownell.

    Also change wire4 to be wires, as some newer controllers support
    8 data lines.

    Cc: Pierre Ossman
    Signed-off-by: Grazvydas Ignotas
    Signed-off-by: David Brownell
    Signed-off-by: Tony Lindgren

    Tony Lindgren
     
  • This will simplify the MMC low-level init, and make it more
    flexible to add support for a newer MMC controller in the
    following patches.

    The patch rearranges platform data and gets rid of slot vs
    controller confusion in the old data structures. Also fix
    device id numbering in the clock code.

    Some code snippets are based on an earlier patch by
    Russell King .

    Cc: Pierre Ossman
    Signed-off-by: Tony Lindgren

    Tony Lindgren
     

06 Sep, 2008

2 commits


07 Aug, 2008

2 commits


15 Jul, 2008

1 commit

  • Relax requirements on host controllers and only require that they do not
    report a transfer count than is larger than the actual one (i.e. a lower
    value is okay). This is how many other parts of the kernel behaves so
    upper layers should already be prepared to handle that scenario. This
    gives us a performance boost on MMC cards.

    Signed-off-by: Pierre Ossman

    Pierre Ossman
     

15 May, 2008

1 commit

  • This patch fixes error:

    drivers/mmc/host/omap.c: In function 'mmc_omap_get_dma_channel':
    drivers/mmc/host/omap.c:1038: error: called object 'dev_name' is not a function

    Commit 06916639e2fed9ee475efef2747a1b7429f8fe76 adds a function
    called dev_name. This will cause a name conflict as dev_dbg calls
    dev_name(((host->mmc)->parent)).

    This same issue should not affect other drivers as they don't seem
    to use dev_name with dev_dbg.

    Thanks to Paul Walmsley for figuring this one out.

    Cc: Paul Walmsley
    Signed-off-by: Tony Lindgren
    Signed-off-by: Pierre Ossman

    Tony Lindgren
     

19 Apr, 2008

13 commits