Eric Lee / smarc-fsl-linux-kernel

10 Mar, 2011

1 commit

12 Feb, 2011

1 commit

  • 24a6f5b85   drivers/rtc/rtc-proc.c: add module_put on error path in rtc_proc_open() ... Browse Code »

    In file drivers/rtc/rtc-proc.c seq_open() can return -ENOMEM.

    86 if (!try_module_get(THIS_MODULE))
    87 return -ENODEV;
    88
    89 return single_open(file, rtc_proc_show, rtc);

    In this case before exiting (line 89) from rtc_proc_open the
    module_put(THIS_MODULE) must be called.

    Found by Linux Device Drivers Verification Project

    Signed-off-by: Alexander Strakh
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alexander Strakh
     

31 Mar, 2009

1 commit

  • 99b762338   proc 2/2: remove struct proc_dir_entry::owner ... Browse Code »

    Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
    as correctly noted at bug #12454. Someone can lookup entry with NULL
    ->owner, thus not pinning enything, and release it later resulting
    in module refcount underflow.

    We can keep ->owner and supply it at registration time like ->proc_fops
    and ->data.

    But this leaves ->owner as easy-manipulative field (just one C assignment)
    and somebody will forget to unpin previous/pin current module when
    switching ->owner. ->proc_fops is declared as "const" which should give
    some thoughts.

    ->read_proc/->write_proc were just fixed to not require ->owner for
    protection.

    rmmod'ed directories will be empty and return "." and ".." -- no harm.
    And directories with tricky enough readdir and lookup shouldn't be modular.
    We definitely don't want such modular code.

    Removing ->owner will also make PDE smaller.

    So, let's nuke it.

    Kudos to Jeff Layton for reminding about this, let's say, oversight.

    http://bugzilla.kernel.org/show_bug.cgi?id=12454

    Signed-off-by: Alexey Dobriyan

    Alexey Dobriyan
     

29 Apr, 2008

1 commit

  • c7705f344   drivers: use non-racy method for proc entries creation (2) ... Browse Code »

    Use proc_create()/proc_create_data() to make sure that ->proc_fops and ->data
    be setup before gluing PDE to main tree.

    Signed-off-by: Denis V. Lunev
    Cc: Greg Kroah-Hartman
    Cc: Alexey Dobriyan
    Cc: "Eric W. Biederman"
    Cc: Peter Osterlund
    Cc: Bartlomiej Zolnierkiewicz
    Cc: Dmitry Torokhov
    Cc: Neil Brown
    Cc: Mauro Carvalho Chehab
    Cc: Bjorn Helgaas
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Denis V. Lunev
     

09 May, 2007

3 commits

  • cd9662094   rtc: remove rest of class_device ... Browse Code »

    Finish converting the RTC framework so it no longer uses class_device.

    Signed-off-by: David Brownell
    Acked-by: Greg Kroah-Hartman
    Acked-By: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • 7d9f99ecc   rtc: simplified /proc/driver/rtc handling ... Browse Code »

    This simplifies the RTC procfs support by removing the class_interface that
    hooks it into the rtc core. If it's configured, then sysfs support is now
    part of the RTC core, and is never a separate module.

    It also removes the class_interface hook, now that its last remaining user is
    gone. (That API is usable only with a "struct class_device".)

    It's another step towards being able to remove "struct class_device".

    Signed-off-by: David Brownell
    Acked-by: Greg Kroah-Hartman
    Acked-By: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • ab6a2d70d   rtc: rtc interfaces don't use class_device ... Browse Code »

    This patch removes class_device from the programming interface that the RTC
    framework exposes to the rest of the kernel. Now an rtc_device is passed,
    which is more type-safe and streamlines all the relevant code.

    Signed-off-by: David Brownell
    Acked-by: Greg Kroah-Hartman
    Acked-By: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     

13 Feb, 2007

1 commit

  • d54b1fdb1   [PATCH] mark struct file_operations const 5 ... Browse Code »

    Many struct file_operations in the kernel can be "const". Marking them const
    moves these to the .rodata section, which avoids false sharing with potential
    dirty data. In addition it'll catch accidental writes at compile time to
    these shared resources.

    Signed-off-by: Arjan van de Ven
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arjan van de Ven
     

14 Dec, 2006

2 commits

  • a2db8dfce   [PATCH] rtc framewok: rtc_wkalrm.enabled reporting updates ... Browse Code »

    Fix a glitch in the procfs dumping of whether the alarm IRQ is enabled: use
    the traditional name (from drivers/char/rtc.c and many other places) of
    "alarm_IRQ", not "alrm_wakeup" (which didn't even match the efirtc code, which
    originated that reporting API).

    Also, update a few of the RTC drivers to stop providing that duplicate status,
    and/or to expose it properly when reporting the alarm state. We really don't
    want every RTC driver doing their own thing here...

    Signed-off-by: David Brownell
    Acked-by: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • 5a6534e4c   [PATCH] rtc: remove syslog spam on registration ... Browse Code »

    This removes some syslog spam as RTC drivers register; debug messages
    shouldn't come out at "info" level.

    Signed-off-by: David Brownell
    Acked-by: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     

01 Oct, 2006

3 commits

  • ff8371ac9   [PATCH] constify rtc_class_ops: update drivers ... Browse Code »

    Update RTC framework so that drivers can constify their method tables, moving
    them from ".data" to ".rodata". Then update the drivers.

    Signed-off-by: David Brownell
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • db621f174   [PATCH] RTC class: error checks ... Browse Code »

    The rtc_is_valid_tm() routine needs to treat some of the fields it checks as
    unsigned, to prevent wrongly accepting invalid rtc_time structs; this is the
    same approach used elsewhere in the RTC code for such tests.

    Conversely, rtc_proc_show() is missing one invalid-day-of-month test that
    rtc_is_valid_tm() makes: there is no day zero.

    Signed-off-by: David Brownell
    Cc: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     
  • 818a8674b   [PATCH] RTC class uses subsys_init ... Browse Code »

    This makes RTC core components use "subsys_init" instead of "module_init", as
    appropriate for subsystem infrastructure. This is mostly useful for
    statically linking drivers in other parts of the tree that may provide an RTC
    interface as a secondary functionality (e.g. part of a multifunction chip);
    they won't need to worry so much about drivers/Makefile link order.

    Signed-off-by: David Brownell
    Cc: Alessandro Zummo
    Acked-by: Oleg Verych
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    David Brownell
     

11 Apr, 2006

1 commit

  • adfb43412   [PATCH] RTC subsystem: fix proc output ... Browse Code »

    Move the "24hr: yes" proc output from drivers to rtc proc code. This is
    required because the time value in the proc output is always in 24hr mode
    regardless of the driver.

    Signed-off-by: Alessandro Zummo
    Cc: Lennert Buytenhek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alessandro Zummo
     

28 Mar, 2006

1 commit

  • 728a29478   [PATCH] RTC subsystem: proc interface ... Browse Code »

    Add the proc interface to the RTC subsystem.

    The first RTC driver which registers with the class will be accessible by
    /proc/driver/rtc .

    This is required for compatibility with the standard RTC driver and to avoid
    breaking any user space application which may erroneusly rely on this.

    Signed-off-by: Alessandro Zummo
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Alessandro Zummo