30 Oct, 2011
3 commits
-
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
When SRR LS_ACC is dropped, the driver was not issuing ABTS for SRR when it
times out. Since the target received SRR, it was able to send the XFER_RDY and
the the original IO request completed successfully. In this condition ABTS was
not sent during bnx2fc_srr_compl(). Fix this by first checking for ELS timeout
and issue ABTS before checking if original IO request is complete.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
If the IO and the corresponding ABTS are not responded by a target, cleanup the
IO and issue explicit logout when ulp timer expires while waiting for ABTS to
complete. Wait for the session to be ready before returning to the SCSI layer.
If the session is not ready let the SCSI-ml escalate the error recovery.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley
29 Oct, 2011
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (204 commits)
[SCSI] qla4xxx: export address/port of connection (fix udev disk names)
[SCSI] ipr: Fix BUG on adapter dump timeout
[SCSI] megaraid_sas: Fix instance access in megasas_reset_timer
[SCSI] hpsa: change confusing message to be more clear
[SCSI] iscsi class: fix vlan configuration
[SCSI] qla4xxx: fix data alignment and use nl helpers
[SCSI] iscsi class: fix link local mispelling
[SCSI] iscsi class: Replace iscsi_get_next_target_id with IDA
[SCSI] aacraid: use lower snprintf() limit
[SCSI] lpfc 8.3.27: Change driver version to 8.3.27
[SCSI] lpfc 8.3.27: T10 additions for SLI4
[SCSI] lpfc 8.3.27: Fix queue allocation failure recovery
[SCSI] lpfc 8.3.27: Change algorithm for getting physical port name
[SCSI] lpfc 8.3.27: Changed worst case mailbox timeout
[SCSI] lpfc 8.3.27: Miscellanous logic and interface fixes
[SCSI] megaraid_sas: Changelog and version update
[SCSI] megaraid_sas: Add driver workaround for PERC5/1068 kdump kernel panic
[SCSI] megaraid_sas: Add multiple MSI-X vector/multiple reply queue support
[SCSI] megaraid_sas: Add support for MegaRAID 9360/9380 12GB/s controllers
[SCSI] megaraid_sas: Clear FUSION_IN_RESET before enabling interrupts
...
16 Oct, 2011
3 commits
-
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Add support for get_lesb so that the valid statistics are returned by the
remote peer when RLS command is issued.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Link may not be up when the driver receives ulp_start event, and hence
fcoe_ctlr_link_up is not called. Call fcoe_ctlr_link_up during
indicate_netevent only when the interface is enabled. (It has to be called when
enabled because that is an indication that the vlan discovery is completed).Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley
22 Sep, 2011
3 commits
-
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Gracefully handle bnx2fc_map_sg failure, so that queuecommand returns host busy
and SCSI-ml can retry the IO.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
scsi_dma_map doesn't work for NPIV since vport dev isn't fully initialized.
For more details: http://marc.info/?l=linux-scsi&m=118312448030633&w=2 and
commit - c59fd9ebc46da8d48b76955d4d48e3597f8c8726.Signed-off-by: Nithin Sujir
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley
18 Sep, 2011
2 commits
-
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Firmware asserts when the same CQE is armed twice. This scenario happens during
RSCN stress tests as driver incorrects arms the CQ after the session is
offloaded.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley
17 Sep, 2011
6 commits
-
Driver incorrectly calls bnx2fc_interface_cleanup() when bnx2fc_if_create fails
which accesses bad pointer. Handle bnx2fc_if_create failure by directly calling
bnx2fc_net_cleanup.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
It is not required to hold rtnl_lock and bnx2fc_dev_lock when calling
bnx2fc_if_destroy, as the locking is only required to serialize creation and
deletion of fcoe instances. More importantly, this unnecessary locking causes
deadlock as bnx2fc_if_destroy calls fc_remove_host holding rtnl_lock.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
When bnx2fc receives an UNREGISTER event on a vlan interface it calls
destroy on all interfaces that matches the physical interface. Add
vlan_id check to destroy only the vlan interface that generated the
event.Signed-off-by: Nithin Nayak Sujir
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
ABTS was not issued for timed out REC, as REC completion handler exits out if
the IO completed. Check for timed out REC and issue ABTS before proceeding with
further processing in REC completion handler. Also, initialize rec_retry and
srr_retry before starting the IO.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Link up event is generated to the driver even before vlan discovery has
started. Because of this driver can send discovery solicitation on a stale
vlan. Call fcoe_ctlr_link_up() only when the driver is in enabled state, which
implies the vlan discovery is complete before sending solicitation.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
If the max receive frame size is changed during link down, the driver uses the
same value after linkup unless it is reset to default.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley
16 Sep, 2011
1 commit
-
This patch does several things:
- introduces __ethtool_get_settings which is called from ethtool code and
from drivers as well. Put ASSERT_RTNL there.
- dev_ethtool_get_settings() is replaced by __ethtool_get_settings()
- changes calling in drivers so rtnl locking is respected. In
iboe_get_rate was previously ->get_settings() called unlocked. This
fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same
problem. Also fixed by calling __dev_get_by_index() instead of
dev_get_by_index() and holding rtnl_lock for both calls.
- introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create()
so bnx2fc_if_create() and fcoe_if_create() are called locked as they
are from other places.
- use __ethtool_get_settings() in bonding codeSigned-off-by: Jiri Pirko
v2->v3:
-removed dev_ethtool_get_settings()
-added ASSERT_RTNL into __ethtool_get_settings()
-prb_calc_retire_blk_tmo - use __dev_get_by_index() and lock
around it and __ethtool_get_settings() call
v1->v2:
add missing export_symbol
Reviewed-by: Ben Hutchings [except FCoE bits]
Acked-by: Ralf Baechle
Signed-off-by: David S. Miller
29 Aug, 2011
2 commits
-
Since it is already called in the right context with rtnl_lock and dev_mutex
held.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Increase it to NVRAM configured limit or 1024 whichever is less.
Signed-off-by: Michael Chan
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: David S. Miller
27 Aug, 2011
18 commits
-
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
This patch adds a validation step before allowing creation of a new NPIV port.
It checks whether the WWPN passed for the new NPIV port to be created is unique
for the given physical port.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
bnx2x driver would obtain the WWNN/WWPN from the shared memory and can be
obtained by the bnx2fc driver via ndo_fcoe_get_wwn.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
As an initiator, driver need not handle incoming ABTS. It initiates an ABTS if
any IO requests time out.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
- Free session resources before rport logoff
- Do not free session resources in bnx2fc_alloc_session_resc() as it is handled
in caller's error handling path.
- Do not call bnx2fc_free_session_resc() if bnx2fc_init_tgt() fails as cq_lock
is not yet initialized.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
There exists a race condition between CQ doorbell unmap and IO completion path
that arms the CQ which causes a NULL dereference. Protect the ctx_base with
cq_lock to avoid this. Also, wait for the CQ doorbell to be successfully mapped
before arming the CQ.Also, do not count uncolicited CQ completions for free_sqes.
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
During the unsolicited LOGO processing, the session is uploaded and offloaded
after the relogin is complete. In between any new IOs are errored back as the
upload completion flag is set. Upon exhausting the retry count, the application
fails the IOs. Return target busy for all the cases when session is not ready.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
CFC_DELETE is issued 2 secs after CONN_TERM is completed. If the session is
uploaded and offloaded immediately, it has to wait for the connection id to be
available.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Since this flag was never cleared, the driver does not wait for firmware
destroy completions, causing missed KCQEs.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Since the driver holds the reference for vlan netdev, the reference has to be
released by the driver when the vlan device is removed. Driver handles this in
NETDEV_UNREGISTER event.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Move interface specific cleanup functionality to from bnx2fc_if_destroy to
bnx2fc_interface_cleanup. Do not access interface/hba in bnx2fc_if_destroy as
by the time this function is called interface may already be destroyed. This
patch is in preparation to handle NETDEV_UNREGISTER on a vlan device.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Change them to bnx2fc_interface_setup/bnx2fc_interface_cleanup in preperation
for the patches to follow. Interface specific cleanup functionality will be
moved to bnx2fc_interface_cleanup.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
When NPIV ports are created/deleted rapidly there is a race condition between
bnx2fc_vport_destroy() from sysfs and bnx2fc_flogi_resp(), which could try to
delete the NPIV port from the list twice. Fix is to loop through the list of
NPIV ports to find a match, and only when it exists remove it.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
During sequence cleanup, an additional reference for an IO has been
taken. Because of this, the IO is never released into the free list.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Look up p->work_list to process cq completions, and correct the error check for
thread creation.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Reset max receive frame size every time before attempting FLOGI. Without this,
the stale MFS value will be used.Signed-off-by: Bhanu Prakash Gollapudi
Signed-off-by: James Bottomley -
Signed-off-by: Ian Campbell
Reviewed-by: Konrad Rzeszutek Wilk
Cc: Bhanu Prakash Gollapudi
Cc: "James E.J. Bottomley"
Cc: linux-scsi@vger.kernel.org
Cc: netdev@vger.kernel.org
Signed-off-by: David S. Miller
12 Aug, 2011
1 commit
-
Reported-by: Stephen Rothwell
Signed-off-by: David S. Miller
