06 Dec, 2011
1 commit
-
Signed-off-by: Paul Bolle
Signed-off-by: Jiri Kosina
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
19 Jan, 2010
1 commit
-
converted using this script..
perl -p -i -e 's|ulong32|u32|g' drivers/scsi/gdth*
perl -p -i -e 's|ulong64|u64|g' drivers/scsi/gdth*
perl -p -i -e 's|ushort|u16|g' drivers/scsi/gdth*
perl -p -i -e 's|unchar|u8|g' drivers/scsi/gdth*
perl -p -i -e 's|ulong|unsigned long|g' drivers/scsi/gdth*
perl -p -i -e 's|PACKED|__attribute__((packed))|g' drivers/scsi/gdth*sha1sum of the generated code was identical before and after.
Signed-off-by: Dave Jones
Signed-off-by: James Bottomley
09 Oct, 2008
1 commit
-
Right now SCSI and others do their own command timeout handling.
Move those bits to the block layer.Instead of having a timer per command, we try to be a bit more clever
and simply have one per-queue. This avoids the overhead of having to
tear down and setup a timer for each command, so it will result in a lot
less timer fiddling.Signed-off-by: Mike Anderson
Signed-off-by: Jens Axboe
08 Apr, 2008
1 commit
-
- Reduce uses of gdth_pci_str::pdev, preferring a local variable
(or function arg) 'pdev' instead.- Reduce uses of gdth_pcistr array, preferring local variable
(or function arg) 'pcistr' instead.- Eliminate lone use of gdth_pci_str::irq, using equivalent
pdev->irq instead- Eliminate assign-only gdth_pci_str::io_mm
Note: If the indentation seems weird, that's because a line was
converted from spaces to tabs, when it was modified.Signed-off-by: Jeff Garzik
Signed-off-by: James Bottomley
28 Feb, 2008
1 commit
-
The recent patch named:
[SCSI] gdth: !use_sg cleanup and use of scsi accessorshas done a bad job in handling internal commands issued by gdth_execute().
Internal commands are issued with device gdth_cmd_str ready made directly
to the card, without any mapping or translations of scsi commands. So here
I added a gdth_cmd_str pointer to the gdth_cmndinfo private structure which
is then copied directly to host.following this patch is a cleanup that removes the home cooked accessors
and reverts them to regular scsi_cmnd accessors. Since they are not used
anymore. After review maybe the 2 patches should be squashed together.FIXME: There is still a problem with gdth_get_info(). as reported there
is a WARN_ON trigerd in dma_free_coherent() when doing:
$ cat /proc/sys/gdth/0Signed-off-by: Boaz Harrosh
Tested-by: Joerg Dorchain:
Tested-by: Stefan Priebe
Tested-by: Jon Chelton
Cc: Stable Tree
Signed-off-by: James Bottomley
13 Oct, 2007
6 commits
-
gdth_execute() will issue an internal, none scsi-standard commands
onto __gdth_queuecommand(). Since it is not recommended to set
struct scsi_cmnd IO members in llds, gdth now uses internal IO
members for IO. In the case of gdth_execute() these members will be
set properly. In case the command was issued from scsi-ml
(by gdth_queuecommand) they will be set from scsi IO accessors.* define gdth IO accessors and use them throughout the driver.
* use an sg-of-one in gdth_execute() and fix gdth_special_cmd()
accordingly.
* Clean the not use_sg code path and companySigned-off-by Boaz Harrosh
Signed-off-by: James Bottomley -
- Cleanup the rest of the scsi_cmnd->SCp members and move them
to gdth_cmndinfo:
SCp.this_residual => priority
SCp.buffers_residual => timeout
SCp.Status => status and dma_dir
SCp.Message => info
SCp.have_data_in => volatile wait_for_completion
SCp.sent_command => OpCode
SCp.phase => phase- Two more members will be naturally removed in the !use_sg cleanup
TODO: What is the meaning of gdth_cmndinfo.phase? (rhetorically)
Signed-off-by Boaz Harrosh
Signed-off-by: James Bottomley -
- scsi_cmnd and specifically ->SCp of, where heavily abused
with internal meaning members and flags. So introduce a new
struct gdth_cmndinfo, put it on ->host_scribble and define a
gdth_cmnd_priv() accessor to retrieve it from a scsi_cmnd.- The structure now holds two members:
internal_command - replaces the IS_GDTH_INTERNAL_CMD() croft.
sense_paddr - which was a 64-bit spanning on 2 32-bit members of SCp.
More overloaded members from SCp and scsi_cmnd will be moved in a later
patch (For easy review).- Split up gdth_queuecommand to an additional internal_function. The later
is the one called by gdth_execute(). This will be more evident later in
the scsi accessors patch, but it also facilitates in the differentiation
between internal_command and external. And the setup of gdth_cmndinfo of
each command.Signed-off-by Boaz Harrosh
Signed-off-by: James Bottomley -
- Use scsi_add_host and friends and track instances ourselves. And
generally modernize the driver's structure.- TODO: Next we can remove the controller table
- TODO: Fix use of deprecated pci_find_device()Signed-off-by: Christoph Hellwig
Signed-off-by: Boaz Harrosh
Signed-off-by: James Bottomley -
- Based on same patch from Christoph Hellwig
- Get rid of all the indirection in the Scsi_Host private data and always
put the gdth_ha_str directly into it.- Change all internal functions prototype to recieve an "gdth_ha_str *ha"
pointer directlly and kill all that redundent access to the "gdth_ctr_tab[]"
controller-table.Signed-off-by: Boaz Harrosh
Signed-off-by: Christoph Hellwig
Signed-off-by: James Bottomley -
* Remove in-source changelog. It's archived permanently in git and
various kernel archives, and changelogs should exist purely in git.* Remove 2.4.x kernel support. It is an active obstacle to
modernizing this driver, at this point. This includes killing
gdth_kcompat.h which is 100% redundant in modern kernels.Signed-off-by: Jeff Garzik
Signed-off-by: Boaz Harrosh
Signed-off-by: James Bottomley
31 Jul, 2007
1 commit
-
This patch
* removes struct members that duplicate pci_dev members
* replaces ha->stype usage with ha->pdev->device usage where feasibleSigned-off-by: Jeff Garzik
Acked-by: Christoph Hellwig
Acked-by: Achim Leubner
Signed-off-by: James Bottomley
27 Sep, 2006
1 commit
-
Signed-off-by: Michal Piotrowski
Signed-off-by: Andrew Morton
Signed-off-by: James Bottomley
10 Jun, 2006
1 commit
-
Initial pass at converting the gdth driver away from the scsi_request
interface so that the request interface can be removed post 2.6.18
without breaking gdth. Based on changes from Christoph HellwigSigned-off-by: Andrew Morton
Signed-off-by: James Bottomley
10 Nov, 2005
1 commit
-
Signed-off-by: James Bottomley
19 Apr, 2005
1 commit
-
This patch contains the following cleanups:
- make some needlessly global functions static
- remove one more kernel 2.2 #ifdefSigned-off-by: Adrian Bunk
Signed-off-by: James Bottomley
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
