31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
03 Sep, 2010
1 commit
-
GCC warns about empty printf format strings, and after
the addition of %pV these existing such cases in the
scsi driver layer were exposed enough for the compiler
to start seeing them.Based almost entirely upon a patch by Joe Perches.
[jejb: fix up sym53c8xx msg]
Signed-off-by: David S. Miller
Signed-off-by: James Bottomley
04 Dec, 2009
1 commit
-
That is "success", "unknown", "through", "performance", "[re|un]mapping"
, "access", "default", "reasonable", "[con]currently", "temperature"
, "channel", "[un]used", "application", "example","hierarchy", "therefore"
, "[over|under]flow", "contiguous", "threshold", "enough" and others.Signed-off-by: André Goddard Rosa
Signed-off-by: Jiri Kosina
22 Jun, 2009
1 commit
-
This makes a huge difference when you have a serial console on bootup to limit
these messages to a sane number.Signed-off-by: John Stoffel
Signed-off-by: James Bottomley
21 May, 2009
2 commits
-
Make the sym53c8xx_2 driver slave_alloc/destroy less unsafe. References
to the destroyed LCB are cleared from the target structure (instead of
leaving a dangling pointer), and when the last LCB for the target is
destroyed the reference to the upper layer target data is cleared. The
host lock is used to prevent a race with the interrupt handler. Also
user commands are prevented for targets with all LCBs destroyed.Signed-off-by: Aaro Koskinen
Tested-by: Tony Battersby
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley -
(Resent with proper formatting)
Fix for the sym53c8xx_2 driver to initialize lun's to_clear flag after
a bus reset (a failed clear can trigger a bus reset and it should not
be attemped again after that).Signed-off-by: Aaro Koskinen
Tested-by: Tony Battersby
Signed-off-by: Mike Christie
Signed-off-by: James Bottomley
03 Apr, 2009
1 commit
-
Signed-off-by: Harvey Harrison
Acked-by: Jeff Garzik
Acked-by: Hannes Reinecke
Signed-off-by: Andrew Morton
Signed-off-by: James Bottomley
13 Mar, 2009
2 commits
-
sym53c8xx prints a negotiation message after every check condition.
This can add up to a lot of messages for removable-medium devices
(CD-ROM, tape drives, etc.) that are being polled, since they return
check condition when no medium is present. This patch suppresses the
negotiation message if it would be the same as the last one printed.Signed-off-by: Tony Battersby
Signed-off-by: James Bottomley -
(The patch updated based on testing and comments from Tony Battersby.)
Change the sym53c8xx_2 driver negotiation logic so that the driver will
tolerate better device removals. Negotiation message(s) will be sent
with every INQUIRY and REQUEST SENSE command, and whenever there is a
change in goals or when the device reports check condition.The patch was made specifically to address the case where you hotswap
the disk using remove-single-device/add-single-device commands through
/proc/scsi/scsi. Without the patch the driver keeps using old transfer
parameters even though the target is reset and reports check condition,
so the data transfer of the very first INQUIRY will fail.Signed-off-by: Aaro Koskinen
Tested-by: Tony Battersby
Signed-off-by: James Bottomley
27 Jul, 2008
1 commit
-
This patch frees the luntbl dma area in sym_hcb_free if allocated.
Since the luntbl is part of a larger dma coherent area not freeing the
luntbl kept a 64k dma coherent area previous allocated through
dma_alloc_coherent allocated. This prevented a DLPAR remove IO
operation from completing successfully.Signed-off-by: Mike Anderson
Cc: Matthew Wilcox
Signed-off-by: James Bottomley
29 Apr, 2008
1 commit
-
drivers/scsi/aic7xxx/aic7770_osm.c:53:58: warning: Using plain integer as NULL pointer
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c:355:47: warning: Using plain integer as NULL pointer
drivers/scsi/aic7xxx/aic7xxx_osm_pci.c:372:55: warning: Using plain integer as NULL pointer
drivers/scsi/aha152x.c:997:28: warning: Using plain integer as NULL pointer
drivers/scsi/aha152x.c:1003:28: warning: Using plain integer as NULL pointer
drivers/scsi/aha152x.c:1165:46: warning: Using plain integer as NULL pointer
drivers/scsi/fdomain.c:1446:40: warning: Using plain integer as NULL pointer
drivers/scsi/sym53c8xx_2/sym_hipd.c:1650:51: warning: Using plain integer as NULL pointer
drivers/scsi/sym53c8xx_2/sym_hipd.c:3171:42: warning: Using plain integer as NULL pointer
drivers/scsi/sym53c8xx_2/sym_hipd.c:5732:52: warning: Using plain integer as NULL pointer
drivers/scsi/ncr53c8xx.c:8189:31: warning: Using plain integer as NULL pointer
drivers/scsi/ncr53c8xx.c:8225:34: warning: Using plain integer as NULL pointer
drivers/scsi/dpt_i2o.c:156:32: warning: Using plain integer as NULL pointer
drivers/scsi/ultrastor.c:954:42: warning: Using plain integer as NULL pointer
drivers/scsi/ultrastor.c:1104:18: warning: Using plain integer as NULL pointerSigned-off-by: Harvey Harrison
Signed-off-by: Linus Torvalds
08 Feb, 2008
1 commit
-
This patch fixes the calculation of the data transfer residual for the
case of a command that is supposed to transfer an odd number of bytes on
a wide bus but transfers nothing instead.Signed-off-by: Tony Battersby
Cc: Matthew Wilcox
Signed-off-by: James Bottomley
19 Dec, 2007
1 commit
-
The patch described by the following excerpt from ChangeLog-2.6.24-rc1
eventually causes a "irq X: nobody cared" error after a while:commit 99c9e0a1d6cfe1ba1169a7a81435ee85bc00e4a1
Author: Matthew Wilcox
Date: Fri Oct 5 15:55:12 2007 -0400[SCSI] sym53c8xx: Make interrupt handler capable of returning IRQ_NONE
After this happens, the kernel disables the IRQ, causing the SCSI card
to stop working until the next reboot. The problem is caused by the
interrupt handler returning IRQ_NONE instead of IRQ_HANDLED after
handling an interrupt-on-the-fly (INTF) condition. The following patch
fixes the problem.Signed-off-by: Tony Battersby
Acked-by: Matthew Wilcox
Signed-off-by: James Bottomley
24 Oct, 2007
9 commits
-
This function just printed a message to the user; move the print to its
only caller, and turn it into an starget_printk.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
This structure is accessed by the device; the fewer Linux things in it,
the better. Using the pci_dev pointer from the hostdata requires a lot
of changes:- Pass Scsi_Host to a lot of routines which currently take a sym_hcb.
- Set the Scsi_Host as the pci drvdata (instead of the sym_hcb)Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Make sym_interrupt return an irqreturn_t instead of void, and take a
Scsi_Host instead of a sym_hcb. Pass the Scsi_Host to the interrupt
handler instead of the sym_hcb. Rename the host_data to sym_data.
Keep a pci_dev pointer in the sym_data. Rename the Scsi_Host from
instance to shost.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
If we have a scsi_cmnd, it gives the user more information than the
sym_name, and maybe the target.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
By introducing the use_dac(), set_dac() and DMA_DAC_MASK macros, we can
eliminate a lot of ifdefs from the code. We now rely on the compiler to
optimise away a few things that we'd formerly relied on the preprocessor
to do. This makes sym_setup_bus_dma_mask() small enough to inline into
its only caller.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
These struct elements record info that is never needed
Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Following the same path as ->revision_id, remove ->device_id
Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Auke missed the sym2 driver in his initial sweep.
Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
This patch adds the PCI error recovery callbacks to the Symbios SCSI device
driver. It includes support for First Failure Data Capture.Signed-off-by: Linas Vepstas
Assorted changes to initial patches, including returning IRQ_NONE from the
interrupt handler if the device is offline and re-using the eh_done completion
in the scsi error handler.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley
14 Dec, 2006
1 commit
-
All kcalloc() calls of the form "kcalloc(1,...)" are converted to the
equivalent kzalloc() calls, and a few kcalloc() calls with the incorrect
ordering of the first two arguments are fixed.Signed-off-by: Robert P. J. Day
Cc: Jeff Garzik
Cc: Alan Cox
Cc: Dominik Brodowski
Cc: Adam Belay
Cc: James Bottomley
Cc: Greg KH
Cc: Mark Fasheh
Cc: Trond Myklebust
Cc: Neil Brown
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
10 Jun, 2006
1 commit
-
Use ARRAY_SIZE macro instead of sizeof(x)/sizeof(x[0]) and remove
duplicates of the macro.Signed-off-by: Tobias Klauser
Signed-off-by: Andrew Morton
Signed-off-by: James Bottomley
13 Apr, 2006
5 commits
-
The PDC code can set the bus mode, but we were ignoring that setting.
Also move the code that determines bus mode into its own function.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Now sym2 is using spi_print_msg, we don't need to have our own messages
for IGNORE WIDE RESIDUE and MODIFY DATA POINTER, so provide the option
of passing NULL for the label.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Undef SYM_OPT_HANDLE_DEVICE_QUEUEING.
Call sym_put_start_queue instead of sym_start_next_ccbs.
Turn asserts into checks that we can send the command to the adapter,
and return busy from queuecommand if we can't.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Patch below is one out of a large series to mark kernel data const when
possible, goal is to use .rodata and avoid false sharingSigned-off-by: Arjan van de Ven
Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Most of the Kconfig options for switching between IO Port and MMIO
operations use the opposite sense from sym2. Really, this option
should be set at a chipset level rather than per-driver.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley
15 Mar, 2006
1 commit
28 Feb, 2006
2 commits
-
sym2 boards without NVRAM currently negotiate narrow due to this missed
initialisationSigned-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Introduce new helpers:
- spi_populate_width_msg()
- spi_populate_sync_msg()
- spi_populate_ppr_msg()and use them in drivers which already enable the SPI transport.
Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley
13 Feb, 2006
1 commit
-
pm->sg.size is set from the Residual Byte Count register. However,
the upper byte of the RBC is the opcode of the instruction that was
executing, so we need to mask it off. This fixes some spurious rejects
of IGNORE WIDE RESIDUE messages.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley
16 Dec, 2005
2 commits
-
Rename scsi_print_msg to spi_print_msg and move its prototype from
scsi_dbg.h to scsi_transport_spi.hSigned-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
This merge is pretty extensive. The conflict is over the new
req->retries parameter, so I had to change the prototype to
scsi_setup_blk_pc_cmnd() and the usage in sd, sr and st.Signed-off-by: James Bottomley
14 Dec, 2005
5 commits
-
Rather than print a list of targets at driver init time, print each
disabled target as we attempt to scan it.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
The NVRAM for both Tekram and Symbios boards allows the user to set the
speed and width for individual targets. I took that code out in March
2004 when we introduced Domain Validation, but it seems there's still
a legitimate need for it in some configurations.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
sym_show_msg was almost a duplicate of scsi_print_msg, except not as
featureful. So use the common code instead.Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
The upper layer doesn't send these down since 2.4.x (or 2.6 in
practice), so no need to handle it. Inline sym_setup_data_pointers
into its only caller so we can fail gracefully in the case we'd get
one neverless.Signed-off-by: Christoph Hellwig
Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley -
Allocate the lcb in slave_alloc and free it in slave_destroy. This allows
us to remove all the code that checks to see if it's already been allocated.From: Christoph Hellwig
Signed-off-by: Matthew Wilcox
Signed-off-by: James Bottomley