12 Oct, 2009
1 commit
-
An interestingly corrupted romfs file system exposed a problem with the
romfs_dev_strnlen function: it's passing the wrong value to its helpers.
Rather than limit the string to the length passed in by the callers, it
uses the size of the device as the limit.Signed-off-by: Bernd Schmidt
Signed-off-by: Mike Frysinger
Signed-off-by: David Howells
Signed-off-by: Linus Torvalds
25 Apr, 2009
2 commits
-
RomFS should advance the destination buffer pointer when reading data from a
blockdev source (the data may be split over multiple blocks, each requiring its
own sb_read() call). Without this, all the data is copied to the beginning of
the output buffer.Signed-off-by: David Howells
Tested-by: Michal Simek
Signed-off-by: Linus Torvalds -
romfs_lookup() should be using a routine akin to strcmp() on the backing store,
rather than one akin to strncmp(). If it uses the latter, it's liable to match
/bin/shutdown when looking up /bin/sh.Signed-off-by: David Howells
Tested-by: Michal Simek
Signed-off-by: Linus Torvalds
24 Mar, 2009
1 commit
-
Change RomFS so that it can use MTD devices directly - without the intercession
of the block layer - as well as using block devices.This permits RomFS:
(1) to use the MTD direct mapping facility available under NOMMU conditions if
the underlying device is directly accessible by the CPU (including XIP);(2) and thus to be used when the block layer is disabled.
RomFS can be configured with support just for MTD devices, just for Block
devices or for both. If RomFS is configured for both, then it will treat
mtdblock device files as MTD backing stores, not block layer backing stores.I tested this using a CONFIG_MMU=n CONFIG_BLOCK=n kernel running on my FRV
board with a RomFS image installed on the mtdram test device. I see my test
program being run XIP:# cat /proc/maps
...
c0c000b0-c0c01f8c r-xs 00000000 1f:00 144 /mnt/doshm
...GDB on the kernel can be used to show that these addresses are within the
set-aside RAM space.Signed-off-by: David Howells
Tested-by: Bernd Schmidt
Signed-off-by: David Woodhouse