07 Dec, 2011
1 commit
-
in an multi-line if statement leading edges should line up to the opening
parenthesisReported-by: David Miller
Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
20 Nov, 2011
3 commits
-
Before accessing the TT_RESPONSE packet payload, the node has to ensure that the
packet is long enough as it would expect to be.Reported-by: Simon Wunderlich
Signed-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann -
The TT_RESPONSE skb has to be linearised only if the node plans to access the
packet payload (so only if the message is directed to that node). In all the
other cases the node can avoid this memory operationSigned-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann -
There are two reasons for this fix:
- the result of choose_orig() and vis_choose() is an index and therefore it can't
be negative. Hence it is correct to make the return type unsigned too.- sizeof(int) may not be the same on ALL the architectures. Since we plan to use
choose_orig() as DHT hash function, we need to guarantee that, given the same
argument, the result is the same. Then it is correct to explicitly express
the size of the return type (and the second argument). Since the expected
length is currently 4, uint32_t is the most convenient choice.Signed-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann
08 Sep, 2011
2 commits
-
In preparation of the upcoming improved routing algorithm the code based has
to be re-organized to allow choosing the routing algorithm at compile time.Signed-off-by: Marek Lindner
-
The follow-up routing code changes are going to introduce additional
routing packet types which make this distinction necessary.Signed-off-by: Marek Lindner
22 Aug, 2011
4 commits
-
Signed-off-by: Marek Lindner
-
If a node has to send a packet issued by a WIFI client to another WIFI client,
the packet is dropped.Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner -
Clients connected through a 802.11 device are now marked with the
TT_CLIENT_WIFI flag. This flag is also advertised with the tt
announcement.Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner -
Several typos have been corrected and some sentences have been rephrased
Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
08 Jul, 2011
1 commit
-
In case of tt_crc mismatching for a certain orig_node after applying the
changes, the node must request the full table immediately.Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
05 Jul, 2011
1 commit
-
In order to make possible to use the broadcast list for delayed sendings
the "delay" parameter is now provided instead of using 1 as hardcoded
value.Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
20 Jun, 2011
5 commits
-
The local and the global translation-tables are now lock free and rcu
protected.Signed-off-by: Antonio Quartulli
Acked-by: Simon Wunderlich
Signed-off-by: Sven Eckelmann -
With the current client announcement implementation, in case of roaming,
an update is triggered on the new AP serving the client. At that point
the new information is spread around by means of the OGM broadcasting
mechanism. Until this operations is not executed, no node is able to
correctly route traffic towards the client. This obviously causes packet
drops and introduces a delay in the time needed by the client to recover
its connections.A new packet type called ROAMING_ADVERTISEMENT is added to account this
issue.This message is sent in case of roaming from the new AP serving the
client to the old one and will contain the client MAC address. In this
way an out-of-OGM update is immediately committed, so that the old node
can update its global translation table. Traffic reaching this node will
then be redirected to the correct destination utilising the fresher
information. Thus reducing the packet drops and the connection recovery
delay.Signed-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann -
The client announcement mechanism informs every mesh node in the network
of any connected non-mesh client, in order to find the path towards that
client from any given point in the mesh.The old implementation was based on the simple idea of appending a data
buffer to each OGM containing all the client MAC addresses the node is
serving. All other nodes can populate their global translation tables
(table which links client MAC addresses to node addresses) using this
MAC address buffer and linking it to the node's address contained in the
OGM. A node that wants to contact a client has to lookup the node the
client is connected to and its address in the global translation table.It is easy to understand that this implementation suffers from several
issues:
- big overhead (each and every OGM contains the entire list of
connected clients)
- high latencies for client route updates due to long OGM trip time and
OGM lossesThe new implementation addresses these issues by appending client
changes (new client joined or a client left) to the OGM instead of
filling it with all the client addresses each time. In this way nodes
can modify their global tables by means of "updates", thus reducing the
overhead within the OGMs.To keep the entire network in sync each node maintains a translation
table version number (ttvn) and a translation table checksum. These
values are spread with the OGM to allow all the network participants to
determine whether or not they need to update their translation table
information.When a translation table lookup is performed in order to send a packet
to a client attached to another node, the destination's ttvn is added to
the payload packet. Forwarding nodes can compare the packet's ttvn with
their destination's ttvn (this node could have a fresher information
than the source) and re-route the packet if necessary. This greatly
reduces the packet loss of clients roaming from one AP to the next.Signed-off-by: Antonio Quartulli
Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann -
char was used in different places to store information without really
using the characteristics of that data type or by ignoring the fact that
char has not a well defined signedness.Signed-off-by: Sven Eckelmann
-
count_real_packets() in batman-adv assumes char is signed, and returns -1
through it:net/batman-adv/routing.c: In function 'receive_bat_packet':
net/batman-adv/routing.c:739: warning: comparison is always false due to limited range of data typeUse int instead.
Signed-off-by: David Howells
[sven@narfation.org: Rebase on top of current version]
Signed-off-by: Sven Eckelmann
10 Jun, 2011
1 commit
-
When a link is saturated (re)broadcasts of OGMs are delayed. Under heavy
load this delay may exceed the orig interval which leads to OGMs being
dropped (the code would only accept an OGM rebroadcast if it arrived
before the next OGM was broadcasted). With this patch batman-adv will
also accept delayed OGMs in order to avoid a bogus influence on the
routing metric.Signed-off-by: Daniele Furlan
Signed-off-by: Sven Eckelmann
30 May, 2011
5 commits
-
The debug output of update_route has tests for "route deleted" and "route
added". All other situations are handled as "route changed". This is not
true because neigh_node and curr_router could be both NULL.The function is not called in this situation, but the code might be
interpreted wrong when reading it without this test.Signed-off-by: Sven Eckelmann
-
Instead of comparing mac addresses with the broadcast address by means
of compare_eth(), the is_broadcast_ether_addr() kernel function has to be
used.Signed-off-by: Antonio Quartulli
Acked-by: Sven Eckelmann
Signed-off-by: Sven Eckelmann -
Documentation/CodingStyle recommends to use the form
p = kmalloc(sizeof(*p), ...);
to calculate the size of a struct and not the version where the struct
name is spelled out to prevent bugs when the type of p changes. This
also seems appropriate for manipulation of buffers when they are
directly associated with p.Signed-off-by: Sven Eckelmann
-
batman-adv uses pointers which are marked as const and should not
violate that type qualifier by passing it to functions which force a
cast to the non-const version.Signed-off-by: Sven Eckelmann
-
Every time that find_router() is invoked, if_status has to be compared with
IF_ACTIVE. Moving this comparison inside find_router() will avoid to write it
each time.Signed-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann
08 May, 2011
3 commits
-
In function is_bidirectional_neigh the code that find out the one hop
neighbor is duplicated.Signed-off-by: Daniele Furlan
Signed-off-by: Sven Eckelmann -
To be coherent, all the functions/variables/constants have been renamed
to the TranslationTable styleSigned-off-by: Antonio Quartulli
Signed-off-by: Sven Eckelmann -
Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann
02 May, 2011
2 commits
-
The rcu protected macros rcu_dereference() and rcu_assign_pointer()
for the bat_priv->primary_if need to be used, as well as spin/rcu locking.Otherwise we might end up using a primary_if pointer pointing to already
freed memory.Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann -
orig_hash_find() manages rcu_lock/unlock internally and doesn't need to
be surrounded by rcu_read_lock() / rcu_read_unlock() anymoreSigned-off-by: Antonio Quartulli
Acked-by: Marek Lindner
Signed-off-by: Sven Eckelmann
18 Apr, 2011
3 commits
-
Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann -
The rcu protected macros rcu_dereference() and rcu_assign_pointer()
for the orig_node->router need to be used, as well as spin/rcu locking.
Otherwise we might end up using a router pointer pointing to already
freed memory.Therefore this commit introduces the safe getter method
orig_node_get_router().Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann -
This decreases the size of find_router() by outsourcing the router
search for the bonding and interface alternating modes to their own sub
functions. This shall make it easier to keep track of the correct
refcounting later.Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner
Signed-off-by: Sven Eckelmann
05 Mar, 2011
9 commits
-
Signed-off-by: Linus Lüssing
Signed-off-by: Marek Lindner -
Signed-off-by: Marek Lindner
-
Batman-adv works with "hard interfaces" as well as "soft interfaces".
The new name should better make clear which kind of interfaces this
list stores.Signed-off-by: Marek Lindner
-
Signed-off-by: Marek Lindner
-
Signed-off-by: Marek Lindner
-
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.Reported-by: Sven Eckelmann
Signed-off-by: Marek Lindner -
Signed-off-by: Marek Lindner
-
Note: The function compare_ether_addr() provided by the Linux kernel
requires aligned memory.Signed-off-by: Marek Lindner
-
Batman-adv could receive several payload broadcasts at the same time
that would trigger access to the broadcast seqno sliding window to
determine whether this is a new broadcast or not. If these incoming
broadcasts are accessing the sliding window simultaneously it could
be left in an inconsistent state. Therefore it is necessary to make
sure this access is atomic.Reported-by: Linus Lüssing
Signed-off-by: Marek Lindner
