05 Jan, 2012
1 commit
24 Dec, 2011
1 commit
-
This reverts commit e1b6eb3ccb0c2a34302a9fd87dd15d7b86337f23.
This was causing a delay of 10 seconds in the resume process of a Thinkpad
laptop. I'm afraid this could affect more devices once 3.2 is released.Reported-by: Tomáš Janoušek
Signed-off-by: Gustavo F. Padovan
23 Dec, 2011
3 commits
-
We run everything in process context now.
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
They don't need to disable interrupts anymore, we only run in process
context now.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
The struct hci_proto and all related register/unregister and dispatching
code was removed. HCI core code now call directly the SCO and L2CAP
event functions.Signed-off-by: Ulisses Furquim
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
21 Dec, 2011
3 commits
-
The hci_task_lock mutex (previously a lock) was supposed to protect the
register/unregister of HCI protocols against RX/TX tasks. This will not
be needed anymore because SCO and L2CAP will always be compiled.Moreover, with the recent move of RX/TX to workqueues per device the
global hci_task_lock was causing starvation between different HCI
devices.Signed-off-by: Ulisses Furquim
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Signed-off-by: Andrei Emeltchenko
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Current controller initialization is moved tp bredr_init and new
function added amp_init to handle later AMP init sequence. Current
AMP init sequence include Reset and Read Local Version.Signed-off-by: Andrei Emeltchenko
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
19 Dec, 2011
14 commits
-
Incoming sk_buffs always have bt_cb(skb)->force_active set to 0, so
it's misleading to use that value from the control block when calling
hci_conn_enter_active_mode() for incoming data. The destination socket
is not known in the HCI layer, so the force_active setting for each
socket isn't known either. Hard-coding the force_active parameter does
not change any behavior, but makes it obvious that incoming ACL data
never exits sniff mode.Signed-off-by: Mat Martineau
Signed-off-by: Gustavo F. Padovan -
We do not want the service cache to be enabled indefinitely after
mgmt_read_info is called. To solve this a timer is added which will
automatically disable the cache if mgmt_set_dev_class isn't called
within 5 seconds of calling mgmt_read_info.Signed-off-by: Johan Hedberg
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Add ProFUSION's copyright to some files I've been touching recently.
Signed-off-by: Gustavo F. Padovan
-
hdev->workqueue should be only for rx/tx, so move this one out.
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Update hdev workqueue API usage to use the new interface, this new
interface also allow us to mark this workqueue as WQ_HIGHPRI, so now rx
and tx work gets higher priority when running.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
hdev->workqueue will be only for for rx/tx/cmd processing, all other small
works should go to the system workqueue for now.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
This should simplify Bluetooth core processing a lot.
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
As part of the moving on all the Bluetooth processing to Process context.
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Handling hci_conn_hash with RCU make us avoid some locking and disable
tasklets.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Instead of using tasklet_disable() to prevent acess to the channel use, we
can use RCU and improve the performance of our code.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Now we can sleep in any path inside Bluetooth core, so mutex can make
sense here.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
As HCI rx path is now done in process context it makes sense to do all the
timer in process context as well.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Now we run everything in HCI in process context, so it's a better idea use
mutex instead spin_lock. The macro remains hci_dev_lock() (and I got rid
of hci_dev_lock_bh()), of course.Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Run recv process in workqueue helps a lot with our processing as the recv
path will also be in the process context, i.e., now all our tx and rx are
in process context.Signed-off-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
17 Dec, 2011
1 commit
-
Only the list member of the struct was used, so we now fold it into
hci_conn.Signed-off-by: Gustavo F. Padovan
02 Dec, 2011
2 commits
-
Remove old code not touched for several years.
Signed-off-by: Andrei Emeltchenko
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
This patch adds the dev_flags field to struct hci_dev. This new
flags variable should be used to define flags related to BR/EDR
and/or LE controller itself. It should be used to define flags
which represents states from the controller. The dev_flags is
cleared in case the controller sends a Reset Command Complete
Event to the host.Also, this patch adds the HCI_LE_SCAN flag which was created to
track if the controller is performing LE scan or not. The flag
is set/cleared when the controller starts/stops scanning.This is an initial effort to stop using hdev->flags to define
internal flags since it is exported to userspace by an ioctl.Signed-off-by: Andre Guedes
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
22 Nov, 2011
2 commits
-
Use queue instead of stack discipline for device list. When processing
dev_list with list_for_each* devices will be prosessed in order they
were added (Usually BR/EDR first and AMP later).Also output from hciconfig looks nicer :-)
Signed-off-by: Andrei Emeltchenko
Signed-off-by: Gustavo F. Padovan -
Fixes bluetooth compiling when CONFIG_BT_L2CAP is not enabled
net/built-in.o: In function `hci_dev_open':
(.text+0xdce9a): undefined reference to `enable_hs'Reported-by: Randy Dunlap
Signed-off-by: Andrei Emeltchenko
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
17 Nov, 2011
2 commits
-
Signed-off-by: Szymon Janc
Signed-off-by: Gustavo F. Padovan -
Signed-off-by: Andrei Emeltchenko
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
09 Nov, 2011
4 commits
-
The cancel_delayed_work_sync function should not be used if we hold any
locks. Luckily all places where this is the case it is also safe to use
the non-sync version.Signed-off-by: Johan Hedberg
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
Now that the pending commands are within struct hci_dev we can properly
control access to them throught the hci_dev locking mechanism.Signed-off-by: Johan Hedberg
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
This patch moves the pending management command list (previously global
to mgmt.c) into struct hci_dev. This makes it possible to do proper
locking when accessing it (through the existing hci_dev locks) and
thereby avoid race conditions.Signed-off-by: Johan Hedberg
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan -
The current global pending command list in mgmt.c is racy. Possibly the
simplest way to fix it is to have per-hci dev lists instead of a global
one (all commands that need a pending struct are hci_dev specific).
This way the list can be protected using the already existing per-hci
dev lock. To enable this refactoring the first thing that needs to be
done is to ensure that the mgmt functions have access to the hci_dev
struct (instead of just the dev id).Signed-off-by: Johan Hedberg
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
08 Nov, 2011
7 commits
-
BR/EDR link keys have their own commands and events (separate from SMP)
and the remove_keys command (previously remove_key) removes keys of any
kind for the specified remote address.Signed-off-by: Johan Hedberg
Signed-off-by: Gustavo F. Padovan -
The power off code doesn't need to use its own custom timer since the
delayed_work API provides the exact same functionality.Signed-off-by: Johan Hedberg
Signed-off-by: Gustavo F. Padovan -
Based on the revised mgmt API set_discoverable has a timeout parameter
to specify how long the adapter will remain discoverable. A value of 0
means "indefinitively".Signed-off-by: Johan Hedberg
Signed-off-by: Gustavo F. Padovan -
This patch adds a function to hci_core to cancel an ongoing inquiry.
According to the Bluetooth spec, the inquiry cancel command should
only be issued after the inquiry command has been issued, a command
status event has been received for the inquiry command, and before
the inquiry complete event occurs.As HCI_INQUIRY flag is only set just after an inquiry command status
event occurs and it is cleared just after an inquiry complete event
occurs, the inquiry cancel command should be issued only if HCI_INQUIRY
flag is set.Additionally, cancel inquiry related code from stop_discovery() were
replaced by a hci_cancel_inquiry() call.Signed-off-by: Andre Guedes
Signed-off-by: Gustavo F. Padovan -
This patch adds a function to hci_core to carry out inquiry.
All inquiry code from start_discovery() were replaced by a
hci_do_inquiry() call.Signed-off-by: Andre Guedes
Signed-off-by: Gustavo F. Padovan -
It's convenient to use the HCI device index the AMP controller id, but
the spec requires that an AMP controller never has id 0.Signed-off-by: Mat Martineau
Acked-by: Marcel Holtmann
Acked-by: Andrei Emeltchenko
Signed-off-by: Gustavo F. Padovan -
To avoid starvation the priority is recalculated so that the starving
channels are promoted to HCI_PRIO_MAX - 1 (6).HCI_PRIO_MAX (7) is considered special, because it requires CAP_NET_ADMIN
capability which can be used to provide more guaranties, so it is not used
when promoting.Signed-off-by: Luiz Augusto von Dentz
Acked-by: Marcel Holtmann
Signed-off-by: Gustavo F. Padovan
