04 Apr, 2011

1 commit

• b4232a227   netfilter: h323: bug in parsing of ASN1 SEQOF field ... Browse Code »

  Static analyzer of clang found a dead store which appears to be a bug in
  reading count of items in SEQOF field, only the lower byte of word is
  stored. This may lead to corrupted read and communication shutdown.

  The bug has been in the module since it's first inclusion into linux
  kernel.

  [Patrick: the bug is real, but without practical consequence since the
  largest amount of sequence-of members we parse is 30.]

  Signed-off-by: David Sterba
  Signed-off-by: Patrick McHardy

  David Sterba

  2011-04-04 21:21:02 +0800  

01 Feb, 2008

3 commits

• 905e3e8ec   [NETFILTER]: nf_conntrack_h323: constify and annotate H.323 helper ... Browse Code »

  Constify data tables (predominantly in nf_conntrack_h323_types.c, but
  also a few in nf_conntrack_h323_asn1.c) and use const qualifiers on
  variables where possible in the h323 sources.

  Signed-off-by: Jan Engelhardt
  Signed-off-by: Patrick McHardy
  Signed-off-by: David S. Miller

  Jan Engelhardt

  2008-02-01 11:28:07 +0800  
• 1f807d6eb   [NETFILTER]: nf_conntrack_h323: clean up code a bit ... Browse Code »

  -total: 81 errors, 3 warnings, 876 lines checked
  +total: 44 errors, 3 warnings, 876 lines checked

  There is still work to be done, but that's for another patch.

  Signed-off-by: Jan Engelhardt
  Signed-off-by: Patrick McHardy
  Signed-off-by: David S. Miller

  Jan Engelhardt

  2008-02-01 11:28:01 +0800  
• dc64d02ba   [NETFILTER]: nf_conntrack_h3223: sparse fixes ... Browse Code »

  Sparse complains when a function is not really static. Putting static
  on the function prototype is not enough.

  Signed-off-by: Stephen Hemminger
  Signed-off-by: Patrick McHardy
  Signed-off-by: David S. Miller

  Stephen Hemminger

  2008-02-01 11:27:47 +0800  

29 Jan, 2008

1 commit

• e79ec50b9   [NETFILTER]: Parenthesize macro parameters ... Browse Code »

  Parenthesize macro parameters.

  Signed-off-by: Jan Engelhardt
  Signed-off-by: Patrick McHardy
  Signed-off-by: David S. Miller

  Jan Engelhardt

  2008-01-29 06:59:08 +0800  

11 Jul, 2007

1 commit

• 558585aad   [NETFILTER]: nf_conntrack_h323: check range first in sequence extension ... Browse Code »

  Check range before checking STOP flag. This optimization may save a
  nanosecond or less :)

  Signed-off-by: Jing Min Zhao
  Signed-off-by: Patrick McHardy
  Signed-off-by: David S. Miller

  Jing Min Zhao

  2007-07-11 13:16:54 +0800  

06 Jul, 2007

1 commit

• 25845b515   [NETFILTER]: nf_conntrack_h323: add checking of out-of-range on choices' index values ... Browse Code »

  Choices' index values may be out of range while still encoded in the fixed
  length bit-field. This bug may cause access to undefined types (NULL
  pointers) and thus crashes (Reported by Zhongling Wen).

  This patch also adds checking of decode flag when decoding SEQUENCEs.

  Signed-off-by: Jing Min Zhao
  Signed-off-by: Patrick McHardy
  Signed-off-by: David S. Miller

  Jing Min Zhao

  2007-07-06 08:40:23 +0800  

03 Dec, 2006

1 commit

• f587de0e2   [NETFILTER]: nf_conntrack/nf_nat: add H.323 helper port ... Browse Code »

  Add IPv4 and IPv6 capable nf_conntrack port of the H.323 conntrack/NAT helper.

  Signed-off-by: Patrick McHardy
  Signed-off-by: David S. Miller

  Patrick McHardy

  2006-12-03 14:08:46 +0800