01 Nov, 2011

1 commit


18 May, 2010

1 commit

  • This patch removes from net/ (but not any netfilter files)
    all the unnecessary return; statements that precede the
    last closing brace of void functions.

    It does not remove the returns that are immediately
    preceded by a label as gcc doesn't like that.

    Done via:
    $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
    xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'

    Signed-off-by: Joe Perches
    Signed-off-by: David S. Miller

    Joe Perches
     

18 Jan, 2010

1 commit


16 Mar, 2009

1 commit


28 Jul, 2008

1 commit

  • Piss-poor sysctl registration API strikes again, film at 11...

    What we really need is _pathname_ required to be present in already
    registered table, so that kernel could warn about bad order. That's the
    next target for sysctl stuff (and generally saner and more explicit
    order of initialization of ipv[46] internals wouldn't hurt either).

    For the time being, here are full fixups required by ..._rotable()
    stuff; we make per-net sysctl sets descendents of "ro" one and make sure
    that sufficient skeleton is there before we start registering per-net
    sysctls.

    Signed-off-by: Al Viro
    Signed-off-by: Linus Torvalds

    Al Viro
     

27 Jul, 2008

1 commit

  • New object: set of sysctls [currently - root and per-net-ns].
    Contains: pointer to parent set, list of tables and "should I see this set?"
    method (->is_seen(set)).
    Current lists of tables are subsumed by that; net-ns contains such a beast.
    ->lookup() for ctl_table_root returns pointer to ctl_table_set instead of
    that to ->list of that ctl_table_set.

    [folded compile fixes by rdd for configs without sysctl]

    Signed-off-by: Al Viro

    Al Viro
     

26 Jul, 2008

1 commit

  • Extend the permission check for networking sysctl's to allow modification
    when current process has CAP_NET_ADMIN capability and is not root. This
    version uses the until now unused permissions hook to override the mode
    value for /proc/sys/net if accessed by a user with capabilities.

    Found while working with Quagga. It is impossible to turn forwarding
    on/off through the command interface because Quagga uses secure coding
    practice of dropping privledges during initialization and only raising via
    capabilities when necessary. Since the dameon has reset real/effective
    uid after initialization, all attempts to access /proc/sys/net variables
    will fail.

    Signed-off-by: Stephen Hemminger
    Acked-by: "Eric W. Biederman"
    Cc: Chris Wright
    Cc: Alexey Dobriyan
    Cc: Andrew Morgan
    Cc: Pavel Emelyanov
    Cc: "David S. Miller"
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Stephen Hemminger
     

12 Jun, 2008

1 commit


20 May, 2008

1 commit


01 May, 2008

1 commit

  • drivers/net/8390.c:37:2: warning: returning void-valued expression
    drivers/net/bnx2.c:1635:3: warning: returning void-valued expression
    drivers/net/xen-netfront.c:1806:2: warning: returning void-valued expression
    net/ipv4/tcp_hybla.c:105:3: warning: returning void-valued expression
    net/ipv4/tcp_vegas.c:171:3: warning: returning void-valued expression
    net/ipv4/tcp_veno.c:123:3: warning: returning void-valued expression
    net/sysctl_net.c:85:2: warning: returning void-valued expression

    Signed-off-by: Harvey Harrison
    Acked-by: Alan Cox
    Signed-off-by: David S. Miller

    Harvey Harrison
     

29 Jan, 2008

5 commits

  • I have removed all the entries from this table (core_table,
    ipv4_table and tr_table), so now we can safely drop it.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • The same thing for token-ring - use ctl paths and get
    rid of external references on the tr_table.

    Unfortunately, I couldn't split this patch into cleanup and
    use-the-paths parts.

    As a lame excuse I can say, that the cleanup is just moving
    the tr_table from one file to another - closet to a single
    variable, that this ctl table tunes. Since the source file
    becomes empty after the move, I remove it.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • This is the same as I did for the net/core/ table in the
    second patch in his series: use the paths and isolate the
    whole table in the .c file.

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • Using ctl paths we can put all the stuff, related to net/core/
    sysctl table, into one file and remove all the references on it.

    As a good side effect this hides the "core_table" name from
    the global scope :)

    Signed-off-by: Pavel Emelyanov
    Signed-off-by: David S. Miller

    Pavel Emelyanov
     
  • The user interface is: register_net_sysctl_table and
    unregister_net_sysctl_table. Very much like the current
    interface except there is a network namespace parameter.

    With this any sysctl registered with register_net_sysctl_table
    will only show up to tasks in the same network namespace.

    All other sysctls continue to be globally visible.

    Signed-off-by: Eric W. Biederman
    Cc: Serge Hallyn
    Cc: Daniel Lezcano
    Cc: Cedric Le Goater
    Cc: Pavel Emelyanov
    Signed-off-by: Herbert Xu
    Signed-off-by: David S. Miller

    Eric W. Biederman
     

01 Jul, 2006

1 commit


06 Jun, 2006

1 commit


04 Oct, 2005

1 commit

  • During the build for ARM machine type "fortunet", this error occurred:

    CC net/sysctl_net.o
    net/sysctl_net.c:36: error: 'core_table' undeclared here (not in a function)

    It appears that the following configuration settings cause this error
    due to a missing include:
    CONFIG_SYSCTL=y
    CONFIG_NET=y
    # CONFIG_INET is not set

    core_table appears to be declared in net/sock.h. if CONFIG_INET were
    defined, net/sock.h would have been included via:
    sysctl_net.c -> net/ip.h -> linux/ip.h -> net/sock.h

    so include it directly.

    Signed-off-by: Russell King
    Signed-off-by: David S. Miller

    Russell King
     

30 Aug, 2005

1 commit

  • Of this type, mostly:

    CHECK net/ipv6/netfilter.c
    net/ipv6/netfilter.c:96:12: warning: symbol 'ipv6_netfilter_init' was not declared. Should it be static?
    net/ipv6/netfilter.c:101:6: warning: symbol 'ipv6_netfilter_fini' was not declared. Should it be static?

    Signed-off-by: Arnaldo Carvalho de Melo
    Signed-off-by: David S. Miller

    Arnaldo Carvalho de Melo
     

17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds