Eric Lee / smarc-fsl-linux-kernel

23 Nov, 2015

1 commit

  • 90eec103b   treewide: Remove old email address ... Browse Code »

    There were still a number of references to my old Red Hat email
    address in the kernel source. Remove these while keeping the
    Red Hat copyright notices intact.

    Signed-off-by: Peter Zijlstra (Intel)
    Cc: Arnaldo Carvalho de Melo
    Cc: Jiri Olsa
    Cc: Linus Torvalds
    Cc: Mike Galbraith
    Cc: Peter Zijlstra
    Cc: Stephane Eranian
    Cc: Thomas Gleixner
    Cc: Vince Weaver
    Signed-off-by: Ingo Molnar

    Peter Zijlstra
     

05 Jun, 2014

1 commit

  • c75b53af2   lib/btree.c: fix leak of whole btree nodes ... Browse Code »

    I use btree from 3.14-rc2 in my own module. When the btree module is
    removed, a warning arises:

    kmem_cache_destroy btree_node: Slab cache still has objects
    CPU: 13 PID: 9150 Comm: rmmod Tainted: GF O 3.14.0-rc2 #1
    Hardware name: Inspur NF5270M3/NF5270M3, BIOS CHEETAH_2.1.3 09/10/2013
    Call Trace:
    dump_stack+0x49/0x5d
    kmem_cache_destroy+0xcf/0xe0
    btree_module_exit+0x10/0x12 [btree]
    SyS_delete_module+0x198/0x1f0
    system_call_fastpath+0x16/0x1b

    The cause is that it doesn't release the last btree node, when height = 1
    and fill = 1.

    [akpm@linux-foundation.org: remove unneeded test of NULL]
    Signed-off-by: Minfei Huang
    Cc: Joern Engel
    Cc: Johannes Berg
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Minfei Huang
     

08 Jun, 2012

2 commits

  • 39caa0916   btree: catch NULL value before it does harm ... Browse Code »

    Storing NULL values in the btree is illegal and can lead to memory
    corruption and possible other fun as well. Catch it on insert, instead
    of waiting for the inevitable.

    Signed-off-by: Joern Engel
    Signed-off-by: Roland Dreier
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joern Engel
     
  • cbf8ae32f   btree: fix tree corruption in btree_get_prev() ... Browse Code »
    1

    The memory the parameter __key points to is used as an iterator in
    btree_get_prev(), so if we save off a bkey() pointer in retry_key and
    then assign that to __key, we'll end up corrupting the btree internals
    when we do eg

    longcpy(__key, bkey(geo, node, i), geo->keylen);

    to return the key value. What we should do instead is use longcpy() to
    copy the key value that retry_key points to __key.

    This can cause a btree to get corrupted by seemingly read-only
    operations such as btree_for_each_safe.

    [akpm@linux-foundation.org: avoid the double longcpy()]
    Signed-off-by: Roland Dreier
    Acked-by: Joern Engel
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Roland Dreier
     

11 Jan, 2012

1 commit

  • 96b62067f   btree: export btree_get_prev() so modules can use btree_for_each ... Browse Code »

    The btree_for_each API is implemented with macros that internally call
    btree_get_prev(), so if btree_get_prev() isn't exported then modules fail
    to link if they try to use one of the btree_for_each macros. Since the
    rest of the btree API is exported, we should keep things orthogonal and
    make this work too.

    Signed-off-by: Roland Dreier
    Signed-off-by: Steve Hodgson
    Acked-by: Joern Engel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Steve Hodgson
     

31 Mar, 2011

1 commit

16 May, 2010

1 commit

21 Nov, 2009

1 commit