20 May, 2014

1 commit

• bd0c30e31   macintosh/windfarm_pm121.c: Fix for possible null pointer dereference ... Browse Code »

  There is otherwise a risk of a possible null pointer dereference.

  Was largely found by using a static code analysis program called cppcheck.

  Signed-off-by: Rickard Strandqvist
  Signed-off-by: Benjamin Herrenschmidt

  Rickard Strandqvist

  2014-05-20 08:56:00 +0800  

01 Jul, 2013

1 commit

• 4bb297113   powerpc/windfarm: Fix overtemperature clearing ... Browse Code »

  With pm81/pm91/pm121, when the overtemperature state is entered, and
  when it remains on after skipped ticks, the driver will try to leave
  it too soon (immediately on the next tick). This is because the active
  FAILURE_OVERTEMP state is not visible in "new_failure" variable of the
  current tick. Furthermore, the driver will keep trying to clear condition
  in subsequent ticks as FAILURE_OVERTEMP remains set in the "last_failure"
  variable. These will start to trigger WARNINGS from windfarm core:

  [ 100.082735] windfarm: Clamping CPU frequency to minimum !
  [ 100.108132] windfarm: Overtemp condition detected !
  [ 101.952908] windfarm: Overtemp condition cleared !
  [...]
  [ 102.980388] WARNING: at drivers/macintosh/windfarm_core.c:463
  [...]
  [ 103.982227] WARNING: at drivers/macintosh/windfarm_core.c:463
  [...]
  [ 105.030494] WARNING: at drivers/macintosh/windfarm_core.c:463
  [...]
  [ 105.973666] WARNING: at drivers/macintosh/windfarm_core.c:463
  [...]
  [ 106.977913] WARNING: at drivers/macintosh/windfarm_core.c:463

  Fix by adding a helper global variable. We leave the overtemp state only
  after all failure bits have been cleared.

  I saw this error on iMac G5 iSight (pm121). Also pm81/pm91 are fixed
  based on the observation that these are almost identical/copy-pasted code.

  Signed-off-by: Aaro Koskinen
  Signed-off-by: Benjamin Herrenschmidt

  Aaro Koskinen

  2013-07-01 09:10:34 +0800  

04 Jan, 2013

1 commit

• 1da42fb6b   Drivers: macintosh: remove __dev* attributes. ... Browse Code »

  CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
  markings need to be removed.

  This change removes the use of __devinit, __devexit_p, __devinitconst,
  and __devexit from these drivers.

  Based on patches originally written by Bill Pemberton, but redone by me
  in order to handle some of the coding style issues better, by hand.

  Cc: Bill Pemberton
  Cc: Benjamin Herrenschmidt
  Signed-off-by: Greg Kroah-Hartman

  Greg Kroah-Hartman

  2013-01-04 07:57:14 +0800  

29 Mar, 2012

1 commit

• 9ffc93f20   Remove all #inclusions of asm/system.h ... Browse Code »

  86

  Remove all #inclusions of asm/system.h preparatory to splitting and killing
  it. Performed with the following command:

  perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`

  Signed-off-by: David Howells

  David Howells

  2012-03-29 01:30:03 +0800  

27 Oct, 2010

1 commit

• 732eacc05   replace nested max/min macros with {max,min}3 macro ... Browse Code »

  Use the new {max,min}3 macros to save some cycles and bytes on the stack.
  This patch substitutes trivial nested macros with their counterpart.

  Signed-off-by: Hagen Paul Pfeifer
  Cc: Joe Perches
  Cc: Ingo Molnar
  Cc: Hartley Sweeten
  Cc: Russell King
  Cc: Benjamin Herrenschmidt
  Cc: Thomas Gleixner
  Cc: Herbert Xu
  Cc: Roland Dreier
  Cc: Sean Hefty
  Cc: Pekka Enberg
  Signed-off-by: Andrew Morton
  Signed-off-by: Linus Torvalds

  Hagen Paul Pfeifer

  2010-10-27 07:52:12 +0800  

09 Feb, 2010

1 commit

• 71a157e8e   of: add 'of_' prefix to machine_is_compatible() ... Browse Code »

  machine is compatible is an OF-specific call. It should have
  the of_ prefix to protect the global namespace.

  Signed-off-by: Grant Likely
  Acked-by: Michal Simek

  Grant Likely

  2010-02-09 23:33:00 +0800  

29 Apr, 2008

1 commit

• 80ff974db   [POWERPC] windfarm: Add PowerMac 12,1 support ... Browse Code »

  This implements a new driver named windfarm_pm121, which drives the
  fans on PowerMac 12,1 machines : iMac G5 iSight (rev C) 17" and
  20". It's based on the windfarm_pm81 driver from Benjamin
  Herrenschmidt.

  This includes fixes from David Woodhouse correcting the names of some
  of the sensors.

  Signed-off-by: Étienne Bersac
  Signed-off-by: David Woodhouse
  Signed-off-by: Benjamin Herrenschmidt
  Signed-off-by: Paul Mackerras

  Étienne Bersac

  2008-04-29 13:57:35 +0800