11 Dec, 2014
1 commit
-
Making things const is a good thing.
(x86-64 defconfig with all irda)
$ size net/irda/built-in.o*
text data bss dec hex filename
109276 1868 244 111388 1b31c net/irda/built-in.o.new
108828 2316 244 111388 1b31c net/irda/built-in.o.oldSigned-off-by: Joe Perches
Signed-off-by: David S. Miller
13 Nov, 2014
1 commit
-
Use the normal kernel debugging mechanism which also
enables dynamic_debug at the same time.Other miscellanea:
o Remove sysctl for irda_debug
o Remove function tracing like uses (use ftrace instead)
o Coalesce formats
o Realign arguments
o Remove unnecessary OOM messagesSigned-off-by: Joe Perches
Signed-off-by: David S. Miller
12 Nov, 2014
2 commits
-
And use the more common mechanisms directly.
Other miscellanea:
o Coalesce formats
o Add missing newlines
o Realign arguments
o Remove unnecessary OOM message logging as
there's a generic stack dump already on OOM.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller -
These are the same as net__ratelimited, so
use the more common style in the macro definition.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
07 Dec, 2013
1 commit
-
Several files refer to an old address for the Free Software Foundation
in the file header comment. Resolve by replacing the address with
the URL so that we do not have to keep
updating the header comments anytime the address changes.Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller
18 Oct, 2013
1 commit
-
This patch removes a comment mentioning IRQF_DISABLED,
which is deprecated.Signed-off-by: Michael Opdenacker
Signed-off-by: David S. Miller
24 Sep, 2013
1 commit
-
There are a mix of function prototypes with and without extern
in the kernel sources. Standardize on not using extern for
function prototypes.Function prototypes don't need to be written with extern.
extern is assumed by the compiler. Its use is as unnecessary as
using auto to declare automatic/local variables in a block.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
03 Aug, 2013
1 commit
-
It's convenient to have ethernet mac addresses use
ETH_ALEN to be able to grep for them a bit easier and
also to ensure that the addresses are __aligned(2).Add #include as necessary.
Signed-off-by: Joe Perches
Acked-by: Mauro Carvalho Chehab
Signed-off-by: David S. Miller
20 Apr, 2013
1 commit
-
The "reason" can come from skb->data[] and it hasn't been capped so it
can be from 0-255 instead of just 0-6. For example in irlmp_state_dtr()
the code does:reason = skb->data[3];
...
irlmp_disconnect_indication(self, reason, skb);Also LMREASON has a couple other values which don't have entries in the
irlmp_reasons[] array. And 0xff is a valid reason as well which means
"unknown".So far as I can see we don't actually care about "reason" except for in
the debug code.Signed-off-by: Dan Carpenter
Signed-off-by: David S. Miller
03 Jan, 2013
1 commit
-
Signed-off-by: Jorrit Schippers
Signed-off-by: Jiri Kosina
19 Nov, 2012
1 commit
-
Some comments misspell "registered"; this fixes them. No code changes.
Signed-off-by: Adam Buchbinder
Signed-off-by: Jiri Kosina
13 Jun, 2012
6 commits
-
This also includes a switch to tty refcounting. It makes sure, the
code no longer can access a freed TTY struct.Sometimes the only thing needed is to pass tty down to the callies.
Signed-off-by: Jiri Slaby
Cc: Samuel Ortiz
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman -
Use self->spinlock only for ctrl_skb and tx_skb. TTY stuff is now
protected by tty_port->lock. This is needed for further cleanup (and
conversion to tty_port helpers).This also closes the race in the end of close.
Signed-off-by: Jiri Slaby
Cc: Samuel Ortiz
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman -
Switch to tty_port->flags. And while at it, remove redefined flags for
them.Signed-off-by: Jiri Slaby
Cc: Samuel Ortiz
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman -
Switch to tty_port->count and blocked_open.
Signed-off-by: Jiri Slaby
Cc: Samuel Ortiz
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman -
Switch to tty_port->close_delay and closing_wait.
Signed-off-by: Jiri Slaby
Cc: Samuel Ortiz
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman -
And use close/open_wait from there.
Signed-off-by: Jiri Slaby
Cc: Samuel Ortiz
Cc: netdev@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
18 Feb, 2011
3 commits
-
Only oddities here are a couple of drivers that bogusly called the ldisc
helpers instead of returning -ENOIOCTLCMD. Fix the bug and the rest goes
away.Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman -
Doing tiocmget was such fun we should do tiocmset as well for the same
reasonsSigned-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman -
We don't actually need this and it causes problems for internal use of
this functionality. Currently there is a single use of the FILE * pointer.
That is the serial core which uses it to check tty_hung_up_p. However if
that is true then IO_ERROR is also already set so the check may be removed.Signed-off-by: Alan Cox
Signed-off-by: Greg Kroah-Hartman
24 Sep, 2010
1 commit
-
Change "return (EXPR);" to "return EXPR;"
return is not a function, parentheses are not required.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
15 Sep, 2010
1 commit
-
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
22 Aug, 2010
1 commit
-
struct net_device has its own struct net_device_stats member, so use
this one instead of a private copy in the irlan_cb struct.Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
22 Jul, 2010
1 commit
-
Remove IRDA_PACKED macro, which maps to __attribute__((packed)). IRDA is
one of the last users of __attribute__((packet)). Networking code uses
__packed now.Signed-off-by: Gustavo F. Padovan
Signed-off-by: David S. Miller
15 Feb, 2010
1 commit
-
Signed-off-by: Uwe Kleine-König
Signed-off-by: Jiri Kosina
06 Aug, 2009
1 commit
-
String literals are constant, and usually, we can also tag the array
of pointers const too, moving it to the .rodata section.Signed-off-by: Jan Engelhardt
Signed-off-by: David S. Miller
18 Dec, 2008
1 commit
-
We need to pad irda_skb_cb in order to keep it safe accross dev_queue_xmit()
calls. This is some ugly and temporary hack triggered by recent qisc code
changes.
Even though it fixes bugzilla.kernel.org bug #11795, it will be replaced by a
proper fix before 2.6.29 is released.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
17 Oct, 2008
1 commit
-
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
09 Jul, 2008
2 commits
-
This is a helper function, currently used by IRDA.
This is being added so that we can contain and isolate as many
explicit ->tx_queue references in the tree as possible.Signed-off-by: David S. Miller
-
Now qdisc, qdisc_sleeping, and qdisc_list also live there.
Signed-off-by: David S. Miller
14 May, 2008
1 commit
-
Replace u16ho with put/get_unaligned functions
Signed-off-by: Graf Yang
Signed-off-by: Bryan Wu
Signed-off-by: David S. Miller
15 Apr, 2008
1 commit
-
Even kernel 2.2.26 (sic) already contains the
#undef CONFIG_IRLAN_SEND_GRATUITOUS_ARP
with the comment "but for some reason the machine crashes if you use DHCP".Either someone finally looks into this or it's simply time to remove
this dead code.Reported-by: Robert P. J. Day
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller
06 Mar, 2008
1 commit
-
Signed-off-by: Harvey Harrison
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller
29 Jan, 2008
1 commit
-
This patch removes IrPORT and the old dongle drivers (all off them
have replacement drivers).Signed-off-by: Adrian Bunk
Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
21 Dec, 2007
1 commit
-
Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
26 Oct, 2007
1 commit
-
ircomm_tty can now become static.
Signed-off-by: Adrian Bunk
Signed-off-by: David S. Miller
20 Oct, 2007
1 commit
-
From: Jean Delvare
Signed-off-by: Jean Delvare
Signed-off-by: Adrian Bunk
11 Jul, 2007
1 commit
-
First IrDA configuration netlink layer implementation.
Currently, we only support the set/get mode commands.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
09 Jun, 2007
1 commit
-
From: G. Liakhovetski
We need to switch to NRM _before_ sending the final packet otherwise
we might hit a race condition where we get the first packet from the
peer while we're still in LAP_XMIT_P.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
