Eric Lee / smarc-fsl-linux-kernel

18 Nov, 2013

1 commit

  • 487722cf2   watchdog: Get rid of MODULE_ALIAS_MISCDEV statements ... Browse Code »

    I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
    and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

    Either the device is enumerated and the driver already has a module
    alias (e.g. PCI, USB etc.) that will get the right driver loaded
    automatically.

    Or the device is not enumerated and loading its driver will lead to
    more or less intrusive hardware poking. Such hardware poking should be
    limited to a bare minimum, so the user should really decide which
    drivers should be tried and in what order. Trying them all in
    arbitrary order can't do any good.

    On top of that, loading that many drivers at once bloats the kernel
    log. Also many drivers will stay loaded afterward, bloating the output
    of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
    loaded as a dependency) can't even be unloaded!

    If defining char-major-10-130 is needed then it should happen in
    user-space.

    Signed-off-by: Jean Delvare
    Acked-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Cc: Stephen Warren
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Ben Dooks
    Cc: Kukjin Kim
    Cc: Zwane Mwaikambo
    Cc: Jim Cromie

    Jean Delvare
     

12 Jul, 2013

1 commit

28 Mar, 2012

2 commits

07 Mar, 2010

1 commit

04 Dec, 2009

1 commit

  • af901ca18   tree-wide: fix assorted typos all over the place ... Browse Code »

    That is "success", "unknown", "through", "performance", "[re|un]mapping"
    , "access", "default", "reasonable", "[con]currently", "temperature"
    , "channel", "[un]used", "application", "example","hierarchy", "therefore"
    , "[over|under]flow", "contiguous", "threshold", "enough" and others.

    Signed-off-by: André Goddard Rosa
    Signed-off-by: Jiri Kosina

    André Goddard Rosa
     

26 Jun, 2009

1 commit

  • 5ba762c9b   powerpc/rtas: Fix watchdog driver temperature read functionality ... Browse Code »

    Using the RTAS watchdog driver to read out the temperature crashes
    on a PXCAB:

    Unable to handle kernel paging request for data at address 0xfe347b50
    Faulting instruction address: 0xc00000000001af64
    Oops: Kernel access of bad area, sig: 11 [#1]

    The wrong usage of "(void *)__pa(&temperature)" in rtas_call() is
    removed by using the function rtas_get_sensor() which does the
    right thing.

    Signed-off-by: Adrian Reber
    Acked-by: Utz Bacher
    Signed-off-by: Benjamin Herrenschmidt

    Adrian Reber
     

18 Jun, 2009

1 commit

07 Apr, 2009

1 commit

  • b6966b1be   powerpc/wdrtas: Update wdrtas_get_interval to use rtas_data_buf ... Browse Code »

    The buffer passed to the ibm,get-system-parameter RTAS call must be
    in the RMA. To ensure we pass an address in the RMA use rtas_data_buf
    for the actual RTAS call and then copy the result to value. We can't
    just make it static because this can be compiled in as a module.

    Also add the WDRTAS_SP_SPI_LEN so we don't litter '4' throughout the
    function.

    Signed-off-by: Mark Nelson
    Tested-by: Adrian Reber
    Acked-by: Utz Bacher
    Signed-off-by: Paul Mackerras

    Mark Nelson
     

07 Aug, 2008

1 commit

22 Jun, 2008

1 commit

18 Oct, 2007

1 commit