09 Aug, 2016

2 commits


25 Jan, 2016

1 commit

  • This patch fixes a false positive uninitialised variable warning
    in aead_perform by moving the source processing in front of the
    destination processing, thus ensuring that the initialisation of
    lastlen is always visible to gcc.

    Reported-by: Arnd Bergmann
    Signed-off-by: Herbert Xu
    Acked-by: Arnd Bergmann

    Herbert Xu
     

17 Nov, 2015

1 commit


17 Aug, 2015

1 commit


04 Aug, 2015

1 commit


23 Jul, 2015

1 commit


22 May, 2015

1 commit


13 May, 2015

2 commits


26 Jan, 2015

1 commit


01 Jan, 2014

1 commit


24 Nov, 2013

1 commit

  • Pull crypto update from Herbert Xu:
    - Made x86 ablk_helper generic for ARM
    - Phase out chainiv in favour of eseqiv (affects IPsec)
    - Fixed aes-cbc IV corruption on s390
    - Added constant-time crypto_memneq which replaces memcmp
    - Fixed aes-ctr in omap-aes
    - Added OMAP3 ROM RNG support
    - Add PRNG support for MSM SoC's
    - Add and use Job Ring API in caam
    - Misc fixes

    [ NOTE! This pull request was sent within the merge window, but Herbert
    has some questionable email sending setup that makes him public enemy
    #1 as far as gmail is concerned. So most of his emails seem to be
    trapped by gmail as spam, resulting in me not seeing them. - Linus ]

    * git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6: (49 commits)
    crypto: s390 - Fix aes-cbc IV corruption
    crypto: omap-aes - Fix CTR mode counter length
    crypto: omap-sham - Add missing modalias
    padata: make the sequence counter an atomic_t
    crypto: caam - Modify the interface layers to use JR API's
    crypto: caam - Add API's to allocate/free Job Rings
    crypto: caam - Add Platform driver for Job Ring
    hwrng: msm - Add PRNG support for MSM SoC's
    ARM: DT: msm: Add Qualcomm's PRNG driver binding document
    crypto: skcipher - Use eseqiv even on UP machines
    crypto: talitos - Simplify key parsing
    crypto: picoxcell - Simplify and harden key parsing
    crypto: ixp4xx - Simplify and harden key parsing
    crypto: authencesn - Simplify key parsing
    crypto: authenc - Export key parsing helper function
    crypto: mv_cesa: remove deprecated IRQF_DISABLED
    hwrng: OMAP3 ROM Random Number Generator support
    crypto: sha256_ssse3 - also test for BMI2
    crypto: mv_cesa - Remove redundant of_match_ptr
    crypto: sahara - Remove redundant of_match_ptr
    ...

    Linus Torvalds
     

31 Oct, 2013

2 commits


16 Oct, 2013

1 commit

  • Use the common helper function crypto_authenc_extractkeys() for key
    parsing. Also ensure the keys do fit into the corresponding buffers.
    Otherwise memory corruption might occur.

    Cc: Christian Hohnstaedt
    Cc: Herbert Xu
    Cc: "David S. Miller"
    Signed-off-by: Mathias Krause
    Signed-off-by: Herbert Xu

    Mathias Krause
     

22 Nov, 2012

1 commit


05 Apr, 2012

1 commit

  • Before commit de47725421ad5627a5c905f4e40bb844ebc06d29 ("include: replace
    linux/module.h with "struct module" wherever possible") was
    implicitly included through -> .

    Signed-off-by: Michał Wróbel
    Signed-off-by: Herbert Xu

    Michał Wróbel
     

13 Jan, 2012

2 commits

  • The function is called with locks held and thus should not use GFP_KERNEL.

    The semantic patch that makes this report is available
    in scripts/coccinelle/locks/call_kern.cocci.

    More information about semantic patching is available at
    http://coccinelle.lip6.fr/

    Signed-off-by: Julia Lawall
    Signed-off-by: Herbert Xu

    Julia Lawall
     
  • The added CRYPTO_ALG_KERN_DRIVER_ONLY indicates whether a cipher
    is only available via a kernel driver. If the cipher implementation
    might be available by using an instruction set or by porting the
    kernel code, then it must not be set.

    Signed-off-by: Nikos Mavrogiannopoulos
    Signed-off-by: Herbert Xu

    Nikos Mavrogiannopoulos
     

31 Mar, 2011

1 commit


27 May, 2010

1 commit

  • Fixes the following on IXP425 little-endian:

    NPE-C: firmware functionality 0x5, revision 0x2:1
    alg: skcipher: Test 1 failed on encryption for ecb(des)-ixp4xx
    00000000: 01 23 45 67 89 ab cd e7
    alg: skcipher: Test 1 failed on encryption for ecb(des3_ede)-ixp4xx
    00000000: 73 6f 6d 65 64 61 74 61
    alg: skcipher: Test 1 failed on encryption for ecb(aes)-ixp4xx
    00000000: 00 11 22 33 44 55 66 77 88 99 aa bb cc dd ee ff

    Signed-off-by: Krzysztof Hałasa
    Acked-by: Christian Hohnstaedt

    Krzysztof Hałasa
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

18 May, 2009

1 commit


12 Apr, 2009

1 commit

  • - the loaded firmware may not support crypto at all or
    only support DES and 3DES but not AES or
    support DES, 3DES and AES.

    - in case of no crypto support of the firmware, the module load will fail.
    - in case of missing AES support, the AES algorithms are not registered
    and a warning is printed during module load.

    Signed-off-by: Christian Hohnstaedt
    Signed-off-by: Herbert Xu

    Christian Hohnstaedt
     

07 Apr, 2009

1 commit


27 Mar, 2009

1 commit


04 Mar, 2009

1 commit


07 Aug, 2008

1 commit


10 Jul, 2008

1 commit