Eric Lee / smarc-fsl-linux-kernel

15 Sep, 2016

1 commit

  • 7b5409ee9   gpio: altera: fix implicit assumption module.h is present ... Browse Code »

    The Kconfig for this file is:

    drivers/gpio/Kconfig:config GPIO_ALTERA
    drivers/gpio/Kconfig: tristate "Altera GPIO"

    ...but however it does not include module.h -- it in turn gets it from
    another header (gpio/driver.h) and we'd like to replace that with a
    forward delcaration of "struct module;" but if we do, this file will
    fail to compile.

    So we fix this first to avoid putting build failures into the bisect
    commit history.

    Cc: Linus Walleij
    Cc: Alexandre Courbot
    Cc: linux-gpio@vger.kernel.org
    Signed-off-by: Paul Gortmaker
    Signed-off-by: Linus Walleij

    Paul Gortmaker
     

27 Jan, 2016

1 commit

  • 73c13c834   gpio: gpio-altera: Remove gpiochip on probe failure. ... Browse Code »

    On failure to setup the irq altera_gpio_probe would return an error
    but not go to cleanup. This resulted in kernel fault
    "Unable to handle kernel paging request at virtual address xxxxxxxx"
    later on in of_gpiochip_find_and_xlate.

    Signed-off-by: Phil Reid
    Signed-off-by: Linus Walleij

    Phil Reid
     

05 Jan, 2016

1 commit

19 Nov, 2015

1 commit

  • 58383c784   gpio: change member .dev to .parent ... Browse Code »

    The name .dev in a struct is normally reserved for a struct device
    that is let us say a superclass to the thing described by the struct.
    struct gpio_chip stands out by confusingly using a struct device *dev
    to point to the parent device (such as a platform_device) that
    represents the hardware. As we want to give gpio_chip:s real devices,
    this is not working. We need to rename this member to parent.

    This was done by two coccinelle scripts, I guess it is possible to
    combine them into one, but I don't know such stuff. They look like
    this:

    @@
    struct gpio_chip *var;
    @@
    -var->dev
    +var->parent

    and:

    @@
    struct gpio_chip var;
    @@
    -var.dev
    +var.parent

    and:

    @@
    struct bgpio_chip *var;
    @@
    -var->gc.dev
    +var->gc.parent

    Plus a few instances of bgpio that I couldn't figure out how
    to teach Coccinelle to rewrite.

    This patch hits all over the place, but I *strongly* prefer this
    solution to any piecemal approaches that just exercise patch
    mechanics all over the place. It mainly hits drivers/gpio and
    drivers/pinctrl which is my own backyard anyway.

    Cc: Haavard Skinnemoen
    Cc: Rafał Miłecki
    Cc: Richard Purdie
    Cc: Mauro Carvalho Chehab
    Cc: Alek Du
    Cc: Jaroslav Kysela
    Cc: Takashi Iwai
    Acked-by: Dmitry Torokhov
    Acked-by: Greg Kroah-Hartman
    Acked-by: Lee Jones
    Acked-by: Jiri Kosina
    Acked-by: Hans-Christian Egtvedt
    Acked-by: Jacek Anaszewski
    Signed-off-by: Linus Walleij

    Linus Walleij
     

02 Oct, 2015

1 commit

  • 231d51b8a   gpio: altera: use container_of() to get state container ... Browse Code »

    The state container of the Altera GPIO driver is extracted from
    the gpio_chip exploiting the fact that offsetof() the
    struct gpio_chip inside the struct of_mm_gpio_chip are both 0, so
    the container_of() is in practice a noop. However if a member
    is added to struct altera_gpio_chip in front of
    struct of_mm_gpio_chip, things will break. Using proper
    container_of() avoids this problem.

    Semantically this is a noop, the compiler will optimize it away,
    but syntactically it makes me happier.

    Cc: Tien Hock Loh
    Signed-off-by: Linus Walleij

    Linus Walleij
     

16 Sep, 2015

1 commit

  • bd0b9ac40   genirq: Remove irq argument from irq flow handlers ... Browse Code »

    Most interrupt flow handlers do not use the irq argument. Those few
    which use it can retrieve the irq number from the irq descriptor.

    Remove the argument.

    Search and replace was done with coccinelle and some extra helper
    scripts around it. Thanks to Julia for her help!

    Signed-off-by: Thomas Gleixner
    Cc: Julia Lawall
    Cc: Jiang Liu

    Thomas Gleixner
     

16 Jul, 2015

2 commits

16 Jun, 2015

1 commit

27 Mar, 2015

1 commit

08 Mar, 2015

1 commit

  • c5abbba93   drivers/gpio: Altera soft IP GPIO driver ... Browse Code »

    Adds a new driver for Altera soft GPIO IP. The driver is able to do
    read/write and allows GPIO to be a interrupt controller.

    Tested on Altera GHRD on interrupt handling and IO.

    v10:
    - Updated conflicting device tree parameters
    - Removed unused headers
    - Used macro instead of magic numbers for ngpio
    - Code readability cleanup using ?: and temporal variables
    - Removed leftover garbage and unnecessary function calls
    - Checked bgpio_init but unusable because Altera GPIO may not
    be a multiple of 8 bits

    v9:
    - Removed duplicated initialization on set_type using temporals
    to improve code readability in calling generic_handle_irq
    - Using ?: ternary to reduce code size

    v8:
    - Using for_each_set_bit
    - Added const for struct definition
    - Removed naggy pr_err
    - Sort alpha header
    - Remove unused macros
    - Use fixed width data types instead of unsigned long
    - Whitespace issue fixes
    - Removed _relaxed function for better compatibility across different
    CPU
    - Changed irq_create_mapping to platform_get_irq updated implementation
    to use gpiochip_irqchip_add
    - Reserve interrupt-cells number 2 in device tree binding for future
    use
    - Remove confusing sections on devicetree bindings
    - Added tristate Kconfig help text

    v7:
    - Used dev_warn instead of pr_warn
    - Clean up unnecesarry if else indentation

    v6:
    - Added irq_startup and irq_shutdown
    - Changed bitwise clamping style
    - Cleanup bitwise operation to improve readability change naming of
    mapped irqs from virq to mapped_irq

    v5:
    - Dispose irq_domain mapping correctly
    - Update optional binding description in binding docs

    v4:
    - Added vendor prefix to devicetree binding for IP specific properties
    using MMIO GPIO helper library instead of manually map PIO to memory
    - altera_gpio_chip inline struct documentation to kerneldoc
    - Using dev_ print to print a better failure message

    v2, v3:
    - Do not reference NO_IRQ
    - Updated irq_set_type to only allow the hardware configured irq type

    Signed-off-by: Tien Hock Loh
    Signed-off-by: Linus Walleij

    Tien Hock Loh