31 Mar, 2016
1 commit
-
The Kconfig currently controlling compilation of this code is:
drivers/gpio/Kconfig:config GPIO_MOXART
drivers/gpio/Kconfig: bool "MOXART GPIO support"...meaning that it currently is not being built as a module by anyone.
Lets remove the couple traces of modular references so that when reading
the driver there is no doubt it is builtin-only.Since module_platform_driver() uses the same init level priority as
builtin_platform_driver() the init ordering remains unchanged with
this commit.We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.We don't replace module.h with init.h since the file already has that.
Cc: Jonas Jensen
Cc: Alexandre Courbot
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker
Signed-off-by: Linus Walleij
08 Mar, 2016
1 commit
07 Mar, 2016
1 commit
-
These fields are initialized by bgpio_init() with exactly the same settings
so remove the redundant code.Signed-off-by: Axel Lin
Signed-off-by: Linus Walleij
23 Feb, 2016
1 commit
-
Use devm_gpiochip_add_data() for GPIO registration.
Signed-off-by: Laxman Dewangan
07 Jan, 2016
1 commit
-
A cleanup patch replaced bgpio_chip with gpio_chip but missed
two references to the bgpio_chip:drivers/gpio/gpio-moxart.c:60:19: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
gc->bgpio_data = bgc->read_reg(bgc->reg_set);
drivers/gpio/gpio-moxart.c:35:20: note: 'gc' declared here
drivers/gpio/gpio-moxart.c:60:33: error: use of undeclared identifier 'bgc'; did you mean 'gc'?
gc->bgpio_data = bgc->read_reg(bgc->reg_set);This adds the missing change.
Signed-off-by: Arnd Bergmann
Fixes: 0f4630f3720e ("gpio: generic: factor into gpio_chip struct")
Signed-off-by: Linus Walleij
05 Jan, 2016
1 commit
-
The separate struct bgpio_chip has been a pain to handle, both
by being confusingly similar in name to struct gpio_chip and
for being contained inside a struct so that struct gpio_chip
is contained in a struct contained in a struct, making several
steps of dereferencing necessary.Make things simpler: include the fields directly into
, #ifdef:ed for CONFIG_GENERIC_GPIO, and
get rid of the altogether. Prefix
some of the member variables with bgpio_* and add proper
kerneldoc while we're at it.Modify all users to handle the change and use a struct
gpio_chip directly. And while we're at it: replace all
container_of() dereferencing by gpiochip_get_data() and
registering the gpio_chip with gpiochip_add_data().Cc: arm@kernel.org
Cc: Alexander Shiyan
Cc: Shawn Guo
Cc: Sascha Hauer
Cc: Kukjin Kim
Cc: Alexandre Courbot
Cc: Brian Norris
Cc: Florian Fainelli
Cc: Sudeep Holla
Cc: Lorenzo Pieralisi
Cc: Nicolas Pitre
Cc: Olof Johansson
Cc: Vladimir Zapolskiy
Cc: Rabin Vincent
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-omap@vger.kernel.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com
Acked-by: Gregory Fong
Acked-by: Liviu Dudau
Acked-by: H Hartley Sweeten
Acked-by: Tony Lindgren
Acked-by: Krzysztof Kozlowski
Acked-by: Lee Jones
Signed-off-by: Linus Walleij
19 Nov, 2015
1 commit
-
The name .dev in a struct is normally reserved for a struct device
that is let us say a superclass to the thing described by the struct.
struct gpio_chip stands out by confusingly using a struct device *dev
to point to the parent device (such as a platform_device) that
represents the hardware. As we want to give gpio_chip:s real devices,
this is not working. We need to rename this member to parent.This was done by two coccinelle scripts, I guess it is possible to
combine them into one, but I don't know such stuff. They look like
this:@@
struct gpio_chip *var;
@@
-var->dev
+var->parentand:
@@
struct gpio_chip var;
@@
-var.dev
+var.parentand:
@@
struct bgpio_chip *var;
@@
-var->gc.dev
+var->gc.parentPlus a few instances of bgpio that I couldn't figure out how
to teach Coccinelle to rewrite.This patch hits all over the place, but I *strongly* prefer this
solution to any piecemal approaches that just exercise patch
mechanics all over the place. It mainly hits drivers/gpio and
drivers/pinctrl which is my own backyard anyway.Cc: Haavard Skinnemoen
Cc: Rafał Miłecki
Cc: Richard Purdie
Cc: Mauro Carvalho Chehab
Cc: Alek Du
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Acked-by: Dmitry Torokhov
Acked-by: Greg Kroah-Hartman
Acked-by: Lee Jones
Acked-by: Jiri Kosina
Acked-by: Hans-Christian Egtvedt
Acked-by: Jacek Anaszewski
Signed-off-by: Linus Walleij
17 Oct, 2015
1 commit
-
Replace all trivial request/free callbacks that do nothing but call into
pinctrl code with the generic versions.Signed-off-by: Jonas Gorski
Reviewed-by: Thomas Petazzoni
Acked-by: James Hogan
Acked-by: Stefan Agner
Acked-by: Joachim Eastwood
Acked-by: Gregory CLEMENT
Signed-off-by: Linus Walleij
11 May, 2015
1 commit
-
Adding a BGPIOF_READ_OUTPUT_REG_SET initialization flag to GPIO
generic MMIO driver makes possible to remove a private get() value
function from the driver.Signed-off-by: Vladimir Zapolskiy
Signed-off-by: Linus Walleij
09 Jan, 2015
1 commit
-
This patch converts MOXART GPIO driver to use basic_mmio_gpio
generic library.Signed-off-by: Kamlakant Patel
Acked-by: Alexandre Courbot
Tested-by: Jonas Jensen
Signed-off-by: Linus Walleij
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
09 May, 2014
1 commit
-
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.Signed-off-by: Jingoo Han
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Linus Walleij
27 Mar, 2014
2 commits
-
moxart_gpio_direction_output() ignored the state passed into it. Fix it.
Signed-off-by: Axel Lin
Reviewed-by: Alexandre Courbot
Signed-off-by: Linus Walleij -
Slightly adjust the code to avoid forward declaration as we need to call
moxart_gpio_set() in moxart_gpio_direction_output() to properly set the
output state.Signed-off-by: Axel Lin
Reviewed-by: Alexandre Courbot
Signed-off-by: Linus Walleij
20 Dec, 2013
2 commits
-
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.Signed-off-by: Wei Yongjun
Signed-off-by: Linus Walleij -
Add missing .owner of struct gpio_chip. This prevents the
module from being removed from underneath its users.Signed-off-by: Wei Yongjun
Signed-off-by: Linus Walleij
04 Dec, 2013
1 commit
-
Renaming "moxart_gpio_base" to "base" allows better fit,
remove line breaks in moxart_gpio_get().While doing trivial cleanup, also remove fields initialized
with zero in moxart_template_chip.Signed-off-by: Jonas Jensen
Signed-off-by: Linus Walleij
03 Dec, 2013
1 commit
-
Add GPIO driver for MOXA ART SoCs.
Signed-off-by: Jonas Jensen
Acked-by: Arnd Bergmann
Signed-off-by: Linus Walleij