15 Sep, 2016
1 commit
-
This file is currently getting module.h from a global gpio header
and it will fail to build once we remove module.h from that.However, the driver is controlled with the following Kconfig:
drivers/gpio/Kconfig:config GPIO_PALMAS
drivers/gpio/Kconfig: bool "TI PALMAS series PMICs GPIO"and hence the line of MODULE_DEVICE_TABLE is a no-op that can simply
be deleted. In fact it should have been removed in an earlier commit
that did demodularization, however the unseen include prevented my
build testing from detecting it.Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker
Signed-off-by: Linus Walleij
07 Jun, 2016
1 commit
-
A platform_driver need not set an owner since it will be populated
by platform_driver_register().
Likewise for mcb_driver (gpio-menz127.c).Signed-off-by: Masahiro Yamada
Acked-by: Charles Keepax
Signed-off-by: Linus Walleij
05 Apr, 2016
1 commit
-
The Kconfig currently controlling compilation of this code is:
drivers/gpio/Kconfig:config GPIO_PALMAS
drivers/gpio/Kconfig: bool "TI PALMAS series PMICs GPIO"...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.Since module_init was not in use by this code, the init ordering
remains unchanged with this commit.We also delete the MODULE_LICENSE tag etc. since all that information
is already contained at the top of the file in the comments.Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: Laxman Dewangan
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Paul Gortmaker
Signed-off-by: Linus Walleij
23 Feb, 2016
1 commit
-
Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.Signed-off-by: Laxman Dewangan
05 Jan, 2016
1 commit
-
This makes the driver use the data pointer added to the gpio_chip
to store a pointer to the state container instead of relying on
container_of().Cc: Andrew Chew
Cc: Stephen Warren
Acked-by: Laxman Dewangan
Signed-off-by: Linus Walleij
21 Dec, 2015
1 commit
-
Linux 4.4-rc6
19 Nov, 2015
1 commit
-
The name .dev in a struct is normally reserved for a struct device
that is let us say a superclass to the thing described by the struct.
struct gpio_chip stands out by confusingly using a struct device *dev
to point to the parent device (such as a platform_device) that
represents the hardware. As we want to give gpio_chip:s real devices,
this is not working. We need to rename this member to parent.This was done by two coccinelle scripts, I guess it is possible to
combine them into one, but I don't know such stuff. They look like
this:@@
struct gpio_chip *var;
@@
-var->dev
+var->parentand:
@@
struct gpio_chip var;
@@
-var.dev
+var.parentand:
@@
struct bgpio_chip *var;
@@
-var->gc.dev
+var->gc.parentPlus a few instances of bgpio that I couldn't figure out how
to teach Coccinelle to rewrite.This patch hits all over the place, but I *strongly* prefer this
solution to any piecemal approaches that just exercise patch
mechanics all over the place. It mainly hits drivers/gpio and
drivers/pinctrl which is my own backyard anyway.Cc: Haavard Skinnemoen
Cc: Rafał Miłecki
Cc: Richard Purdie
Cc: Mauro Carvalho Chehab
Cc: Alek Du
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Acked-by: Dmitry Torokhov
Acked-by: Greg Kroah-Hartman
Acked-by: Lee Jones
Acked-by: Jiri Kosina
Acked-by: Hans-Christian Egtvedt
Acked-by: Jacek Anaszewski
Signed-off-by: Linus Walleij
17 Nov, 2015
1 commit
-
of_match_device could return NULL, and so cause a NULL pointer
dereference later.Reported-by: coverity (CID 1130700)
Signed-off-by: LABBE Corentin
Signed-off-by: Linus Walleij
22 Jul, 2014
1 commit
-
Signed-off-by: abdoulaye berthe
Signed-off-by: Linus Walleij
09 May, 2014
2 commits
-
Make of_device_id array const, because all OF functions
handle it as const.Signed-off-by: Jingoo Han
Signed-off-by: Linus Walleij -
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.Signed-off-by: Jingoo Han
Reviewed-by: Javier Martinez Canillas
Signed-off-by: Linus Walleij
04 Dec, 2013
1 commit
-
This switches the two members of struct gpio_chip that were
defined as unsigned foo:1 to bool, because that is indeed what
they are. Switch all users in the gpio and pinctrl subsystems
to assign these values with true/false instead of 0/1. The
users outside these subsystems will survive since true/false
is 1/0, atleast we set some kind of more strict typing example.Signed-off-by: Linus Walleij
19 Sep, 2013
1 commit
-
TI Palmas series device TPS80036 supports 16 GPIOs.
Register its all 16 gpios when this device is selected.Signed-off-by: Laxman Dewangan
Signed-off-by: Linus Walleij
16 Aug, 2013
1 commit
-
It seems that the value read back from the PALMAS_GPIO_DATA_IN register
isn't valid if the GPIO direction is out. When that's the case, we can
read back the PALMAS_GPIO_DATA_OUT register to get the proper output value.Signed-off-by: Andrew Chew
Acked-by: Laxman Dewangan
Signed-off-by: Linus Walleij
30 Jul, 2013
1 commit
-
Add of_device_id table for Palma GPIO to be enable the
driver from DT file.The driver can be registered from DT file as:
palmas: tps65913@58 {
:::::::::::
palmas_gpio: palmas_gpio {
compatible = "ti,palmas-gpio";
gpio-controller;
#gpio-cells = ;
};
};Signed-off-by: Laxman Dewangan
Acked-by: Stephen Warren
Signed-off-by: Linus Walleij
14 Feb, 2013
1 commit
-
Add gpio driver for TI Palmas series PMIC. This has 8 gpio which can
work as input/output.Signed-off-by: Laxman Dewangan
Acked-by: Linus Walleij
Signed-off-by: Samuel Ortiz