15 Sep, 2016

1 commit

• 39d800722   gpio: wcove: fix implicit assumption module.h is present ... Browse Code »

  The Kconfig for this file is:

  drivers/gpio/Kconfig:config GPIO_WHISKEY_COVE
  drivers/gpio/Kconfig: tristate "GPIO support for Whiskey Cove PMIC"

  ...but however it does not include module.h -- it in turn gets it from
  another header (gpio/driver.h) and we'd like to replace that with a
  forward delcaration of "struct module;" but if we do, this file will
  fail to compile.

  So we fix this first to avoid putting build failures into the bisect
  commit history.

  Cc: Ajay Thomas
  Cc: Bin Gao
  Cc: Andy Shevchenko
  Cc: Mika Westerberg
  Cc: Linus Walleij
  Cc: Alexandre Courbot
  Cc: linux-gpio@vger.kernel.org
  Signed-off-by: Paul Gortmaker
  Signed-off-by: Linus Walleij

  Paul Gortmaker

  2016-09-15 20:03:33 +0800  

19 Aug, 2016

1 commit

• 7d9e59ce7   gpio: wcove-gpio: add get_direction method ... Browse Code »

  This patch adds .get_direction method for the gpio_chip structure
  of the wcove_gpio driver.

  Signed-off-by: Bin Gao
  Signed-off-by: Linus Walleij

  Bin Gao

  2016-08-19 21:02:19 +0800  

11 Aug, 2016

1 commit

• 0ba19cfc2   gpio: Add Intel WhiskeyCove PMIC GPIO driver ... Browse Code »

  This patch introduces a separate GPIO driver for Intel WhiskeyCove PMIC.
  This driver is based on gpio-crystalcove.c.

  Changes in v7:
  - Fixed various coding style comments from Andy Shevchenko
  Changes in v6:
  - Removed unnecessary wcove_gpio_remove()
  - Used devm_gpiochip_remove() instead of gpiochip_remove()
  - Various coding style changes per Mika's comment
  Changes in v5:
  - Revisited the interrupt handler code to iterate until all pending
  interrupts are handled. This change is to avoid missing interrupt
  when we're inside the interrupt handler.
  - Used regmap_bulk_read() to read address adjacent registers.
  Changes in v4:
  - Converted CTLI_INTCNT_XX macros to less verbose ones INT_DETECT_XX.
  - Add comments about why there is no .pm for the driver.
  - Header files re-ordered.
  - Various coding style change to address Andy's comments.
  Changes in v3:
  - Fixed the year in copyright line(2015-->2016).
  - Removed DRV_NAME macro.
  - Added kernel-doc for regmap_irq_chip of the wcove_gpio structure.
  - Line length fix.
  Changes in v2:
  - Typo fix (Whsikey --> Whiskey).
  - Included linux/gpio/driver.h instead of linux/gpio.h
  - Implemented .set_single_ended().
  - Added GPIO register description.
  - Replaced container_of() with gpiochip_get_data().
  - Removed unnecessary "if (gpio > WCOVE_VGPIO_NUM" check.
  - Removed the device id table and added MODULE_ALIAS().

  Signed-off-by: Ajay Thomas
  Signed-off-by: Bin Gao
  Reviewed-by: Andy Shevchenko
  Reviewed-by: Mika Westerberg
  Signed-off-by: Linus Walleij

  Bin Gao

  2016-08-11 19:27:39 +0800