21 Mar, 2016
1 commit
-
The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.Signed-off-by: Wolfram Sang
Signed-off-by: David S. Miller
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
06 Sep, 2013
1 commit
-
Added missing __iomem annotation in order to fix the following
sparse warnings:drivers/ide/palm_bk3710.c:194:31: warning: incorrect type in initializer (different address spaces)
drivers/ide/palm_bk3710.c:194:31: expected void [noderef] *base
drivers/ide/palm_bk3710.c:194:31: got void *
drivers/ide/palm_bk3710.c:212:31: warning: incorrect type in initializer (different address spaces)
drivers/ide/palm_bk3710.c:212:31: expected void [noderef] *base
drivers/ide/palm_bk3710.c:212:31: got void *Signed-off-by: Jingoo Han
Signed-off-by: David S. Miller
04 Jan, 2013
1 commit
-
CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
markings need to be removed.This change removes the use of __devinit, __devexit_p, __devinitdata,
__devinitconst, and __devexit from these drivers.Based on patches originally written by Bill Pemberton, but redone by me
in order to handle some of the coding style issues better, by hand.Cc: Bill Pemberton
Cc: "David S. Miller"
Signed-off-by: Greg Kroah-Hartman
10 Jun, 2011
1 commit
-
Several fixes as well where the +1 was missing.
Done via coccinelle scripts like:
@@
struct resource *ptr;
@@- ptr->end - ptr->start + 1
+ resource_size(ptr)and some grep and typing.
Mostly uncompiled, no cross-compilers.
Signed-off-by: Joe Perches
Signed-off-by: Jiri Kosina
19 Jan, 2010
3 commits
-
Use the current PIO mode value instead of the physical maximum one
of the pair device on the port to determine PIO commmand timings used
for both devices on the port.Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller -
Change ->set_dma_mode method parameters to match ->set_dmamode method
used in struct ata_port_operations.Signed-off-by: Bartlomiej Zolnierkiewicz
-
Change ->set_pio_mode method parameters to match ->set_piomode method
used in struct ata_port_operations.Signed-off-by: Bartlomiej Zolnierkiewicz
Signed-off-by: David S. Miller
16 Aug, 2009
1 commit
-
DaVinci core code has converted to the new clkdev API so
clock name strings are not needed. Instead, just the a
'struct device' pointer is needed.Signed-off-by: Kevin Hilman
Acked-by: Sergei Shtylyov
Signed-off-by: David S. Miller
18 May, 2009
3 commits
-
Remove hw_regs_t typedef and rename struct hw_regs_s to struct ide_hw.
There should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
Pass number of ports to ide_host_{alloc,add}() and then update
all users accordingly.v2:
- drop no longer needed NULL initializers in buddha.c, cmd640.c and gayle.c
(noticed by Sergei)There should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz -
* Convert host drivers that still use hw_regs_t's chipset field to use
the one in struct ide_port_info instead.* Move special handling of ide_pci chipset type from ide_hw_configure()
to ide_init_port().* Remove chipset field from hw_regs_t.
While at it:
- remove stale comment in delkin_cb.cThere should be no functional changes caused by this patch.
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
24 Apr, 2009
2 commits
-
Remove superfluous commas and add missing whitespaces.
Noticed-by: Joe Perches
Cc: David Brownell
Signed-off-by: Bartlomiej Zolnierkiewicz -
Bugfixes noted by checking the code against the controller
documentation (TI document number SPRUE21):- Remove declarations for eight non-existent registers (!);
and remove accesses to two of them.- Remove access to various non-existent bitfields in some of
the registers which *do* exist (those fields must-be-zero).- Provide comment to replace bogus reset logic (removed above,
it relied on non-existent bitfields). Resets require GPIO
help; this driver doesn't currently know about that.With some minor cleanup: relocate a comment, avoid an extra
lookup of the PIO timings.Signed-off-by: David Brownell
Cc: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
23 Apr, 2009
1 commit
-
Fix UDMA throughput bug: tCYC averages t2CYCTYP/2, but the code
previously assumed it was the same as t2CYCTYP. (That is, it was
using just one clock edge, not both.) Move the table's type
declaration so it's adjacent to the table, making it more clear
what those numbers mean.On one system this change increased throughput by almost 4x: UDMA/66
sometimes topped 23 MB/sec (on a drive known to do much better). On
another system it was around a 10% win (UDMA/66 up to 7+ MB/sec).The difference might be caused by the ratio between memory and IDE
clocks. In the system with large speedup, this was exactly 2 (as a
workaround for a rev 1.1 silicon bug). The other system used a more
standard ratio of 1.63 (and rev 2.1 silicon) ... clock domain synch
might have some issues, they're not unheard-of.Signed-off-by: David Brownell
Acked-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
27 Mar, 2009
1 commit
-
Signed-off-by: Kevin Hilman
Acked-by: Sergei Shtylyov
[bart: minor CodingStyle fixup per Sergei's suggestion]
Signed-off-by: Bartlomiej Zolnierkiewicz
19 Jan, 2009
1 commit
-
CC drivers/ide/palm_bk3710.o
drivers/ide/palm_bk3710.c: In function 'palm_bk3710_probe':
drivers/ide/palm_bk3710.c:382: warning: assignment makes integer from pointer without a castSomeone should fix hw_regs_t to neither be a typedef, nor
use "unsigned long" where it should use "void __iomem *".Signed-off-by: David Brownell
Cc: Kevin Hilman
Cc: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
07 Jan, 2009
1 commit
-
Replace setting of 'hwif->dma_ops' in the 'alim15x3' and 'palm_bk3710' drivers'
init_dma() methods with initializing the corresponding member of their 'struct
ide_port_info' instances and remove such setting from the 'hpt366' driver that
just doesn't use 'sff_dma_ops'. Along with some code save, this prepares us for
the next patch...Signed-off-by: Sergei Shtylyov
Signed-off-by: Bartlomiej Zolnierkiewicz
22 Oct, 2008
1 commit
-
Suggested-by: Ralf Baechle
Signed-off-by: Bartlomiej Zolnierkiewicz