20 Sep, 2016

1 commit

• db83d08de   [media] constify local structures ... Browse Code »

  For structure types defined in the same file or local header files, find
  top-level static structure declarations that have the following
  properties:
  1. Never reassigned.
  2. Address never taken
  3. Not passed to a top-level macro call
  4. No pointer or array-typed field passed to a function or stored in a
  variable.
  Declare structures having all of these properties as const.

  Done using Coccinelle.
  Based on a suggestion by Joe Perches .

  Signed-off-by: Julia Lawall
  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Julia Lawall

  2016-09-20 03:22:18 +0800  

09 Jul, 2016

1 commit

• 20634fd1c   [media] ddbridge: Replace vmalloc with vzalloc ... Browse Code »

  vzalloc combines vmalloc and memset 0.

  The Coccinelle semantic patch used to make this change is as follows:
  @@
  type T;
  T *d;
  expression e;
  statement S;
  @@

  d =
  - vmalloc
  + vzalloc
  (...);
  if (!d) S
  - memset(d, 0, sizeof(T));

  Signed-off-by: Amitoj Kaur Chawla
  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Amitoj Kaur Chawla

  2016-07-09 03:36:43 +0800  

01 Feb, 2016

1 commit

• 242c50335   [media] constify stv6110x_devctl structure ... Browse Code »

  The stv6110x_devctl structure is never modified, so declare it as
  const.

  Done with the help of Coccinelle.

  Signed-off-by: Julia Lawall
  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Julia Lawall

  2016-02-01 17:31:17 +0800  

11 Jan, 2016

1 commit

• df2f94e56   [media] dvb: modify core to implement interfaces/entities at MC new gen ... Browse Code »

  The Media Controller New Generation redefines the types for both
  interfaces and entities to be used on DVB. Make the needed
  changes at the DVB core for all interfaces, entities and
  data and interface links to appear in the graph.

  Acked-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Mauro Carvalho Chehab

  2016-01-11 22:18:52 +0800  

18 Nov, 2015

1 commit

• 4bdbcb319   [media] ddbridge: fix wait_event_timeout return handling ... Browse Code »

  API conformance testing for completions with coccinelle spatches are being
  used to locate API usage inconsistencies:
  ./drivers/media/pci/ddbridge/ddbridge-core.c:89
  incorrect check for negative return

  Return type of wait_event_timeout is signed long not int and the
  return type is >=0 always thus the negative check is unnecessary..
  As stat is used here exclusively its type is simply changed and the
  negative return check dropped.

  Signed-off-by: Nicholas Mc Guire
  Signed-off-by: Mauro Carvalho Chehab

  Nicholas Mc Guire

  2015-11-18 22:21:29 +0800  

10 Jun, 2015

1 commit

• 25e057fdd   [media] ddbridge: Do not free_irq() if request_irq() failed ... Browse Code »

  My static checker detected that free_irq() is called even after
  request_irq() failed in ddb_probe(). In this case, the kernel may try to
  free dev->pdev->irq although the IRQ is not assigned. This event rarely
  occurs, but always introduces a warning if it happens.

  "goto fail1" always results in disabling enabled MSI and releasing a
  requested IRQ. It seems like the former handling is necessary. So I added
  a conditional branch before the free_irq() (stat == 0 means request_irq()
  succeeds).

  Signed-off-by: Takeshi Yoshimura
  Signed-off-by: Mauro Carvalho Chehab

  Takeshi Yoshimura

  2015-06-10 06:40:33 +0800  

05 Dec, 2014

1 commit

• ddc0085e9   [media] ddbridge: remove unneeded check before dvb_unregister_device() ... Browse Code »

  The dvb_unregister_device() function tests whether its argument is NULL
  and then returns immediately. Thus the test around the call is not needed.

  This issue was detected by using the Coccinelle software.

  Signed-off-by: Markus Elfring
  Signed-off-by: Mauro Carvalho Chehab

  Markus Elfring

  2014-12-05 01:28:52 +0800  

03 Sep, 2014

1 commit

• b5c00cc5a   [media] ddbridge: fix sparse warnings ... Browse Code »

  drivers/media/pci/ddbridge/ddbridge-core.c:88:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:93:37: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:95:25: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:99:15: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:117:58: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:119:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:123:68: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:130:17: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:131:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:136:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:138:25: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:152:22: warning: symbol 'ddb_i2c_algo' was not declared. Should it be static?
  drivers/media/pci/ddbridge/ddbridge-core.c:183:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:184:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:246:25: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:247:25: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:255:25: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:256:25: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:269:35: warning: Using plain integer as NULL pointer
  drivers/media/pci/ddbridge/ddbridge-core.c:358:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:359:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:360:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:362:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:366:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:368:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:369:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:370:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:380:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:381:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:393:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:394:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:395:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:396:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:397:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:401:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:403:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:404:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:406:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:416:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:417:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:475:36: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:484:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:494:20: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:501:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:524:36: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:534:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:852:21: warning: Using plain integer as NULL pointer
  drivers/media/pci/ddbridge/ddbridge-core.c:973:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
  drivers/media/pci/ddbridge/ddbridge-core.c:974:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
  drivers/media/pci/ddbridge/ddbridge-core.c:978:20: warning: Using plain integer as NULL pointer
  drivers/media/pci/ddbridge/ddbridge-core.c:982:20: warning: Using plain integer as NULL pointer
  drivers/media/pci/ddbridge/ddbridge-core.c:1003:23: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1006:23: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1009:30: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1015:25: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1017:39: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1035:24: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1041:20: warning: symbol 'cxd_cfg' was not declared. Should it be static?
  drivers/media/pci/ddbridge/ddbridge-core.c:1130:44: warning: Using plain integer as NULL pointer
  drivers/media/pci/ddbridge/ddbridge-core.c:1183:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1188:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1193:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1198:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1213:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1214:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1215:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1216:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1231:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1232:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1233:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1289:17: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1333:23: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1295:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1347:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1353:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1354:24: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1359:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1361:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1373:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1374:16: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1378:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1382:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1385:17: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1386:24: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1388:24: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1393:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1394:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1395:16: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1398:16: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1399:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1451:42: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1462:45: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1467:37: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1538:28: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1550:9: warning: incorrect type in argument 2 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1561:31: warning: Using plain integer as NULL pointer
  drivers/media/pci/ddbridge/ddbridge-core.c:1585:19: warning: incorrect type in assignment (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1591:47: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1591:60: warning: incorrect type in argument 1 (different address spaces)
  drivers/media/pci/ddbridge/ddbridge-core.c:1607:9: warning: too many warnings

  Signed-off-by: Hans Verkuil
  Signed-off-by: Mauro Carvalho Chehab

  Hans Verkuil

  2014-09-03 20:35:03 +0800  

27 Jul, 2014

1 commit

• 93961435d   [media] ddbridge: Add IDs for several newer Digital Devices cards ... Browse Code »

  This patch adds the necessary IDs for the following dvb cards:

  Digital Devices Octopus Mini
  Digital Devices Cine S2 V6.5
  Digital Devices DVBCT V6.1
  Digital Devices Octopus V3
  Mystique SaTiX-S2 V3

  All these changes are taken from the official driver package by Digital
  Devices.
  http://download.digital-devices.de/download/linux/

  [m.chehab@samsung.com: Fixed whitespace mangling]
  Signed-off-by: Christopher Reimer
  Tested-by: "D. Herrendoerfer"

  Signed-off-by: Mauro Carvalho Chehab

  Christopher Reimer

  2014-07-27 02:00:01 +0800  

12 Mar, 2014

1 commit

• cdcb12e78   [media] ddbridge: remove unneeded an NULL check ... Browse Code »

  Static checkers complain about the inconsistent NULL check here.

  There is an unchecked dereference of "input->fe" in the call to
  tuner_attach_tda18271() and there is a second unchecked dereference a
  couple lines later when we do:
  input->fe2->tuner_priv = input->fe->tuner_priv;

  But actually "intput->fe" can't be NULL because if demod_attach_drxk()
  fails to allocate it, then we would have return an error code.

  Signed-off-by: Dan Carpenter
  Signed-off-by: Mauro Carvalho Chehab

  Dan Carpenter

  2014-03-12 02:55:37 +0800  

31 Oct, 2013

1 commit

• 1fbf86a04   [media] ddbridge: Remove casting the return value which is a void pointer ... Browse Code »

  Casting the return value which is a void pointer is redundant.
  The conversion from void pointer to any other pointer type is
  guaranteed by the C programming language.

  Signed-off-by: Jingoo Han
  Signed-off-by: Mauro Carvalho Chehab

  Jingoo Han

  2013-10-31 14:54:12 +0800  

04 Jan, 2013

1 commit

• 4c62e9764   Drivers: media: remove __dev* attributes. ... Browse Code »

  CONFIG_HOTPLUG is going away as an option. As a result, the __dev*
  markings need to be removed.

  This change removes the use of __devinit, __devexit_p, __devinitdata,
  __devinitconst, and __devexit from these drivers.

  Based on patches originally written by Bill Pemberton, but redone by me
  in order to handle some of the coding style issues better, by hand.

  Cc: Bill Pemberton
  Cc: Mauro Carvalho Chehab
  Signed-off-by: Greg Kroah-Hartman

  Greg Kroah-Hartman

  2013-01-04 07:57:02 +0800  

12 Sep, 2012

1 commit

• f4e4a67a3   [media] ddbridge: fix error handling in module_init_ddbridge() ... Browse Code »

  If pci_register_driver() failed, resources allocated in
  ddb_class_create() are leaked. The patch fixes it
  as well as it replaces -1 with correct error code
  in ddb_class_create().

  Found by Linux Driver Verification project (linuxtesting.org).

  Signed-off-by: Alexey Khoroshilov
  Signed-off-by: Mauro Carvalho Chehab

  Alexey Khoroshilov

  2012-09-12 02:29:00 +0800  

21 Aug, 2012

1 commit

• fccea74ff   [media] Kconfig: merge all customise options into just one ... Browse Code »

  Instead of having 3 options to allow customizing the media
  sub-drivers (tuners, I2C drivers, frontends), merge all of
  them into just one.

  That simplifies the life for users, as they can just keep
  this untouched.

  Life for developers is also simpler, as there's now just
  one Kconfig item to remember, for the ancillary sub-drivers
  providing supports for chips that could change from one
  board design to another.

  Signed-off-by: Mauro Carvalho Chehab

  Mauro Carvalho Chehab

  2012-08-21 19:05:06 +0800  

14 Aug, 2012

2 commits

• ccae7af2b   [media] common: move media/common/tuners to media/tuners ... Browse Code »

  Move the tuners one level up, as the "common" directory will be used
  by drivers that are shared between more than one driver.

  Signed-off-by: Mauro Carvalho Chehab

  Mauro Carvalho Chehab

  2012-08-14 10:40:28 +0800  
• 25aee3deb   [media] Rename media/dvb as media/pci ... Browse Code »

  The remaining dvb drivers are pci, so rename them to match the
  bus.

  Signed-off-by: Mauro Carvalho Chehab

  Mauro Carvalho Chehab

  2012-08-14 10:30:06 +0800