Eric Lee / smarc-fsl-linux-kernel

28 Oct, 2016

1 commit

  • eb94cd68a   VMCI: Doorbell create and destroy fixes ... Browse Code »

    This change consists of two changes:

    1) If vmci_doorbell_create is called when neither guest nor
    host personality as been initialized, vmci_get_context_id
    will return VMCI_INVALID_ID. In that case, we should fail
    the create call.
    2) In doorbell destroy, we assume that vmci_guest_code_active()
    has the same return value on create and destroy. That may not
    be the case, so we may end up with the wrong refcount.
    Instead, destroy should check explicitly whether the doorbell
    is in the index table as an indicator of whether the guest
    code was active at create time.

    Reviewed-by: Adit Ranadive
    Signed-off-by: Jorgen Hansen
    Signed-off-by: Greg Kroah-Hartman

    Jorgen Hansen
     

31 Aug, 2016

1 commit

05 Apr, 2016

1 commit

  • 09cbfeaf1   mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros ... Browse Code »

    PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
    ago with promise that one day it will be possible to implement page
    cache with bigger chunks than PAGE_SIZE.

    This promise never materialized. And unlikely will.

    We have many places where PAGE_CACHE_SIZE assumed to be equal to
    PAGE_SIZE. And it's constant source of confusion on whether
    PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
    especially on the border between fs and mm.

    Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
    breakage to be doable.

    Let's stop pretending that pages in page cache are special. They are
    not.

    The changes are pretty straight-forward:

    - << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> ;

    - >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> ;

    - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};

    - page_cache_get() -> get_page();

    - page_cache_release() -> put_page();

    This patch contains automated changes generated with coccinelle using
    script below. For some reason, coccinelle doesn't patch header files.
    I've called spatch for them manually.

    The only adjustment after coccinelle is revert of changes to
    PAGE_CAHCE_ALIGN definition: we are going to drop it later.

    There are few places in the code where coccinelle didn't reach. I'll
    fix them manually in a separate patch. Comments and documentation also
    will be addressed with the separate patch.

    virtual patch

    @@
    expression E;
    @@
    - E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
    + E

    @@
    expression E;
    @@
    - E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
    + E

    @@
    @@
    - PAGE_CACHE_SHIFT
    + PAGE_SHIFT

    @@
    @@
    - PAGE_CACHE_SIZE
    + PAGE_SIZE

    @@
    @@
    - PAGE_CACHE_MASK
    + PAGE_MASK

    @@
    expression E;
    @@
    - PAGE_CACHE_ALIGN(E)
    + PAGE_ALIGN(E)

    @@
    expression E;
    @@
    - page_cache_get(E)
    + get_page(E)

    @@
    expression E;
    @@
    - page_cache_release(E)
    + put_page(E)

    Signed-off-by: Kirill A. Shutemov
    Acked-by: Michal Hocko
    Signed-off-by: Linus Torvalds

    Kirill A. Shutemov
     

08 Feb, 2016

1 commit

  • f42a0fd13   VMCI: Use 32bit atomics for queue headers on X86_32 ... Browse Code »

    This change restricts the reading and setting of the head and tail
    pointers on 32bit X86 to 32bit for both correctness and
    performance reasons. On uniprocessor X86_32, the atomic64_read
    may be implemented as a non-locked cmpxchg8b. This may result in
    updates to the pointers done by the VMCI device being overwritten.
    On MP systems, there is no such correctness issue, but using 32bit
    atomics avoids the overhead of the locked 64bit operation. All this
    is safe because the queue size on 32bit systems will never exceed
    a 32bit value.

    Reviewed-by: Thomas Hellstrom
    Signed-off-by: Jorgen Hansen
    Signed-off-by: Greg Kroah-Hartman

    Jorgen Hansen
     

21 Sep, 2015

1 commit

06 Aug, 2015

1 commit

  • f368ed608   char: make misc_deregister a void function ... Browse Code »

    With well over 200+ users of this api, there are a mere 12 users that
    actually checked the return value of this function. And all of them
    really didn't do anything with that information as the system or module
    was shutting down no matter what.

    So stop pretending like it matters, and just return void from
    misc_deregister(). If something goes wrong in the call, you will get a
    WARNING splat in the syslog so you know how to fix up your driver.
    Other than that, there's nothing that can go wrong.

    Cc: Alasdair Kergon
    Cc: Neil Brown
    Cc: Oleg Drokin
    Cc: Andreas Dilger
    Cc: "Michael S. Tsirkin"
    Cc: Wim Van Sebroeck
    Cc: Christine Caulfield
    Cc: David Teigland
    Cc: Mark Fasheh
    Acked-by: Joel Becker
    Acked-by: Alexandre Belloni
    Acked-by: Alessandro Zummo
    Acked-by: Mike Snitzer
    Signed-off-by: Greg Kroah-Hartman

    Greg Kroah-Hartman
     

25 Mar, 2015

3 commits

  • aa6467f19   VMCI: Guard against overflow in queue pair allocation ... Browse Code »

    The current maximum size of a queue in a queue pair is 128 MB. If
    we increase that in the future, the queue pair allocation routines
    may run into overflow issues. This change adds additional checks
    to guard against this.

    Acked-by: Andy King
    Reported-by: Dan Carpenter
    Signed-off-by: Jorgen Hansen
    Signed-off-by: Greg Kroah-Hartman

    Jorgen Hansen
     
  • 74b5c297f   VMCI: Check userland-provided datagram size ... Browse Code »

    Ensure that the size filled in by userland in the datagram header
    matches the size of the buffer passed down in the IOCTL. Note that we
    account for the size of the header itself in the check.

    Acked-by: Jorgen Hansen
    Acked-by: Aditya Sarwade
    Signed-off-by: Andy King
    Reported-by: David Ramos
    Signed-off-by: Greg Kroah-Hartman

    Andy King
     
  • bf1361211   drivers/vmw_vmci: Show correct get_user_pages_fast upon failure ... Browse Code »

    As of 240ddd495a9 (vmw_vmci: Convert driver to use get_user_pages_fast())
    we no longer user get_user_pages(), thus update the warning.

    Also convert to pr_debug, which is a more appropriate level of logging.

    Signed-off-by: Davidlohr Bueso
    Signed-off-by: Greg Kroah-Hartman

    Davidlohr Bueso
     

16 Feb, 2015

1 commit

  • 4ba63072b   Merge tag 'char-misc-3.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc ... Browse Code »

    Pull char / misc patches from Greg KH:
    "Here's the big char/misc driver update for 3.20-rc1.

    Lots of little things in here, all described in the changelog.
    Nothing major or unusual, except maybe the binder selinux stuff, which
    was all acked by the proper selinux people and they thought it best to
    come through this tree.

    All of this has been in linux-next with no reported issues for a while"

    * tag 'char-misc-3.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (90 commits)
    coresight: fix function etm_writel_cp14() parameter order
    coresight-etm: remove check for unknown Kconfig macro
    coresight: fixing CPU hwid lookup in device tree
    coresight: remove the unnecessary function coresight_is_bit_set()
    coresight: fix the debug AMBA bus name
    coresight: remove the extra spaces
    coresight: fix the link between orphan connection and newly added device
    coresight: remove the unnecessary replicator property
    coresight: fix the replicator subtype value
    pdfdocs: Fix 'make pdfdocs' failure for 'uio-howto.tmpl'
    mcb: Fix error path of mcb_pci_probe
    virtio/console: verify device has config space
    ti-st: clean up data types (fix harmless memory corruption)
    mei: me: release hw from reset only during the reset flow
    mei: mask interrupt set bit on clean reset bit
    extcon: max77693: Constify struct regmap_config
    extcon: adc-jack: Release IIO channel on driver remove
    extcon: Remove duplicated include from extcon-class.c
    Drivers: hv: vmbus: hv_process_timer_expiration() can be static
    Drivers: hv: vmbus: serialize Offer and Rescind offer
    ...

    Linus Torvalds
     

04 Feb, 2015

1 commit

26 Jan, 2015

1 commit

  • a1d88436d   VMCI: Fix two UVA mapping bugs ... Browse Code »

    (this is a resend of this patch. Originally sent last year, but post
    appears to have been lost)

    This change fixes two bugs in the VMCI host driver related to mapping
    the notify boolean from user space into kernel space:
    - the actual UVA was rounded up to the next page boundary - resulting
    in memory corruption in the calling process whenever notifications
    would be signalled. This has been fixed by just removing the
    PAGE_ALIGN part, since get_user_pages_fast can figure this out on
    its own
    - the mapped page wasn't stored anywhere, so it wasn't unmapped and
    put back when a VMCI context was destroyed. Fixed this by
    remembering the page.

    Acked-by: Andy King
    Acked-by: Darius Davis
    Signed-off-by: Jorgen Hansen
    Signed-off-by: Greg Kroah-Hartman

    Jorgen Hansen
     

10 Dec, 2014

1 commit

10 Oct, 2014

1 commit

  • 80213c03c   Merge tag 'pci-v3.18-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci ... Browse Code »

    Pull PCI updates from Bjorn Helgaas:
    "The interesting things here are:

    - Turn on Config Request Retry Status Software Visibility. This
    caused hangs last time, but we included a fix this time.
    - Rework PCI device configuration to use _HPP/_HPX more aggressively
    - Allow PCI devices to be put into D3cold during system suspend
    - Add arm64 PCI support
    - Add APM X-Gene host bridge driver
    - Add TI Keystone host bridge driver
    - Add Xilinx AXI host bridge driver

    More detailed summary:

    Enumeration
    - Check Vendor ID only for Config Request Retry Status (Rajat Jain)
    - Enable Config Request Retry Status when supported (Rajat Jain)
    - Add generic domain handling (Catalin Marinas)
    - Generate uppercase hex for modalias interface class (Ricardo Ribalda Delgado)

    Resource management
    - Add missing MEM_64 mask in pci_assign_unassigned_bridge_resources() (Yinghai Lu)
    - Increase IBM ipr SAS Crocodile BARs to at least system page size (Douglas Lehr)

    PCI device hotplug
    - Prevent NULL dereference during pciehp probe (Andreas Noever)
    - Move _HPP & _HPX handling into core (Bjorn Helgaas)
    - Apply _HPP to PCIe devices as well as PCI (Bjorn Helgaas)
    - Apply _HPP/_HPX to display devices (Bjorn Helgaas)
    - Preserve SERR & PARITY settings when applying _HPP/_HPX (Bjorn Helgaas)
    - Preserve MPS and MRRS settings when applying _HPP/_HPX (Bjorn Helgaas)
    - Apply _HPP/_HPX to all devices, not just hot-added ones (Bjorn Helgaas)
    - Fix wait time in pciehp timeout message (Yinghai Lu)
    - Add more pciehp Slot Control debug output (Yinghai Lu)
    - Stop disabling pciehp notifications during init (Yinghai Lu)

    MSI
    - Remove arch_msi_check_device() (Alexander Gordeev)
    - Rename pci_msi_check_device() to pci_msi_supported() (Alexander Gordeev)
    - Move D0 check into pci_msi_check_device() (Alexander Gordeev)
    - Remove unused kobject from struct msi_desc (Yijing Wang)
    - Remove "pos" from the struct msi_desc msi_attrib (Yijing Wang)
    - Add "msi_bus" sysfs MSI/MSI-X control for endpoints (Yijing Wang)
    - Use __get_cached_msi_msg() instead of get_cached_msi_msg() (Yijing Wang)
    - Use __read_msi_msg() instead of read_msi_msg() (Yijing Wang)
    - Use __write_msi_msg() instead of write_msi_msg() (Yijing Wang)

    Power management
    - Drop unused runtime PM support code for PCIe ports (Rafael J. Wysocki)
    - Allow PCI devices to be put into D3cold during system suspend (Rafael J. Wysocki)

    AER
    - Add additional AER error strings (Gong Chen)
    - Make standalone includable (Thierry Reding)

    Virtualization
    - Add ACS quirk for Solarflare SFC9120 & SFC9140 (Alex Williamson)
    - Add ACS quirk for Intel 10G NICs (Alex Williamson)
    - Add ACS quirk for AMD A88X southbridge (Marti Raudsepp)
    - Remove unused pci_find_upstream_pcie_bridge(), pci_get_dma_source() (Alex Williamson)
    - Add device flag helpers (Ethan Zhao)
    - Assume all Mellanox devices have broken INTx masking (Gavin Shan)

    Generic host bridge driver
    - Fix ioport_map() for !CONFIG_GENERIC_IOMAP (Liviu Dudau)
    - Add pci_register_io_range() and pci_pio_to_address() (Liviu Dudau)
    - Define PCI_IOBASE as the base of virtual PCI IO space (Liviu Dudau)
    - Fix the conversion of IO ranges into IO resources (Liviu Dudau)
    - Add pci_get_new_domain_nr() and of_get_pci_domain_nr() (Liviu Dudau)
    - Add support for parsing PCI host bridge resources from DT (Liviu Dudau)
    - Add pci_remap_iospace() to map bus I/O resources (Liviu Dudau)
    - Add arm64 architectural support for PCI (Liviu Dudau)

    APM X-Gene
    - Add APM X-Gene PCIe driver (Tanmay Inamdar)
    - Add arm64 DT APM X-Gene PCIe device tree nodes (Tanmay Inamdar)

    Freescale i.MX6
    - Probe in module_init(), not fs_initcall() (Lucas Stach)
    - Delay enabling reference clock for SS until it stabilizes (Tim Harvey)

    Marvell MVEBU
    - Fix uninitialized variable in mvebu_get_tgt_attr() (Thomas Petazzoni)

    NVIDIA Tegra
    - Make sure the PCIe PLL is really reset (Eric Yuen)
    - Add error path tegra_msi_teardown_irq() cleanup (Jisheng Zhang)
    - Fix extended configuration space mapping (Peter Daifuku)
    - Implement resource hierarchy (Thierry Reding)
    - Clear CLKREQ# enable on port disable (Thierry Reding)
    - Add Tegra124 support (Thierry Reding)

    ST Microelectronics SPEAr13xx
    - Pass config resource through reg property (Pratyush Anand)

    Synopsys DesignWare
    - Use NULL instead of false (Fabio Estevam)
    - Parse bus-range property from devicetree (Lucas Stach)
    - Use pci_create_root_bus() instead of pci_scan_root_bus() (Lucas Stach)
    - Remove pci_assign_unassigned_resources() (Lucas Stach)
    - Check private_data validity in single place (Lucas Stach)
    - Setup and clear exactly one MSI at a time (Lucas Stach)
    - Remove open-coded bitmap operations (Lucas Stach)
    - Fix configuration base address when using 'reg' (Minghuan Lian)
    - Fix IO resource end address calculation (Minghuan Lian)
    - Rename get_msi_data() to get_msi_addr() (Minghuan Lian)
    - Add get_msi_data() to pcie_host_ops (Minghuan Lian)
    - Add support for v3.65 hardware (Murali Karicheri)
    - Fold struct pcie_port_info into struct pcie_port (Pratyush Anand)

    TI Keystone
    - Add TI Keystone PCIe driver (Murali Karicheri)
    - Limit MRSS for all downstream devices (Murali Karicheri)
    - Assume controller is already in RC mode (Murali Karicheri)
    - Set device ID based on SoC to support multiple ports (Murali Karicheri)

    Xilinx AXI
    - Add Xilinx AXI PCIe driver (Srikanth Thokala)
    - Fix xilinx_pcie_assign_msi() return value test (Dan Carpenter)

    Miscellaneous
    - Clean up whitespace (Quentin Lambert)
    - Remove assignments from "if" conditions (Quentin Lambert)
    - Move PCI_VENDOR_ID_VMWARE to pci_ids.h (Francesco Ruggeri)
    - x86: Mark DMI tables as initialization data (Mathias Krause)
    - x86: Move __init annotation to the correct place (Mathias Krause)
    - x86: Mark constants of pci_mmcfg_nvidia_mcp55() as __initconst (Mathias Krause)
    - x86: Constify pci_mmcfg_probes[] array (Mathias Krause)
    - x86: Mark PCI BIOS initialization code as such (Mathias Krause)
    - Parenthesize PCI_DEVID and PCI_VPD_LRDT_ID parameters (Megan Kamiya)
    - Remove unnecessary variable in pci_add_dynid() (Tobias Klauser)"

    * tag 'pci-v3.18-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci: (109 commits)
    arm64: dts: Add APM X-Gene PCIe device tree nodes
    PCI: Add ACS quirk for AMD A88X southbridge devices
    PCI: xgene: Add APM X-Gene PCIe driver
    PCI: designware: Remove open-coded bitmap operations
    PCI/MSI: Remove unnecessary temporary variable
    PCI/MSI: Use __write_msi_msg() instead of write_msi_msg()
    MSI/powerpc: Use __read_msi_msg() instead of read_msi_msg()
    PCI/MSI: Use __get_cached_msi_msg() instead of get_cached_msi_msg()
    PCI/MSI: Add "msi_bus" sysfs MSI/MSI-X control for endpoints
    PCI/MSI: Remove "pos" from the struct msi_desc msi_attrib
    PCI/MSI: Remove unused kobject from struct msi_desc
    PCI/MSI: Rename pci_msi_check_device() to pci_msi_supported()
    PCI/MSI: Move D0 check into pci_msi_check_device()
    PCI/MSI: Remove arch_msi_check_device()
    irqchip: armada-370-xp: Remove arch_msi_check_device()
    PCI/MSI/PPC: Remove arch_msi_check_device()
    arm64: Add architectural support for PCI
    PCI: Add pci_remap_iospace() to map bus I/O resources
    of/pci: Add support for parsing PCI host bridge resources from DT
    of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr()
    ...

    Conflicts:
    arch/arm64/boot/dts/apm-storm.dtsi

    Linus Torvalds
     

25 Sep, 2014

1 commit

  • 94e57fea6   PCI: Move PCI_VENDOR_ID_VMWARE to pci_ids.h ... Browse Code »

    Move PCI_VENDOR_ID_VMWARE from device-specific files to pci_ids.h.
    It is useful to always have access to it, especially when accessing
    subsystem_vendor_id on emulated devices.

    [bhelgaas: keep pci_ids.h sorted and use lower-case hex]
    Signed-off-by: Francesco Ruggeri
    Signed-off-by: Bjorn Helgaas

    Francesco Ruggeri
     

24 Sep, 2014

1 commit

19 Jul, 2014

1 commit

01 Mar, 2014

1 commit

  • e0117521e   vmw_vmci: Use pci_enable_msix_exact() instead of pci_enable_msix() ... Browse Code »

    As result of deprecation of MSI-X/MSI enablement functions
    pci_enable_msix() and pci_enable_msi_block() all drivers
    using these two interfaces need to be updated to use the
    new pci_enable_msi_range() or pci_enable_msi_exact()
    and pci_enable_msix_range() or pci_enable_msix_exact()
    interfaces.

    Signed-off-by: Alexander Gordeev
    Cc: Greg Kroah-Hartman
    Cc: Andy King
    Cc: Dmitry Torokhov
    Cc: linux-pci@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman

    Alexander Gordeev
     

10 Jan, 2014

1 commit

06 Oct, 2013

1 commit

  • 240ddd495   vmw_vmci: Convert driver to use get_user_pages_fast() ... Browse Code »

    Convert vmci_host_setup_notify() and qp_host_get_user_memory() to use
    get_user_pages_fast() instead of get_user_pages(). Note that
    qp_host_get_user_memory() was using mmap_sem for writing without an
    apparent reason.

    CC: Arnd Bergmann
    Signed-off-by: Jan Kara
    Signed-off-by: Greg Kroah-Hartman

    Jan Kara
     

27 Sep, 2013

1 commit

28 Aug, 2013

2 commits

  • 6d6dfb4f4   VMCI: Add support for virtual IOMMU ... Browse Code »

    This patch adds support for virtual IOMMU to the vmci module. We switch
    to DMA consistent mappings for guest queuepair and doorbell pages that
    are passed to the device. We still allocate each page individually,
    since there's no guarantee that we'll get a contiguous block of physical
    for an entire queuepair (especially since we allow up to 128 MiB!).

    Also made the split between guest and host in the kernelIf struct much
    clearer. Now it's obvious which fields are which.

    Acked-by: George Zhang
    Acked-by: Aditya Sarwade
    Signed-off-by: Andy King
    Signed-off-by: Greg Kroah-Hartman

    Andy King
     
  • 45412befe   VMCI: Remove non-blocking/pinned queuepair support ... Browse Code »

    We added this for a special case that doesn't exist on Linux. Remove
    the non-blocking/pinned queuepair code and simplify the driver in
    preparation for adding virtual IOMMU support.

    Acked-by: Aditya Sarwade
    Signed-off-by: Andy King
    Signed-off-by: Greg Kroah-Hartman

    Andy King
     

20 May, 2013

1 commit

  • d2f83e907   Hoist memcpy_fromiovec/memcpy_toiovec into lib/ ... Browse Code »

    ERROR: "memcpy_fromiovec" [drivers/vhost/vhost_scsi.ko] undefined!

    That function is only present with CONFIG_NET. Turns out that
    crypto/algif_skcipher.c also uses that outside net, but it actually
    needs sockets anyway.

    In addition, commit 6d4f0139d642c45411a47879325891ce2a7c164a added
    CONFIG_NET dependency to CONFIG_VMCI for memcpy_toiovec, so hoist
    that function and revert that commit too.

    socket.h already includes uio.h, so no callers need updating; trying
    only broke things fo x86_64 randconfig (thanks Fengguang!).

    Reported-by: Randy Dunlap
    Acked-by: David S. Miller
    Acked-by: Michael S. Tsirkin
    Signed-off-by: Rusty Russell

    Rusty Russell
     

04 Apr, 2013

1 commit

  • 6d4f0139d   misc/vmw_vmci: Add dependency on CONFIG_NET ... Browse Code »

    Building the vmw_vmci driver with CONFIG_NET undefined results in:

    drivers/built-in.o: In function `__qp_memcpy_from_queue.isra.13':
    vmci_queue_pair.c:(.text+0x1671a8): undefined reference to `memcpy_toiovec'
    drivers/built-in.o: In function `__qp_memcpy_to_queue.isra.14':
    vmci_queue_pair.c:(.text+0x167341): undefined reference to `memcpy_fromiovec'
    make[1]: [vmlinux] Error 1 (ignored)

    since memcpy_toiovec and memcpy_fromiovec are defined in the networking code.
    Add the missing dependency.

    Signed-off-by: Guenter Roeck
    Acked-by: Randy Dunlap
    Signed-off-by: Greg Kroah-Hartman

    Guenter Roeck
     

16 Mar, 2013

1 commit

  • 347e0899b   VMCI: Fix process-to-process DRGAMs. ... Browse Code »

    When sending between processes, we always schedule a work item. Our work info
    struct has the message embedded in the middle, which means that we end up
    overwriting subsequent fields when we copy the (variable-length) message into
    it. Move it to the end of the struct.

    Acked-by: Dmitry Torokhov
    Signed-off-by: Andy King
    Signed-off-by: Greg Kroah-Hartman

    Andy King
     

28 Feb, 2013

1 commit

  • b67bfe0d4   hlist: drop the node parameter from iterators ... Browse Code »

    I'm not sure why, but the hlist for each entry iterators were conceived

    list_for_each_entry(pos, head, member)

    The hlist ones were greedy and wanted an extra parameter:

    hlist_for_each_entry(tpos, pos, head, member)

    Why did they need an extra pos parameter? I'm not quite sure. Not only
    they don't really need it, it also prevents the iterator from looking
    exactly like the list iterator, which is unfortunate.

    Besides the semantic patch, there was some manual work required:

    - Fix up the actual hlist iterators in linux/list.h
    - Fix up the declaration of other iterators based on the hlist ones.
    - A very small amount of places were using the 'node' parameter, this
    was modified to use 'obj->member' instead.
    - Coccinelle didn't handle the hlist_for_each_entry_safe iterator
    properly, so those had to be fixed up manually.

    The semantic patch which is mostly the work of Peter Senna Tschudin is here:

    @@
    iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;

    type T;
    expression a,c,d,e;
    identifier b;
    statement S;
    @@

    -T b;

    [akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
    [akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
    [akpm@linux-foundation.org: checkpatch fixes]
    [akpm@linux-foundation.org: fix warnings]
    [akpm@linux-foudnation.org: redo intrusive kvm changes]
    Tested-by: Peter Senna Tschudin
    Acked-by: Paul E. McKenney
    Signed-off-by: Sasha Levin
    Cc: Wu Fengguang
    Cc: Marcelo Tosatti
    Cc: Gleb Natapov
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sasha Levin
     

26 Jan, 2013

1 commit

  • f6dcf8e74   drivers, vmci: Fix build error ... Browse Code »

    We can't rely on vmalloc.h being included by other included files because
    under some configs it is possible for the build to fail:

    drivers/misc/vmw_vmci/vmci_queue_pair.c: In function 'qp_free_queue':
    drivers/misc/vmw_vmci/vmci_queue_pair.c:270: error: implicit declaration of function 'vunmap'
    drivers/misc/vmw_vmci/vmci_queue_pair.c:277: error: implicit declaration of function 'vfree'
    drivers/misc/vmw_vmci/vmci_queue_pair.c: In function 'qp_alloc_queue':
    drivers/misc/vmw_vmci/vmci_queue_pair.c:302: error: implicit declaration of function 'vmalloc'
    drivers/misc/vmw_vmci/vmci_queue_pair.c:302: warning: assignment makes pointer from integer without a cast
    drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: implicit declaration of function 'vmap'
    drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: 'VM_MAP' undeclared (first use in this function)
    drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: (Each undeclared identifier is reported only once
    drivers/misc/vmw_vmci/vmci_queue_pair.c:324: error: for each function it appears in.)
    drivers/misc/vmw_vmci/vmci_queue_pair.c: In function 'qp_host_map_queues':
    drivers/misc/vmw_vmci/vmci_queue_pair.c:843: error: 'VM_MAP' undeclared (first use in this function)

    Fix the build by directly including vmalloc.h.

    Signed-off-by: David Rientjes
    Cc: George Zhang
    Cc: Andy King
    Cc: Dmitry Torokhov
    Signed-off-by: Greg Kroah-Hartman

    David Rientjes
     

23 Jan, 2013

1 commit

  • 5a19b7897   VMCI: Fix broken context ID retrieval ... Browse Code »

    I'm an idiot. The context ID can be a really large unsigned number, which
    means it'll appear negative as an int. So actually the right fix here is just
    to set it regardless of the returned value (but only for this particular
    hypercall; normally we would check it).

    Acked-by: Dmitry Torokhov
    Signed-off-by: Andy King
    Signed-off-by: Greg Kroah-Hartman

    Andy King
     

18 Jan, 2013

6 commits

09 Jan, 2013

5 commits