08 Oct, 2016

1 commit

• 776482cd8   wan/fsl_ucc_hdlc: Fix size used in dma_free_coherent() ... Browse Code »

  Size used with 'dma_alloc_coherent()' and 'dma_free_coherent()' should be
  consistent.
  Here, the size of a pointer is used in dma_alloc... and the size of the
  pointed structure is used in dma_free...

  This has been spotted with coccinelle, using the following script:
  ////////////////////
  @r@
  expression x0, x1, y0, y1, z0, z1, t0, t1, ret;
  @@

  * ret = dma_alloc_coherent(x0, y0, z0, t0);
  ...
  * dma_free_coherent(x1, y1, ret, t1);

  @script:python@
  y0 << r.y0;
  y1 << r.y1;

  @@
  if y1.find(y0) == -1:
  print "WARNING: sizes look different: '%s' vs '%s'" % (y0, y1)
  ////////////////////

  Signed-off-by: Christophe JAILLET
  Signed-off-by: David S. Miller

  Christophe Jaillet

  2016-10-08 12:04:48 +0800  

29 Aug, 2016

1 commit

• 24a24d07d   wan/fsl_ucc_hdlc: fix spelling mistake "prameter" -> "parameter" ... Browse Code »

  Trivial fix to spelling mistake in dev_err message.

  Signed-off-by: Colin Ian King
  Signed-off-by: David S. Miller

  Colin Ian King

  2016-08-29 11:41:46 +0800  

02 Aug, 2016

1 commit

• 8c57a3a7f   wan/fsl_ucc_hdlc: avoid possible NULL pointer dereference ... Browse Code »

  All assignments to components of priv should only
  occur after the check if prif is NULL.

  Signed-off-by: Heinrich Schuchardt
  Signed-off-by: David S. Miller

  xypron.glpk@gmx.de

  2016-08-02 04:32:52 +0800  

21 Jul, 2016

2 commits

• 459421cc8   wan/fsl_ucc_hdlc: use module_platform_driver to simplify the code ... Browse Code »

  module_platform_driver() makes the code simpler by eliminating
  boilerplate code.

  Signed-off-by: Wei Yongjun
  Signed-off-by: David S. Miller

  Wei Yongjun

  2016-07-21 05:46:00 +0800  
• 9d5658e65   wan/fsl_ucc_hdlc: remove .owner field for driver ... Browse Code »

  Remove .owner field if calls are used which set it automatically.

  Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

  Signed-off-by: Wei Yongjun
  Signed-off-by: David S. Miller

  Wei Yongjun

  2016-07-21 05:46:00 +0800  

17 Jul, 2016

2 commits

• 1efb597d8   wan/fsl_ucc_hdlc: rewrite error handling to make it clearer ... Browse Code »

  It was used err_xxx for labeled statement, it is
  not easy to understand, now use free_xxx for labeled
  statement.

  Signed-off-by: Zhao Qiang
  Signed-off-by: David S. Miller

  Zhao Qiang

  2016-07-17 11:22:02 +0800  
• 18210510c   wan/fsl_ucc_hdlc: remove reduplicative freed memory 'uhdlc_priv' ... Browse Code »

  'uhdlc_priv' has freed twice, drop the first one.

  Signed-off-by: Zhao Qiang
  Signed-off-by: David S. Miller

  Zhao Qiang

  2016-07-17 11:22:02 +0800  

16 Jul, 2016

1 commit

• 2f43b9bee   wan/fsl_ucc_hdlc: info leak in uhdlc_ioctl() ... Browse Code »

  There is a 2 byte struct whole after line.loopback so we need to clear
  that out to avoid disclosing stack information.

  Fixes: c19b6d246a35 ('drivers/net: support hdlc function for QE-UCC')
  Signed-off-by: Dan Carpenter
  Signed-off-by: David S. Miller

  Dan Carpenter

  2016-07-16 02:42:42 +0800  

08 Jun, 2016

1 commit

• c19b6d246   drivers/net: support hdlc function for QE-UCC ... Browse Code »

  The driver add hdlc support for Freescale QUICC Engine.
  It support NMSI and TSA mode.

  Signed-off-by: Zhao Qiang
  Signed-off-by: David S. Miller

  Zhao Qiang

  2016-06-08 06:56:31 +0800