30 Apr, 2016
1 commit
-
Current driver checks for NULL return from aac_fib_alloc_tag, but it not
possible for it to return NULL.Fixed by: Remove all the checks for NULL returns from aac_fib_alloc_tag
Suggested-by: Tomas Henzl
Signed-off-by: Raghava Aditya Renukunta
Signed-off-by: Martin K. Petersen
24 Feb, 2016
1 commit
-
The method to allocate and free FIB's in the present code utilizes
spinlocks. Multiple IO's have to wait on the spinlock to acquire or free
fibs creating a performance bottleneck.An alternative solution would be to use block layer tags to keep track
of the fibs allocated and freed. To this end aac_fib_alloc_tag was
created to utilize the blk layer tags to plug into the Fib pool.These
functions are used exclusively in the IO path. 8 fibs are reserved for
the use of AIF management software and utilize the previous spinlock
based implementations.Signed-off-by: Raghava Aditya Renukunta
Reviewed-by: Shane Seymour
Reviewed-by: Johannes Thumshirn
Reviewed-by: Tomas Henzl
Signed-off-by: Martin K. Petersen
10 Nov, 2015
3 commits
-
If 'IsFastPath' bit is set, then response path assumes no error and skips
error check.Reviewed-by: Murthy Bhat
Reviewed-by: Karthikeya Sunkesula
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley -
This change always sets MSI interrupt mode for series-6 controller.
Reviewed-by: Tomas Henzl
Reviewed-by: Murthy Bhat
Reviewed-by: Karthikeya Sunkesula
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley -
Driver sends the right size of the response buffer.
Reviewed-by: Tomas Henzl
Reviewed-by: Murthy Bhat
Reviewed-by: Karthikeya Sunkesula
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley
10 Apr, 2015
3 commits
-
Signed-off-by: Mahesh Rajashekhara
Reviewed-by: Hannes Reinecke
Reviewed-by: Murthy Bhat
Signed-off-by: James Bottomley -
Signed-off-by: Mahesh Rajashekhara
Reviewed-by: Hannes Reinecke
Reviewed-by: Murthy Bhat
Signed-off-by: James Bottomley -
Also fix up a name truncation problem
Signed-off-by: Mahesh Rajashekhara
Reviewed-by: Hannes Reinecke
Reviewed-by: Murthy Bhat
Signed-off-by: James Bottomley
25 Nov, 2014
1 commit
-
SPC-3 defines SERVICE ACTION IN(12) and SERVICE ACTION IN(16).
So rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16 to be
consistent with SPC and to allow for better distinction.Signed-off-by: Hannes Reinecke
Tested-by: Robert Elliott
Reviewed-by: Robert Elliott
Signed-off-by: Christoph Hellwig
27 Nov, 2012
1 commit
-
This patch handles SCSI dma mapping failure case. Reporting error code to the
upper layer instead of BUG_ON().Signed-off-by: Mahesh Rajashekhara
Reviewed-by: Tomas Henzl
Signed-off-by: James Bottomley
20 Jul, 2012
1 commit
-
- Series 7 Async. (performance) mode support added
- New scatter/gather list format for Series 7
- Driver converts s/g list to a firmware suitable list for best performance on
Series 7, this can be disabled with driver parameter "aac_convert_sgl" for
testing purposes
- New container read/write command structure for Series 7
- Fast response support for the SCSI pass-through path added
- Async. status response buffer changesSigned-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley
19 Feb, 2012
1 commit
-
Added Sync. mode to support Series 7/8/9 controller families: This is a
compatibility mode for all these controller families. The Async. (Performance)
mode can be changed in the future. First Async. mode version added for Series
7; Controller parameter aac_sync_mode addedSigned-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley
01 Nov, 2011
1 commit
-
The module.h header was implicitly present everywhere, so files
with no explicit include of the module infrastructure would build
anyway. We are now removing the implicit include, and so we need
to call out the module.h file that we need explicitly.Signed-off-by: Paul Gortmaker
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
24 Mar, 2011
1 commit
-
Added new hardware device 0x28b interface for PMC-Sierra's SRC based
controller family.- new src.c file for 0x28b specific functions
- new XPORT header required
- sync. command interface: doorbell bits shifted (SRC_ODR_SHIFT, SRC_IDR_SHIFT)
- async. Interface: different inbound queue handling, no outbound I2O
queue available, using doorbell ("PmDoorBellResponseSent") and
response buffer on the host ("host_rrq") for status
- changed AIF (adapter initiated FIBs) interface: "DoorBellAifPending"
bit to inform about pending AIF, "AifRequest" command to read AIF,
"NoMoreAifDataAvailable" to mark the end of the AIFsSigned-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley
17 May, 2010
3 commits
-
Problem description:
--------------------The issue reported by one of the customer was able to read LBA beyond
the array reported size with "sg_read" utility. If N is the last block
address reported, then should not be able to read past N,
i.e. N+1. But in their case, reported last LBA=143134719. So should
not have been able to read with LBA=143134720, but it is read without
failure, which means reported size to the OS is not correct and is
less than the actual last block address.Solution:
---------Firmware layer exposes lesser container capacity than the actual
one. It exposes [Actual size - Spitfire space(10MB)] to the OS, IO's
to the 10MB should be prohibited from the Linux driver. Driver checks
LBA boundary, if its greater than the array reported size then sets
sensekey to HARDWARE_ERROR and sends the notification to the MID
layer.Signed-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley -
There are two conditions for ATA pass thru command that falls into
'SRB_STATUS_ERROR' condition.1. When the "CC" bit is set by the host in ATA pass-through CDB
- Even for the successful completion, SCSI target shall generate
check condition.- Driver returns a result code of SAM_STAT_CHECK_CONDITION, with a
driver byte of DID_OK to the mid layer.Below is the snippet of existing code which fills a result code
of SAM_STAT_CHECK_CONDITION:***********************************
if (le32_to_cpu(srbreply->scsi_status) == SAM_STAT_CHECK_CONDITION) {
int len;
scsicmd->result |= SAM_STAT_CHECK_CONDITION;
..........
************************************2. When the "CC" bit is reset by the host and if SCSI target generates
a check condition when an error occurs.- Driver returns a result code of SAM_STAT_CHECK_CONDITION, with a
driver byte of DID_ERROR to the mid layer.Signed-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley -
The default driver setting is "expose_physicals=0", which means raw
physical drives are not exposed to OS. If the user wants to expose
connected physical drives, enable "expose_physicals" module parameter.
With the new JBOD firmware, physical drives are not available for
"expose_physicals>0". In function "aac_expose_phy_device", modified
to reset the appropriate bit in the first byte of inquiry data. This
fix exposes the connected physical drives.Signed-off-by: Mahesh Rajashekhara
Signed-off-by: James Bottomley
18 Jan, 2010
1 commit
-
These particular problems were reported by Cisco and SAP and customers
as well. Cisco reported on RHEL4 U6 and SAP reported on SLES9 SP4 and
SLES10 SP2. We added these fixes on RHEL4 U6 and gave a private build
to IBM and Cisco. Cisco and IBM tested it for more than 15 days and
they reported that they did not see the issue so far. Before the fix,
Cisco used to see the issue within 5 days. We generated a patch for
SLES9 SP4 and SLES10 SP2 and submitted to Novell. Novell applied the
patch and gave a test build to SAP. SAP tested and reported that the
build is working properly.We also tested in our lab using the tools "dishogsync", which is IO
stress tool and the tool was provided by Cisco.Issue1: File System going into read-only mode
Root cause: The driver tends to not free the memory (FIB) when the
management request exits prematurely. The accumulation of such
un-freed memory causes the driver to fail to allocate anymore memory
(FIB) and hence return 0x70000 value to the upper layer, which puts
the file system into read only mode.Fix details: The fix makes sure to free the memory (FIB) even if the
request exits prematurely hence ensuring the driver wouldn't run out
of memory (FIBs).Issue2: False Raid Alert occurs
When the Physical Drives and Logical drives are reported as deleted or
added, even though there is no change done on the systemRoot cause: Driver IOCTLs is signaled with EINTR while waiting on
response from the lower layers. Returning "EINTR" will never initiate
internal retry.Fix details: The issue was fixed by replacing "EINTR" with
"ERESTARTSYS" for mid-layer retries.Signed-off-by: Penchala Narasimha Reddy
Signed-off-by: James Bottomley
14 Apr, 2009
1 commit
-
This is the second go through of the old DMA_nBIT_MASK macro,and there're not
so many of them left,so I put them into one patch.I hope this is the last round.
After this the definition of the old DMA_nBIT_MASK macro could be removed.Signed-off-by: Yang Hongyang
Cc: Russell King
Cc: Tony Lindgren
Cc: "David S. Miller"
Cc: James Bottomley
Cc: Greg KH
Cc: Takashi Iwai
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
07 Apr, 2009
2 commits
-
Replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32)
Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
Replace all DMA_64BIT_MASK macro with DMA_BIT_MASK(64)
Signed-off-by: Yang Hongyang
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
03 Apr, 2009
1 commit
-
changes:
- set aac_cache=2 as default value to avoid performance problem
(Novell bugzilla #469922)- Dell/PERC controller boot problem fixed (RedHat bugzilla #457552)
- WWN flag added to fix SLES10 SP1/SP2 drive detection problems
- 64-bit support changes
- DECLARE_PCI_DEVICE_TABLE macro added
- controller type changes
Signed-off-by: Achim Leubner
Signed-off-by: James Bottomley
30 Dec, 2008
1 commit
-
Signed-off-by: Alan Cox
Signed-off-by: James Bottomley
09 Oct, 2008
1 commit
-
Right now SCSI and others do their own command timeout handling.
Move those bits to the block layer.Instead of having a timer per command, we try to be a bit more clever
and simply have one per-queue. This avoids the overhead of having to
tear down and setup a timer for each command, so it will result in a lot
less timer fiddling.Signed-off-by: Mike Anderson
Signed-off-by: Jens Axboe
03 May, 2008
1 commit
-
For firmware that supports the feature(s), add the ability to start or
stop an array using the associated SCSI commands, to automatically
manage the spin-up of an array on new I/O reporting back the
appropriate check conditions and actions in cooperation with the
normal timeout mechanisms and enable the blackout period management in
the Firmware associated with the background spin-down of the arrays
when the Firmware times out and deems the arrays as idle.Signed-off-by: Mark Salyzyn
Signed-off-by: James Bottomley
22 Apr, 2008
1 commit
-
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-2.6: (36 commits)
SCSI: convert struct class_device to struct device
DRM: remove unused dev_class
IB: rename "dev" to "srp_dev" in srp_host structure
IB: convert struct class_device to struct device
memstick: convert struct class_device to struct device
driver core: replace remaining __FUNCTION__ occurrences
sysfs: refill attribute buffer when reading from offset 0
PM: Remove destroy_suspended_device()
Firmware: add iSCSI iBFT Support
PM: Remove legacy PM (fix)
Kobject: Replace list_for_each() with list_for_each_entry().
SYSFS: Explicitly include required header file slab.h.
Driver core: make device_is_registered() work for class devices
PM: Convert wakeup flag accessors to inline functions
PM: Make wakeup flags available whenever CONFIG_PM is set
PM: Fix misuse of wakeup flag accessors in serial core
Driver core: Call device_pm_add() after bus_add_device() in device_add()
PM: Handle device registrations during suspend/resume
block: send disk "change" event for rescan_partitions()
sysdev: detect multiple driver registrations
...Fixed trivial conflict in include/linux/memory.h due to semaphore header
file change (made irrelevant by the change to mutex).
20 Apr, 2008
1 commit
-
It's big, but there doesn't seem to be a way to split it up smaller...
Signed-off-by: Tony Jones
Signed-off-by: Kay Sievers
Cc: Roland Dreier
Cc: Sean Hefty
Cc: Hal Rosenstock
Cc: James Bottomley
Signed-off-by: Greg Kroah-Hartman
19 Apr, 2008
1 commit
-
None of these files use any of the functionality promised by
asm/semaphore.h. It's possible that they rely on it dragging in some
unrelated header file, but I can't build all these files, so we'll have
fix any build failures as they come up.Signed-off-by: Matthew Wilcox
16 Apr, 2008
1 commit
-
Describe check_reset parameter with its name (and not its value)
Signed-off-by: Paul Bolle
Acked-by: Mark Salyzyn
Signed-off-by: James Bottomley
08 Apr, 2008
2 commits
-
This replaces aac_internal_transfer with scsi_sg_copy_to/from_buffer.
Signed-off-by: FUJITA Tomonori
Acked-by: Mark Salyzyn
Signed-off-by: James Bottomley -
When aacraid spoofs READ_CAPACITY_16, it assumes that the data length
in the sg list is equal to allocation length in cdb. But sg can put
any value in scb so the driver needs to check both the data length in
the sg list and allocation length in cdb.If allocation length is larger than the response length that the
driver expects, it clears the data buffer in the sg list to zero but
it doesn't need to do. Just setting resid is fine.Signed-off-by: FUJITA Tomonori
Acked-by: Mark Salyzyn
Signed-off-by: James Bottomley
12 Feb, 2008
2 commits
-
The Adapter's Ignore Reset flag and insmod parameter boolean polarity
is incorrect in the driver.Signed-off-by: Mark Salyzyn
Signed-off-by: James Bottomley -
Added support for MSI utilizing the aacraid.msi=1 parameter. This
patch adds some localized or like-minded janitor fixes. Since the
default is disabled, there is no impact on the code paths unless the
customer wishes to experiment with the MSI performance.Signed-off-by: Mark Salyzyn
Signed-off-by: James Bottomley
08 Feb, 2008
1 commit
-
Luben Tuikov [mailto:ltuikov@yahoo.com] sez:
> Just as in your case and Tony's case, which I presume
> uses the same RAID firmware vendor, it would've
> probably been better if the RAID firmware vendor
> fixed the firmware to not set the VALID bit if the
> INFORMATION field is not valid.Point taken regarding the aacraid driver. Dropped the VALID bit, and
then did some cleanup/simplification of the set_sense procedure and
the associated parameters. Mike did some preliminary tests when the
VALID bit was dropped before the 'Re: [PATCH] [SCSI] sd: make error
handling more robust' patches came on the scene. The change in the
SCSI subsystem does make this enclosed aacraid patch unnecessary, so
this aacraid patch is merely post battle ground cleanup. If the
simplification is an issue, repugnant, too much for a back-port to the
stable trees or clouds the point, this patch could be happily
distilled down to:diff -ru a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
--- a/drivers/scsi/aacraid/aachba.c 2008-02-06 16:26:45.834938955 -0500
+++ b/drivers/scsi/aacraid/aachba.c 2008-02-06 16:32:01.109035329 -0500
@@ -865,7 +865,7 @@
u32 residue)
{
- sense_buf[0] = 0xF0; /* Sense data valid, err code 70h (current error) */
+ sense_buf[0] = 0x70; /* Sense data invalid, err code 70h (current error) */
sense_buf[1] = 0; /* Segment number, always zero */if (incorrect_length) {
Signed-off-by: Mark Salyzyn
Signed-off-by: James Bottomley
24 Jan, 2008
5 commits
-
The cards being added are supported in a limited sense already through
family matching, but we needed to add some functionality to the driver
to expose selectively the physical drives. These Physical drives are
specifically marked to not be part of any array and thus are declared
JBODs (Just a Bunch Of Drives) for generic SCSI access.We report that this is the second patch in a set of two, but merely
depends on the stand-alone functionality of the first patch which adds
in that case the ability to report a driver feature flag via sysfs. We
leverage that functionality by reporting that this driver now supports
this new JBOD feature for the controller so that the array management
applications may react accordingly and guide the user as they manage
the controller.Signed-off-by: Mark Salyzyn
Signed-off-by: James Bottomley -
I was amazed at how much embedded space was present in the aacraid
driver source files. Just selected five files from the set to clean up
for now and the attached patch swelled to 73K in size!- Removed trailing space or tabs
- Removed spaces embedded within tabs
- Replaced leading 8 spaces with tabs
- Removed spaces before )
- Removed ClusterCommand as it was unused (noticed it as one triggered by above)
- Replaced scsi_status comparison with 0x02, to compare against SAM_STATUS_CHECK_CONDITION.
- Replaced a long series of spaces with tabs
- Replaced some simple if...defined() with ifdef/ifndefSigned-off-by: Mark Salyzyn
Signed-off-by: James Bottomley -
The promised min_t() cleanup. Purely cosmetic.
Signed-off-by: Mark Salyzyn
Signed-off-by: James Bottomley -
This replaces sizeof sense_buffer with SCSI_SENSE_BUFFERSIZE in
several LLDs. It's a preparation for the future changes to remove
sense_buffer array in scsi_cmnd structure.Signed-off-by: FUJITA Tomonori
Signed-off-by: James Bottomley -
Due to an internal limit associated with the AdapterTypeText field,
SMC required a product ID that overloaded the combined vendor and
product ID. A decision was made to ship the SMC products without a
vendor string dropping the defacto space that used to delineate vendor
and product to boot. To correct this, we needed to adjust the code in
the driver to parse out the vendor and product strings for the
adapter. We match of 'AOC' in the AdapterTypeText, if so we set the
vendor to SMC and place the entire AdapterTypeText into the product
field.This only affects the cosmetic presentation of the Adapter vendor and
product in the logs and in sysfs.Signed-off-by: Mark Salyzyn
Signed-off-by: James Bottomley
