17 Sep, 2015

1 commit

  • SPI core validates both bits_per_word and speed_hz transfer parameters and
    defaults to spi->bits_per_word and spi->max_speed_hz in case these per
    transfer parameters are not set.

    This allows to remove a few if statements around per transfer bits_per_word
    and speed_hz tests as they evaluate always to true.

    Also defaulting word_len to 8 is needless since spi_setup() has already
    made sure spi->bits_per_word is 8 in case it is not set.

    Signed-off-by: Jarkko Nikula
    Signed-off-by: Mark Brown

    Jarkko Nikula
     

17 Mar, 2015

1 commit

  • Currently the omap100k driver uses prepare and unprepare transfer hardware
    to enable and disable clocks for the IP block. Since these functions are
    called along with runtime PM and end up duplicating its functionality in a
    less flexible fashion we are trying to phase them out so convert this
    driver to do runtime PM instead.

    While doing so add missing error handling and remove a redundant NULL
    assignment.

    Signed-off-by: Mark Brown

    Mark Brown
     

22 Dec, 2014

1 commit


20 Oct, 2014

1 commit


17 Aug, 2014

1 commit

  • Remove unused definition which cause the following warnings

    drivers/spi/spi-omap-100k.c:73:0: warning: "WRITE" redefined [enabled by default]
    include/linux/fs.h:193:0: note: this is the location of the previous definition
    drivers/spi/spi-omap-100k.c:74:0: warning: "READ" redefined [enabled by default]
    include/linux/fs.h:192:0: note: this is the location of the previous definition

    Signed-off-by: Nick Krause
    Acked-by: Geert Uytterhoeven
    Signed-off-by: Mark Brown

    Nick Krause
     

06 Jun, 2014

1 commit


29 Mar, 2014

1 commit


05 Mar, 2014

1 commit

  • Fix the following checkpatch issues.

    ERROR: space prohibited after that open parenthesis '('
    ERROR: space required before the open parenthesis '('
    ERROR: trailing statements should be on next line
    ERROR: space required after that ',' (ctx:VxV)
    ERROR: spaces required around that '-=' (ctx:VxV)
    WARNING: sizeof *cs should be sizeof(*cs)

    Signed-off-by: Jingoo Han
    Signed-off-by: Mark Brown

    Jingoo Han
     

10 Feb, 2014

3 commits


03 Dec, 2013

1 commit

  • Commit [8074cf06: use devm_spi_register_master()] removed the last
    bit of omap1_spi100k_remove function that had side effects. After
    call to spi_unregister_master was removed, the function consisted
    of:

    2. call to platform_get_drvdata whose return value was only used in:
    2. call to spi_master_get_devdata whose return value was not used,
    3. an if statement checking if zero was not zero, and
    4. call to platform_get_resource whose return value was not used.

    Ah, yes, and of course, final return 0. ;)

    Since omap1_spi100k_remove no longer does anything, it can be
    safely removed.

    Signed-off-by: Michal Nazarewicz
    Signed-off-by: Mark Brown

    Michal Nazarewicz
     

26 Sep, 2013

1 commit


01 Sep, 2013

1 commit


29 Aug, 2013

1 commit


15 Jul, 2013

7 commits


26 Jun, 2013

1 commit


30 May, 2013

1 commit


23 May, 2013

1 commit

  • Use the wrapper functions for getting and setting the driver data using
    platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
    so we can directly pass a struct platform_device.

    Signed-off-by: Jingoo Han
    Signed-off-by: Mark Brown

    Jingoo Han
     

05 Feb, 2013

1 commit

  • Some of the spi driver module remove hooks were annotated with __exit
    and referenced with __exit_p(). Presumably these were supposed to be
    __devinit, __devexit and __devexit_p() since __init/__exit for a
    probe/remove hook has never been correct. They also got missed during
    the big __devinit/__devexit purge since they didn't match the pattern.
    Remove then now to be rid of it.

    v2: purge __init also

    Reported-by: Arnd Bergmann
    [Arnd set a patch cleaning up one, and then I found more]
    Signed-off-by: Grant Likely

    Grant Likely
     

08 Dec, 2012

1 commit

  • CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Bill Pemberton has done most of the legwork on this series. I've used
    his script to purge the attributes from the drivers/gpio tree.

    Reported-by: Bill Pemberton
    Signed-off-by: Grant Likely

    Grant Likely
     

23 Sep, 2012

1 commit


06 Jun, 2011

1 commit

  • Sort the SPI makefile and enforce the naming convention spi_*.c for
    spi drivers.

    This change also rolls the contents of atmel_spi.h into the .c file
    since there is only one user of that particular include file.

    v2: - Use 'spi-' prefix instead of 'spi_' to match what seems to be
    be the predominant pattern for subsystem prefixes.
    - Clean up filenames in Kconfig and header comment blocks

    Signed-off-by: Grant Likely
    Acked-by: Wolfram Sang
    Acked-by: Linus Walleij

    Grant Likely