26 Jan, 2017

1 commit

  • commit eadf081146ec327d6fbbb6aff28e3d9aac329dc6 upstream.

    A bugfix removed the two callers of s5p_cec_runtime_suspend
    and s5p_cec_runtime_resume, leading to the return of a harmless
    warning that I had previously fixed in commit aee8937089b1
    ("[media] s5p_cec: mark suspend/resume as __maybe_unused"):

    staging/media/s5p-cec/s5p_cec.c:234:12: error: ‘s5p_cec_runtime_suspend’ defined but not used [-Werror=unused-function]
    staging/media/s5p-cec/s5p_cec.c:242:12: error: ‘s5p_cec_runtime_resume’ defined but not used [-Werror=unused-function]

    This adds the __maybe_unused annotations to the function that
    were not removed and that are now unused when CONFIG_PM
    is disabled.

    Fixes: 57b978ada073 ("[media] s5p-cec: fix system and runtime PM integration")

    Signed-off-by: Arnd Bergmann
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab
    Signed-off-by: Greg Kroah-Hartman

    Arnd Bergmann
     

12 Jan, 2017

1 commit


06 Nov, 2016

1 commit

  • Pull media fixes from Mauro Carvalho Chehab:
    "A series of fixup patches meant to fix the usage of DMA on stack, plus
    one warning fixup"

    * tag 'media/v4.9-3' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (32 commits)
    [media] radio-bcm2048: don't ignore errors
    [media] pctv452e: fix semicolon.cocci warnings
    [media] flexcop-usb: don't use stack for DMA
    [media] stk-webcam: don't use stack for DMA
    [media] s2255drv: don't use stack for DMA
    [media] cpia2_usb: don't use stack for DMA
    [media] digitv: handle error code on RC query
    [media] dw2102: return error if su3000_power_ctrl() fails
    [media] nova-t-usb2: handle error code on RC query
    [media] technisat-usb2: use DMA buffers for I2C transfers
    [media] pctv452e: don't call BUG_ON() on non-fatal error
    [media] pctv452e: don't do DMA on stack
    [media] nova-t-usb2: don't do DMA on stack
    [media] gp8psk: don't go past the buffer size
    [media] gp8psk: don't do DMA on stack
    [media] dtv5100: don't do DMA on stack
    [media] dtt200u: handle USB control message errors
    [media] dtt200u: don't do DMA on stack
    [media] dtt200u-fe: handle errors on USB control messages
    [media] dtt200u-fe: don't do DMA on stack
    ...

    Linus Torvalds
     

17 Oct, 2016

1 commit

  • Remove this warning:

    drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_set_rds_no_lock':
    drivers/staging/media/bcm2048/radio-bcm2048.c:467:6: warning: variable 'err' set but not used [-Wunused-but-set-variable]
    int err;
    ^~~

    By returning the error code.

    Signed-off-by: Mauro Carvalho Chehab

    Mauro Carvalho Chehab
     

12 Oct, 2016

1 commit

  • Pull media updates from Mauro Carvalho Chehab:

    - Documentation improvements: conversion of all non-DocBook documents
    to Sphinx and lots of fixes to the uAPI media book

    - New PCI driver for Techwell TW5864 media grabber boards

    - New SoC driver for ATMEL Image Sensor Controller

    - Removal of some obsolete SoC drivers (s5p-tv driver and soc_camera
    drivers)

    - Addition of ST CEC driver

    - Lots of drivers fixes, improvements and additions

    * tag 'media/v4.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media: (464 commits)
    [media] ttusb_dec: avoid the risk of go past buffer
    [media] cx23885: Fix some smatch warnings
    [media] si2165: switch to regmap
    [media] si2165: use i2c_client->dev instead of i2c_adapter->dev for logging
    [media] si2165: Remove legacy attach
    [media] cx231xx: attach si2165 driver via i2c_client
    [media] cx231xx: Prepare for attaching new style i2c_client DVB demod drivers
    [media] cx23885: attach si2165 driver via i2c_client
    [media] si2165: support i2c_client attach
    [media] si2165: avoid division by zero
    [media] rcar-vin: add R-Car gen2 fallback compatibility string
    [media] lgdt3306a: remove 20*50 msec unnecessary timeout
    [media] cx25821: Remove deprecated create_singlethread_workqueue
    [media] cx25821: Drop Freeing of Workqueue
    [media] cxd2841er: force 8MHz bandwidth for DVB-C if specified bw not supported
    [media] redrat3: hardware-specific parameters
    [media] redrat3: remove hw_timeout member
    [media] cxd2841er: BER and SNR reading for ISDB-T
    [media] dvb-usb: avoid link error with dib3000m{b,c|
    [media] dvb-usb: split out common parts of dibusb
    ...

    Linus Torvalds
     

06 Oct, 2016

2 commits

  • Pull staging and IIO updates from Greg KH:
    "Here is the big staging and IIO driver pull request for 4.9-rc1.

    There are a lot of patches in here, the majority due to the
    drivers/staging/greybus/ subsystem being merged in with full
    development history that went back a few years, in order to preserve
    the work that those developers did over time.

    Lots and lots of tiny cleanups happened in the tree as well, due to
    the Outreachy application process and lots of other developers showing
    up for the first time to clean code up. Along with those changes, we
    deleted a wireless driver, and added a raspberrypi driver (currently
    marked broken), and lots of new iio drivers.

    Overall the tree still shrunk with more lines removed than added,
    about 10 thousand lines removed in total. Full details are in the very
    long shortlog below.

    All of this has been in the linux-next tree with no issues. There will
    be some merge problems with other subsystem trees, but those are all
    minor problems and shouldn't be hard to work out when they happen
    (MAINTAINERS and some lustre build problems with the IB tree)"

    And furter from me asking for clarification about greybus:
    "Right now there is a phone from Motorola shipping with this code (a
    slightly older version, but the same tree), so even though Ara is not
    alive in the same form, the functionality is happening. We are working
    with the developers of that phone to merge the newer stuff in with
    their fork so they can use the upstream version in future versions of
    their phone product line.

    Toshiba has at least one chip shipping in their catalog that
    needs/uses this protocol over a Unipro link, and rumor has it that
    there might be more in the future.

    There are also other users of the greybus protocols, there is a talk
    next week at ELC that shows how it is being used across a network
    connection to control a device, and previous ELC talks have showed the
    protocol stack being used over USB to drive embedded Linux boards.
    I've also talked to some people who are starting to work to add a host
    controller driver to control arduinos as the greybus PHY protocols are
    very useful to control a serial/i2c/spio/whatever device across a
    random physical link, as it is a way to have a self-describing device
    be attached to a host without needing manual configuration.

    So yes, people are using it, and there is still the chance that it
    will show up in a phone/laptop/tablet/whatever from Google in the
    future as well, the tech isn't dead, even if the original large phone
    project happens to be"

    * tag 'staging-4.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (3703 commits)
    Staging: fbtft: Fix bug in fbtft-core
    staging: rtl8188eu: fix double unlock error in rtw_resume_process()
    staging:r8188eu: remove GEN_MLME_EXT_HANDLER macro
    staging:r8188eu: remove GEN_DRV_CMD_HANDLER macro
    staging:r8188eu: remove GEN_EVT_CODE macro
    staging:r8188eu: remove GEN_CMD_CODE macro
    staging:r8188eu: remove pkt_newalloc member of the recv_buf structure
    staging:r8188eu: remove rtw_handle_dualmac declaration
    staging:r8188eu: remove (RGTRY|BSSID)_(OFT|SZ) macros
    staging:r8188eu: change rtl8188e_process_phy_info function argument type
    Staging: fsl-mc: Remove blank lines
    Staging: fsl-mc: Fix unaligned * in block comments
    Staging: comedi: Align the * in block comments
    Staging : ks7010 : Fix block comments warninig
    Staging: vt6655: Remove explicit NULL comparison using Coccinelle
    staging: rtl8188eu: core: rtw_xmit: Use macros instead of constants
    staging: rtl8188eu: core: rtw_xmit: Move constant of the right side
    staging: dgnc: Fix lines longer than 80 characters
    Staging: dgnc: constify attribute_group structures
    Staging: most: hdm-dim2: constify attribute_group structures
    ...

    Linus Torvalds
     
  • Linux 4.8

    * tag 'v4.8': (1761 commits)
    Linux 4.8
    ARM: 8618/1: decompressor: reset ttbcr fields to use TTBR0 on ARMv7
    MIPS: CM: Fix mips_cm_max_vp_width for non-MT kernels on MT systems
    include/linux/property.h: fix typo/compile error
    ocfs2: fix deadlock on mmapped page in ocfs2_write_begin_nolock()
    mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page()
    MAINTAINERS: Switch to kernel.org email address for Javi Merino
    x86/entry/64: Fix context tracking state warning when load_gs_index fails
    x86/boot: Initialize FPU and X86_FEATURE_ALWAYS even if we don't have CPUID
    x86/vdso: Fix building on big endian host
    x86/boot: Fix another __read_cr4() case on 486
    sctp: fix the issue sctp_diag uses lock_sock in rcu_read_lock
    sctp: change to check peer prsctp_capable when using prsctp polices
    sctp: remove prsctp_param from sctp_chunk
    sctp: move sent_count to the memory hole in sctp_chunk
    tg3: Avoid NULL pointer dereference in tg3_io_error_detected()
    x86/init: Fix cr4_init_shadow() on CR4-less machines
    MIPS: Fix detection of unsupported highmem with cache aliases
    MIPS: Malta: Fix IOCU disable switch read for MIPS64
    MIPS: Fix BUILD_ROLLBACK_PROLOGUE for microMIPS
    ...

    Mauro Carvalho Chehab
     

02 Oct, 2016

1 commit


27 Sep, 2016

7 commits


22 Sep, 2016

3 commits


20 Sep, 2016

7 commits

  • Use dev_info() instead of printk(). Majority of the conversion was done
    previously on this commit:
    011b2aa [media] staging/media: Use dev_ printks in cxd2099/cxd2099.[ch]

    Signed-off-by: Eva Rachel Retuya
    Signed-off-by: Greg Kroah-Hartman

    Eva Rachel Retuya
     
  • Instead of storing the return value into a variable and then returning it, we
    can club the two into a single return statement. This change was made using
    the following semantic patch by Coccinelle:

    @@
    local idexpression ret;
    expression e;
    @@

    -ret =
    +return
    e;
    -return ret;

    Signed-off-by: Rehas Sachdeva
    Signed-off-by: Greg Kroah-Hartman

    Rehas Sachdeva
     
  • Instead of storing the return value into a variable and then returning it, we
    can club the two into a single return statement. This change was made using
    the following semantic patch by Coccinelle:

    @@
    local idexpression ret;
    expression e;
    @@

    -ret =
    +return
    e;
    -return ret;

    Signed-off-by: Rehas Sachdeva
    Signed-off-by: Greg Kroah-Hartman

    Rehas Sachdeva
     
  • We get 1 warning when building kernel with W=1:
    drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for 'omap4iss_flush' [-Wmissing-prototypes]

    In fact, this function is only used in the file in which it is
    declared and don't need a declaration, but can be made static.
    so this patch marks this function with 'static'.

    Signed-off-by: Baoyou Xie
    Acked-by: Arnd Bergmann
    Acked-by: Laurent Pinchart
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Baoyou Xie
     
  • Building with -Wmaybe-uninitialized reveals the use on an uninitialized
    variable containing the physical address of the device whenever
    firmware before version 2 is used:

    drivers/staging/media/pulse8-cec/pulse8-cec.c: In function 'pulse8_connect':
    drivers/staging/media/pulse8-cec/pulse8-cec.c:447:2: error: 'pa' may be used uninitialized in this function [-Werror=maybe-uninitialized]

    This sets the address to CEC_PHYS_ADDR_INVALID in this case, so we don't
    try to write back the uninitialized data to the device.

    Fixes: e28a6c8b3fcc ("[media] pulse8-cec: sync configuration with adapter")

    Signed-off-by: Arnd Bergmann
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Arnd Bergmann
     
  • MEDIA_CEC is no longer a tristate option, so the user can't actually
    choose M. Whether the code is built-in or built as a module is
    decided somewhere else.

    Fixes: 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency problems")

    Signed-off-by: Jean Delvare
    Cc: Arnd Bergmann
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Jean Delvare
     
  • In addition to setting the ACK mask, also set the logical address mask
    setting in the dongle. This (and not the ACK mask) is persisted for
    use in autonomous mode.

    The logical address mask to use is deduced from the primary device type
    in adap->log_addrs.

    Signed-off-by: Johan Fjeldtvedt
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Johan Fjeldtvedt
     

19 Sep, 2016

1 commit

  • This patch implement CEC driver for stih4xx platform.
    Driver compliance has been test with cec-ctl and
    cec-compliance tools.

    Signed-off-by: Benjamin Gaignard
    Acked-by: Peter Griffin
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Benjamin Gaignard
     

18 Sep, 2016

2 commits


16 Sep, 2016

6 commits


12 Sep, 2016

1 commit

  • pulse8-cec.c: In function 'pulse8_connect':
    pulse8-cec.c:447:2: warning: 'pa' may be used uninitialized in this function [-Wmaybe-uninitialized]
    cec_s_phys_addr(pulse8->adap, pa, false);
    ^
    pulse8-cec.c:609:6: note: 'pa' was declared here
    u16 pa;
    ^

    As far as I can tell, this can't actually happen. Still, it is better to just
    initialize it.

    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Hans Verkuil
     

09 Sep, 2016

3 commits


07 Sep, 2016

2 commits

  • Fix some small things:
    - clean up setup function
    - use MSGEND instead of 0xfe
    - don't assign "return value" from cec_phys_addr to err,
    it has return type void.

    Signed-off-by: Johan Fjeldtvedt
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Johan Fjeldtvedt
     
  • When the configuration is changed, they are also written to the adapter.
    This allows the adapter to continue operating in autonomous mode with
    the same settings when it is disconnected from the driver (typically by
    going into suspend). For adapters with firmware version 2 or greater, the
    settings are also persisted in EEPROM.

    A new module parameter is added to optionally also use the configuration
    already present in the adapter when it is connected. This option is
    enabled by default.

    When a new configuration is written, the autonomous mode is
    automatically enabled. When the device is unconfigured, autonomous mode
    is disabled.

    Signed-off-by: Johan Fjeldtvedt
    Signed-off-by: Hans Verkuil
    Signed-off-by: Mauro Carvalho Chehab

    Johan Fjeldtvedt