27 Sep, 2016
1 commit
-
This removes checkpatch.pl warnings:
WARNING: Block comments should align the * on each line
Signed-off-by: Grygorii Maistrenko
Signed-off-by: Greg Kroah-Hartman
13 Sep, 2016
1 commit
-
checkpatch generates a warning for no blank line after struct
declaration. Inserted a new line.Signed-off-by: Gargi Sharma
Signed-off-by: Greg Kroah-Hartman
21 Aug, 2016
5 commits
-
Merge several structures for statistics to one structure and remove
unnecessary union nesting.Signed-off-by: Lino Sanfilippo
Signed-off-by: Greg Kroah-Hartman -
Remove the volatile specifiers of struct slic_shmem. Furthermore store the
bus addresses for the isr pointer, link status and statistics separately
and access the upper and lower word of these addresses by means of
[lower|upper]_32_bits(). By doing this take the endianness into account.Signed-off-by: Lino Sanfilippo
Signed-off-by: Greg Kroah-Hartman -
Use the new register accessors that use offsets instead of the slic_regs
structure to read/write registers. Since not longer needed remove the
structure completley.Signed-off-by: Lino Sanfilippo
Signed-off-by: Greg Kroah-Hartman -
Introduce the function slic_flush_write() which reads from the HOSTID
register and can be used to avoid PCI write posting. Use the function at
several critical places in the code.Signed-off-by: Lino Sanfilippo
Signed-off-by: Greg Kroah-Hartman -
Introduce accessor functions that read and write registers by using a
register offset.
This is in preparation to replace the register addressing by means of the
slic_regs struct with an addressing by means of offsets.Signed-off-by: Lino Sanfilippo
Signed-off-by: Greg Kroah-Hartman
07 Feb, 2016
1 commit
-
ethtool_ops has attributes in sub struct ethtool_coalesce that
correspond to the parameters intagg_delay and dynamic_intagg. It is
preferable to set these properties with ethtool rather than
module_param, so create these attributes in adapter and set them using
ethtool_coalesce's rx_coalesce_usecs and rx_use_adaptive_coalesce.
(Outlined in TODO file)Signed-off-by: Kevin Wern
Signed-off-by: Greg Kroah-Hartman
27 Oct, 2015
3 commits
-
This patch fixes the checkpatch.pl warnings:
WARNING: Block comments use * on subsequent lines
WARNING: Block comments use a trailing */ on a separate lineSigned-off-by: Amarjargal Gundjalam
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the checkpatch.pl check:
CHECK: spaces preferred around that ‘’
Signed-off-by: Amarjargal Gundjalam
Signed-off-by: Greg Kroah-Hartman -
This patch fixes the checkpatch.pl check:
CHECK: Please don't use multiple blank lines
Signed-off-by: Amarjargal Gundjalam
Signed-off-by: Greg Kroah-Hartman
18 Jun, 2015
1 commit
-
This patch removes a couple of ununsed MACRO's in this header file
Signed-off-by: Hari Prasath Gujulan Elango
Signed-off-by: Greg Kroah-Hartman
14 May, 2015
2 commits
-
curaddrupper caches the last written upper 32-bits of a dma address
(the device has one register for the upper 32-bits of all dma
address registers). The problem is, not every dma address write
checks and sets curaddrupper. This causes the driver to occasionally
not write the upper 32-bits of a dma address to the device when it
really should.I've seen this manifest particularly when the driver is trying to
read config data from the device (RCONFIG) in order to checksum the
device's eeprom. Since the device writes its config data to the
wrong DMA address the driver reads 0 as the eeprom size and the
eeprom checksum fails.This patch fixes the issue by removing curaddrupper and always
writing the upper 32-bits of dma addresses.Signed-off-by: David Matlack
Signed-off-by: Greg Kroah-Hartman -
As per TODO. This commit introduces no functional changes.
Signed-off-by: David Matlack
Signed-off-by: Greg Kroah-Hartman
26 May, 2014
1 commit
-
Remove the private linked list of netdev structs. This list isn't
being used anyway.This patch has no noticable effect.
Signed-off-by: David Matlack
Signed-off-by: Greg Kroah-Hartman
23 May, 2014
3 commits
-
Remove fail_on_bad_eeprom, which was always 0 and thus being used
to ignore incorrect checksumming. This means devices with corrupt
eeprom will now cause the driver to fail.Since fail_on_bad_eeprom was the last member in use of struct
slic_reg_params, remove that struct altogether.Signed-off-by: David Matlack
Signed-off-by: Greg Kroah-Hartman -
As per the TODO file, this patch removes the gratuitous debug
infrastructure. As an extra incentive for removing this code,
the debugfs files are not cleaned up properly. For example, if
register_netdev() fails in slic_entry_probe() then all debugfs
files get left behind, even after the driver module is unloaded.
Touching these files quickly leads to an oops.Signed-off-by: David Matlack
Signed-off-by: Greg Kroah-Hartman -
This patch removes two fields from the private "struct adapter".
Specifically,memorybase duplicate of slic_regs
memorylength written once and never read. This field is trivially
computed with pci_resource_len if it's ever needed in
the future.Signed-off-by: David Matlack
Signed-off-by: Greg Kroah-Hartman
28 Feb, 2014
1 commit
-
This patch fixes the following checkpatch.pl issues in slic.h:
WARNING: line over 80 charactersSigned-off-by: Monam Agarwal
Signed-off-by: Greg Kroah-Hartman
18 Jan, 2013
1 commit
-
This fixes all instances of
"Please, no spaces at start of a new line"
"Please, no spaces before tabs"Please note that I probably got the warning names wrong,
but they should be close enough for usage here :)Additional post-commit note: There is one comment on line 230ish in slic.h
that appears to have lost it's formatting. It was fine when I was working
in Geany, but it caught my eye in the below diff. Sorry if it actually happened!Signed-off-by: Cruz Julian Bishop
Signed-off-by: Greg Kroah-Hartman
01 Sep, 2010
1 commit
-
Remove explicit arch dependencies
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
03 Aug, 2010
1 commit
-
Remove net_device_stats from the driver's private.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
09 Jul, 2010
1 commit
-
Remove defines of STATUS_XXX from header file.
Signed-off-by: Kulikov Vasiliy
Cc: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
04 Mar, 2010
1 commit
-
Use compare_ether_addr.
Signed-off-by: Denis Kirjanov
Signed-off-by: Greg Kroah-Hartman
04 Apr, 2009
4 commits
-
SLIC_GET_STATS_TIMER_ENABLED was never defined, so remove the code that
was bound by it.Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
As SLIC_DUMP_ENABLED was disabled, remove the code that it was keeping
from being built as it was not ever used. This removed a lot.Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
Don't use TRUE and FALSE, we have proper boolean types in the kernel.
Cc: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
This patch uses request_firmware() to download the firmware to the card.
Signed-off-by: Lior Dotan
Cc: Christopher Harrer
07 Jan, 2009
1 commit
-
This should make the driver use request_firmware() instead of a static
firmware.
Some obvious things are missing:
1) The unneeded header files are not removed yet. This is to keep the
patch size small.
2) The .bin files are missing so the driver doesn't have what to load.
3) Testing. None of this was tested. It does compiles OK though :)Signed-off-by: Lior Dotan
Signed-off-by: Greg Kroah-Hartman
11 Oct, 2008
2 commits
-
Major cleanups of checkpatch warnings from the slicoss driver.
From: Lior Dotan
Signed-off-by: Greg Kroah-Hartman -
This adds the Alacritech slicoss driver to the tree.
This driver is supposed to support:
Mojave cards (single port PCI Gigabit) both copper and fiber
Oasis cards (single and dual port PCI-x Gigabit) copper and fiber
Kalahari cards (dual and quad port PCI-e Gigabit) copper and fiberThe driver was acutally tested on Oasis and Kalahari cards.
TODO:
- move firmware loading to request_firmware()
- remove direct memory access of structures
- any remaining sparse and checkpatch.pl warnings
- any netdev recommended changesMany thanks to Lior Dotan for help with the cleanup
of this driver.Cc: Lior Dotan
Cc: Christopher Harrer
Signed-off-by: Greg Kroah-Hartman