27 Sep, 2016
1 commit
-
Check for cfg80211_ops structures that are only passed as the first
argument to the function wiphy_new. As this argument is constant, so
cfg80211_ops structures having this property can also be declared
constant.
Done using coccinelle:@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct cfg80211_ops i@p = {...};@ok1@
identifier r1.i;
position p;
expression e1;
@@
wiphy_new(&i@p,e1)@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct cfg80211_ops i={...};@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct cfg80211_ops i;File size before:
text data bss dec hex filename
17468 2417 14912 34797 87ed
drivers/staging/wilc1000/wilc_wfi_cfgoperations.oFile size after:
text data bss dec hex filename
18204 1681 14912 34797 87ed
drivers/staging/wilc1000/wilc_wfi_cfgoperations.oSigned-off-by: Bhumika Goyal
Signed-off-by: Greg Kroah-Hartman
21 Aug, 2016
1 commit
-
The current check for associatedsta being set to -1 to indicate it has
not been found is not working because associatedsta is initialized to
zero and will never be -1. Fix this by initializing it to ~0 and checking
for ~0 instead.Signed-off-by: Colin Ian King
Signed-off-by: Greg Kroah-Hartman
28 Jul, 2016
1 commit
-
Pull networking updates from David Miller:
1) Unified UDP encapsulation offload methods for drivers, from
Alexander Duyck.2) Make DSA binding more sane, from Andrew Lunn.
3) Support QCA9888 chips in ath10k, from Anilkumar Kolli.
4) Several workqueue usage cleanups, from Bhaktipriya Shridhar.
5) Add XDP (eXpress Data Path), essentially running BPF programs on RX
packets as soon as the device sees them, with the option to mirror
the packet on TX via the same interface. From Brenden Blanco and
others.6) Allow qdisc/class stats dumps to run lockless, from Eric Dumazet.
7) Add VLAN support to b53 and bcm_sf2, from Florian Fainelli.
8) Simplify netlink conntrack entry layout, from Florian Westphal.
9) Add ipv4 forwarding support to mlxsw spectrum driver, from Ido
Schimmel, Yotam Gigi, and Jiri Pirko.10) Add SKB array infrastructure and convert tun and macvtap over to it.
From Michael S Tsirkin and Jason Wang.11) Support qdisc packet injection in pktgen, from John Fastabend.
12) Add neighbour monitoring framework to TIPC, from Jon Paul Maloy.
13) Add NV congestion control support to TCP, from Lawrence Brakmo.
14) Add GSO support to SCTP, from Marcelo Ricardo Leitner.
15) Allow GRO and RPS to function on macsec devices, from Paolo Abeni.
16) Support MPLS over IPV4, from Simon Horman.
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next: (1622 commits)
xgene: Fix build warning with ACPI disabled.
be2net: perform temperature query in adapter regardless of its interface state
l2tp: Correctly return -EBADF from pppol2tp_getname.
net/mlx5_core/health: Remove deprecated create_singlethread_workqueue
net: ipmr/ip6mr: update lastuse on entry change
macsec: ensure rx_sa is set when validation is disabled
tipc: dump monitor attributes
tipc: add a function to get the bearer name
tipc: get monitor threshold for the cluster
tipc: make cluster size threshold for monitoring configurable
tipc: introduce constants for tipc address validation
net: neigh: disallow transition to NUD_STALE if lladdr is unchanged in neigh_update()
MAINTAINERS: xgene: Add driver and documentation path
Documentation: dtb: xgene: Add MDIO node
dtb: xgene: Add MDIO node
drivers: net: xgene: ethtool: Use phy_ethtool_gset and sset
drivers: net: xgene: Use exported functions
drivers: net: xgene: Enable MDIO driver
drivers: net: xgene: Add backward compatibility
drivers: net: phy: xgene: Add MDIO driver
...
06 Jul, 2016
1 commit
-
Beacon report radio measurement requires reporting observed BSSs
on the channels specified in the beacon request. If the measurement
mode is set to passive or active, it requires actually performing a
scan (passive or active, accordingly), and reporting the time that
the scan was started and the time each beacon/probe was received
(both in terms of TSF of the BSS of the requesting AP). If the
request mode is table, this information is optional.
In addition, the radio measurement request specifies the channel
dwell time for the measurement.In order to use scan for beacon report when the mode is active or
passive, add a parameter to scan request that specifies the
channel dwell time, and add scan start time and beacon received time
to scan results information.Supporting beacon report is required for Multi Band Operation (MBO).
Signed-off-by: Assaf Krauss
Signed-off-by: David Spinadel
Signed-off-by: Avraham Stern
Signed-off-by: Luca Coelho
Signed-off-by: Johannes Berg
26 Jun, 2016
1 commit
-
hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
which have the following element:
u8 bssid[6];pstrNetworkInfo, of type network_info, also contains an u8 array named
bssid.request->ssids is an array of cfg80211_ssid structs. Making ssid:
u8 ssid[IEEE80211_MAX_SSID_LEN];In these 3 cases the arrays are being checked against NULL, which can't
happen. Removing the checks since they will always be true.Found with smatch:
drivers/staging/wilc1000/host_interface.c:1234 Handle_RcvdNtwrkInfo() warn: this array is probably non-NULL. 'hif_drv->usr_scan_req.net_info[i].bssid'
drivers/staging/wilc1000/host_interface.c:1235 Handle_RcvdNtwrkInfo() warn: this array is probably non-NULL. 'pstrNetworkInfo->bssid'
drivers/staging/wilc1000/host_interface.c:1253 Handle_RcvdNtwrkInfo() warn: this array is probably non-NULL. 'hif_drv->usr_scan_req.net_info[hif_drv->usr_scan_req.rcvd_ch_cnt].bssid'
drivers/staging/wilc1000/host_interface.c:1254 Handle_RcvdNtwrkInfo() warn: this array is probably non-NULL. 'pstrNetworkInfo->bssid'Signed-off-by: Luis de Bethencourt
Signed-off-by: Greg Kroah-Hartman
21 May, 2016
1 commit
-
Pull staging and IIO driver updates from Greg KH:
"Here's the big staging and iio driver update for 4.7-rc1.I think we almost broke even with this release, only adding a few more
lines than we removed, which isn't bad overall given that there's a
bunch of new iio drivers added.The Lustre developers seem to have woken up from their sleep and have
been doing a great job in cleaning up the code and pruning unused or
old cruft, the filesystem is almost readable :)Other than that, just a lot of basic coding style cleanups in the
churn. All have been in linux-next for a while with no reported
issues"* tag 'staging-4.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging: (938 commits)
Staging: emxx_udc: emxx_udc: fixed coding style issue
staging/gdm724x: fix "alignment should match open parenthesis" issues
staging/gdm724x: Fix avoid CamelCase
staging: unisys: rename misleading var ii with frag
staging: unisys: visorhba: switch success handling to error handling
staging: unisys: visorhba: main path needs to flow down the left margin
staging: unisys: visorinput: handle_locking_key() simplifications
staging: unisys: visorhba: fail gracefully for thread creation failures
staging: unisys: visornic: comment restructuring and removing bad diction
staging: unisys: fix format string %Lx to %llx for u64
staging: unisys: remove unused struct members
staging: unisys: visorchannel: correct variable misspelling
staging: unisys: visorhba: replace functionlike macro with function
staging: dgnc: Need to check for NULL of ch
staging: dgnc: remove redundant condition check
staging: dgnc: fix 'line over 80 characters'
staging: dgnc: clean up the dgnc_get_modem_info()
staging: lustre: lnet: enable configuration per NI interface
staging: lustre: o2iblnd: properly set ibr_why
staging: lustre: o2iblnd: remove last of kiblnd_tunables_fini
...
04 May, 2016
1 commit
-
"mac" is an array allocated in stack without being initialized,
and will be sent out via "nla_put". The dump_station() is supposed
to initialize the mac address; otherwise, sensitive data in kernel
stack will be leaked. To fix this, copy the mac address to it.Signed-off-by: Kangjie Lu
Signed-off-by: Greg Kroah-Hartman
29 Apr, 2016
2 commits
-
This patch is adds a check routine when performed del_key().
We was find this situation while test the 'rmmod sdio'.
That is received inform a .del_key cmd from cfg80211.
If is not exist wep keys, must be ignore a wilc_remove_wep_key() function.
Thus, adds a check routine that key length of wep.Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This patch is adds a cfg80211_disconnected() when connection is lost already.
We was find this situation while test the 'rmmod sdio'.
SDIO remove function are include both remove mac_close and unregister net_device.
That is received one more a disconnect cmd from cfg80211.
Driver was already performed disconnect.
If wilc->close value was set to true, adds a call to cfg80211_disconnected().Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman
12 Apr, 2016
1 commit
-
This enum is already perfectly aliased to enum nl80211_band, and
the only reason for it is that we get IEEE80211_NUM_BANDS out of
it. There's no really good reason to not declare the number of
bands in nl80211 though, so do that and remove the cfg80211 one.Signed-off-by: Johannes Berg
30 Mar, 2016
2 commits
-
This patch replaces struct semaphore hSemScanReq with struct mutex
scan_req_lock. It is better to use mutex than semaphore.Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
struct semaphore SemHandleUpdateStats is defined but never used in this
driver, so just remove it.Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman
28 Mar, 2016
3 commits
-
This patch replaces frame_type with type of struct frame_reg.
Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This patch replaces g_struct_frame_reg with frame_reg.
Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This patch corrects warnings generated by checkpatch.pl by
removing braces from single block statements.Signed-ff-by: Roger H. Newell
Signed-off-by: Greg Kroah-Hartman
23 Mar, 2016
1 commit
-
This patch fixed the problems caused by if firmware is not started.
That is why, in nl80211 put current TX power in interface info.
If firmware is not started, this function(get_tx_power) does not work.Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman
04 Mar, 2016
1 commit
-
Remove a whitespace before parenthesis "("
Signed-off-by: Anchal Jain
Signed-off-by: Greg Kroah-Hartman
02 Mar, 2016
1 commit
-
Variables pcgroup_encrypt_val,pccipher_group,pcwpa_version,
hold different values at different stages of the execution of
connect(), however they are not being used anywhere.
Hence, the unused variables have been removed.This was done using Coccinelle.
@@ type T; identifier i; constant c; @@
-T i;Signed-off-by: Bhaktipriya Shridhar
Signed-off-by: Greg Kroah-Hartman
26 Feb, 2016
11 commits
-
This patch renames u16reason to reason to remove u16 prefix. There is no
need to use prefix to show data type.Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames struct tstrDisconnectNotifInfo to disconnect_info to
avoid camelcase.Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames u16ConnectStatus to status to avoid camelcase.
Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames u16RespIEsLen to resp_ies_len to avoid camelcase.
Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames pu8RespIEs to resp_ies to avoid camelcase.
Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames ReqIEsLen to req_ies_len to avoid camelcase.
Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames pu8ReqIEs to req_ies to avoid camelcase.
Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames au8bssid to bssid to remove au8 prefix in struct
connect_info. There is no need to use prefix to show data type of this
variable.Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This patch renames struct tstrConnectInfo to connect_info to avoid
camelcase and removes typedef.Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman -
This reverts commit 6c2ab2398b88 ("staging: wilc1000: remove spaces around '->'").
It had applied from a incorrectly commit a1b56a4c5054
("staging: wilc1000: wilc_wfi_cfgoperations.c: removes unnecessary log messages").Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This struct just wrap struct cfg_param_val. There is no other member
except struct cfg_param_val.
This patch remove struct cfg_param_attr, then struct cfg_param_val is
renamed to struct cfg_param_attr.Signed-off-by: Chaehyun Lim
Signed-off-by: Greg Kroah-Hartman
23 Feb, 2016
5 commits
-
This patch removes unnecessary log messages.
Signed-off-by: Chris Park
Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This patch removes unnecessary log messages.
And, it adds a 'break' statement in accordance with the switch-case rule.Signed-off-by: Chris Park
Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This patch removes unnecessary log messages and relate variables.
Signed-off-by: Chris Park
Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This patch removes the unnecessary log messages which is used with
the HOSTAPD_DBG tag.Signed-off-by: Chris Park
Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman -
This patch removes the error reported by smatch.
- wilc_wfi_cfgoperations.c:674 scan() error:
potential null dereference 'strHiddenNetwork.net_info'. (kmalloc returns null)Signed-off-by: Leo Kim
Signed-off-by: Greg Kroah-Hartman
21 Feb, 2016
1 commit
-
This patch removes the function WILC_WFI_update_stats as it is not used
anywhere in the kernel. Also remove its declaration from the header
file. Grepped to find the occurences.Signed-off-by: Bhumika Goyal
Signed-off-by: Greg Kroah-Hartman
20 Feb, 2016
3 commits
-
Split statement across multiple lines as the line modified is over 80
chars in length.Signed-off-by: Janani Ravichandran
Signed-off-by: Greg Kroah-Hartman -
Use kmalloc_array instead of kmalloc for arrays to prevent integer
overflows.Signed-off-by: Janani Ravichandran
Signed-off-by: Greg Kroah-Hartman -
Delete the space around '->' as it is prohibited and breaks the code.
Checkpatch found this issue.ERROR: spaces prohibited around that '->'
Signed-off-by: Eva Rachel Retuya
Signed-off-by: Greg Kroah-Hartman
16 Feb, 2016
1 commit
-
Address the following checkpatch errors:
* ERROR: do not initialise statics to false
* ERROR: do not initialise statics to 0x00Signed-off-by: Eva Rachel Retuya
Signed-off-by: Greg Kroah-Hartman
15 Feb, 2016
1 commit
-
Remove cast on void pointers. C programming language guarantees
the conversion from void pointer to any other pointer type.Coccinelle patch:
@r@
expression x;
void* e;
type T;
identifier f;
@@(
*((T *)e)
|
((T *)x)[...]
|
((T *)x)->f
|
- (T *)
e
)Signed-off-by: Alison Schofield
Signed-off-by: Greg Kroah-Hartman