31 Aug, 2016
4 commits
-
Fix 'timeout_us' parameter description.
Signed-off-by: Wei Yongjun
Signed-off-by: Greg Kroah-Hartman -
Correct pointer notations to include whitespace between
variable type and "*" character. Inserted blank line
after variable declatations at two locations.
Rearranged comparison within an if statment to have the
constant on the right-hand side.Signed-off-by: Ben Werbowyj
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
Assignment of variable count removed from within an if statment.
This was done at two locations in the file.Signed-off-by: Ben Werbowyj
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
Inserted whitespace between command and open parenthesis
at two locations. Removed new line between open brace and
command/declaration at two locations.Signed-off-by: Ben Werbowyj
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
03 Aug, 2016
3 commits
-
Commit e93762bbf681 ("w1: masters: omap_hdq: add support for 1-wire
mode") added a statement to clear the hdq_irqstatus flags in
hdq_read_byte().If the hdq reading process is scheduled slowly or interrupts are
disabled for a while the hardware read activity might already be
finished on entry of hdq_read_byte(). And hdq_isr() already has set the
hdq_irqstatus to 0x6 (can be seen in debug mode) denoting that both, the
TXCOMPLETE and RXCOMPLETE interrupts occurred in parallel.This means there is no need to wait and the hdq_read_byte() can just
read the byte from the hdq controller.By resetting hdq_irqstatus to 0 the read process is forced to be always
waiting again (because the if statement always succeeds) but the
hardware will not issue another RXCOMPLETE interrupt. This results in a
false timeout.After such a situation the hdq bus hangs.
Link: http://lkml.kernel.org/r/b724765f87ad276a69625bc19806c8c8844c4590.1469513669.git.hns@goldelico.com
Signed-off-by: H. Nikolaus Schaller
Cc: Evgeniy Polyakov
Cc: Greg Kroah-Hartman
Cc:
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
The helper macro module_w1_family can be used in module drivers that
only register a w1 driver in their module init functions. Add this
macro and use it in all applicable drivers.Link: http://lkml.kernel.org/r/20160531204313.20979-2-afd@ti.com
Signed-off-by: Andrew F. Davis
Acked-by: Evgeniy Polyakov
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds -
PLATFORM_DEVID_AUTO can be used to have the platform core assign a
unique ID instead of manually creating one with IDA. Do this in all
applicable drivers.Link: http://lkml.kernel.org/r/20160531204313.20979-1-afd@ti.com
Signed-off-by: Andrew F. Davis
Acked-by: Evgeniy Polyakov
Cc: Greg KH
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
02 May, 2016
4 commits
-
Since many temperature sensors come "preconfigured" with a lower
precision, people are stuck at that precision when running on a kernel
based device (unlike the Dallas 1Wire library for e.g. Arduino, which
supports writing the configuration/scratchpad). This patch adds write
support for the scratchpad/precision registers via w1_slave sysfs.Signed-off-by: Ben Sen
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
If kstrtoint() returns -ERANGE then "tmp" is uninitialized.
Signed-off-by: Dan Carpenter
Acked-by: Evgeniy Polaykov
Signed-off-by: Greg Kroah-Hartman -
Signed-off-by: Geert Uytterhoeven
Signed-off-by: Greg Kroah-Hartman -
This commit enables the active pullup (APU bit) by default for
the DS2482 1-Wire master.>From the DS2482 datasheet:
"The APU bit controls whether an active pullup (controlled slew-rate
transistor) or a passive pullup (Rwpu resistor) will be used to drive
a 1-Wire line from low to high. When APU = 0, active pullup is disabled
(resistor mode). Active Pullup should always be selected unless there is
only a single slave on the 1-Wire line."According to the module author, Ben Gardner:
"It doesn't look like active pullup would cause any hurt if there
is only a single slave."
And my tests with multiple and single slaves on 1-Wire bus
confirms that.This active pullup can be manually disabled using the introduced
module parameter:
active_pullup = 0Signed-off-by: Greg Kroah-Hartman
12 Feb, 2016
1 commit
-
w1_process() calls try_to_freeze(), but the thread doesn't mark itself
freezable through set_freezable(), so the try_to_freeze() call is useless.Acked-by: Evgeniy Polyakov
Signed-off-by: Jiri Kosina
Signed-off-by: Greg Kroah-Hartman
09 Feb, 2016
1 commit
-
hdq_usecount was set to zero after a successful read, so
omap_hdq_put could not properly free resources which leads
e.g. to increasing usecounts in lsmod outputSigned-off-by: Andreas Kemnade
Acked-by: Evgeniy Polyakov
Reviewed-by: Vignesh R
Signed-off-by: Greg Kroah-Hartman
06 Nov, 2015
1 commit
-
Pull power supply and reset updates from Sebastian Reichel:
- new AXP20X USB Power driver
- new Qualcomm SMBB driver
- new TPS65217 Charger driver
- BQ24257: add BQ24250/BQ24251 support
- overhaul bq27x00 battery driver, rename to bq27xxx
- misc fixes and cleanups* tag 'for-v4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply: (54 commits)
power: bq27xxx_battery: Remove unneeded dependency in Kconfig
power: bq27xxx_battery: move irq handler to i2c section
power: bq27xxx_battery: fix platform probe
twl4030_charger: add missing iio dependency
power_supply: charger-manager: add missing of_node_put
Documentation: power: bq24257: Document exported sysfs entries
power: bq24257: Add various device-specific sysfs properties
power: bq24257: Allow input current limit sysfs access
power: bq24257: Add input DPM voltage threshold setting support
power: bq24257: Add over voltage protection setting support
power: bq24257: Add SW-based approach for Power Good determination
power: bq24257: Allow manual setting of input current limit
power: bq24257: Add bit definition for temp sense enable
power: bq24257: Add basic support for bq24250/bq24251
dt: power: bq24257-charger: Cover additional devices
power: bq24257: Simplify bq24257_power_supply_init()
power: bq24257: Use managed power supply register
power: bq24257: Streamline input current limit setup
power: bq24257: Remove IRQ config through stat-gpios
power: bq27xxx_battery: fix signedness bug in bq27xxx_battery_read_health()
...
18 Oct, 2015
1 commit
-
Let's stop using legacy platform driver hooks for power management and
switch to using the standard dev_pm_ops-based hooks.Also, instead of guarding PM methods with #ifdef CONFIG_PM annotate them
as __maybe_unused as it provides better compile coverage.Signed-off-by: Dmitry Torokhov
Signed-off-by: Greg Kroah-Hartman
05 Oct, 2015
2 commits
-
This patches makes following changes to omap_hdq driver
- Enable 1-wire mode.
- Implement w1_triplet callback to facilitate search rom
procedure and auto detection of 1-wire slaves.
- Proper enabling and disabling of interrupt.
- Cleanups (formatting and return value checks).HDQ mode remains unchanged.
Signed-off-by: Vignesh R
Cc: Rob Herring
Cc: Pawel Moll
Cc: Mark Rutland
Cc: Ian Campbell
Cc: Kumar Gala
Acked-by: Evgeniy Polyakov
Cc: Jonathan Corbet
CC: Tony Lindgren
Cc: Vignesh R
Cc: NeilBrown
Cc: Fabian Frederick
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman -
Currently, memsetting and kfreeing the device is bad behaviour. The
device will have a reference count of 1 and hence can cause trouble
because it has kfree'd. Proper way to handle a failed device_register is
to call put_device right after it fails.Signed-off-by: Levente Kurusa
Acked-by: Evgeniy Polyakov
Signed-off-by: Andrew Morton
Signed-off-by: Greg Kroah-Hartman
23 Sep, 2015
2 commits
-
When initialized as a platform device the initializer must now specify
a device. An empty device name is no longer valid.Signed-off-by: Andrew F. Davis
Signed-off-by: Sebastian Reichel -
Rename functions that are used by multiple devices. New devices
have been added and the function names and driver name are no longer
general enough for the functionality they provide.Signed-off-by: Andrew F. Davis
Acked-by: Tony Lindgren
Acked-by: GUAN Xuetao
Signed-off-by: Sebastian Reichel
02 Sep, 2015
1 commit
-
Pull trivial tree updates from Jiri Kosina:
"The usual stuff from trivial tree for 4.3 (kerneldoc updates, printk()
fixes, Documentation and MAINTAINERS updates)"* 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial: (28 commits)
MAINTAINERS: update my e-mail address
mod_devicetable: add space before */
scsi: a100u2w: trivial typo in printk
i2c: Fix typo in i2c-bfin-twi.c
treewide: fix typos in comment blocks
Doc: fix trivial typo in SubmittingPatches
proportions: Spelling s/consitent/consistent/
dm: Spelling s/consitent/consistent/
aic7xxx: Fix typo in error message
pcmcia: Fix typo in locking documentation
scsi/arcmsr: Fix typos in error log
drm/nouveau/gr: Fix typo in nv10.c
[SCSI] Fix printk typos in drivers/scsi
staging: comedi: Grammar s/Enable support a/Enable support for a/
Btrfs: Spelling s/consitent/consistent/
README: GTK+ is a acronym
ASoC: omap: Fix typo in config option description
mm: tlb.c: Fix error message
ntfs: super.c: Fix error log
fix typo in Documentation/SubmittingPatches
...
07 Aug, 2015
1 commit
-
This patch fix spelling typo in matrox_w1.c
Signed-off-by: Masanari Iida
Acked-by: Evgeniy Polyakov
Signed-off-by: Jiri Kosina
06 Aug, 2015
2 commits
-
Use module_pci_driver for drivers whose init and exit functions
only register and unregister, respectively.A simplified version of the Coccinelle semantic patch that performs
this transformation is as follows:@a@
identifier f, x;
@@
-static f(...) { return pci_register_driver(&x); }@b depends on a@
identifier e, a.x;
@@
-static e(...) { pci_unregister_driver(&x); }@c depends on a && b@
identifier a.f;
declarer name module_init;
@@
-module_init(f);@d depends on a && b && c@
identifier b.e, a.x;
declarer name module_exit;
declarer name module_pci_driver;
@@
-module_exit(e);
+module_pci_driver(x);Signed-off-by: Vaishali Thakkar
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.Signed-off-by: Krzysztof Kozlowski
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
13 Jun, 2015
2 commits
-
I noticed there was a problem here because Smatch complained:
drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn:
inconsistent returns 'mutex:&sl->master->mutex'.
Locked on: line 416
Unlocked on: line 413The problem is that we lock ->mutex but we unlock ->bus_mutex on error.
David Fries says that ->bus_mutex is correct and ->mutex is incorrect.Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')
Signed-off-by: Dan Carpenter
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
The W1_42_FINISHED_BYTE is 0xFF so the cast means the condition is
never true.Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm')
Signed-off-by: Dan Carpenter
Signed-off-by: Greg Kroah-Hartman
01 Jun, 2015
1 commit
-
Add i2c alias to enable autoloading of the module for device specified
in device-tree.Signed-off-by: Ludek Hlavacek
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
25 May, 2015
3 commits
-
This patch provides support for the DS28EA00 digital thermometer.
The DS28EA00 provides an additional two pins for implementing a sequence
detection algorithm. This feature allows you to determine the physical
location of the chip in the 1-wire bus without needing pre-existing
knowledge of the bus ordering. Support is provided through the sysfs
w1_seq file. The file will contain a single line with an integer value
representing the device index in the bus starting at 0.Signed-off-by: Matt Campbell
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
A temperature conversion can take 750 ms and when possible the
w1_therm slave driver drops the bus_mutex to allow other bus
operations, but that includes operations such as a periodic slave
search, which can remove this slave when it is no longer detected.
If that happens the sl->family_data will be freed and set to NULL
causing w1_slave_show to crash when it wakes up.Signed-off-by: David Fries
Reported-By: Thorsten Bschorr
Tested-by: Thorsten Bschorr
Acked-by: Evgeniy Polyakov
Cc: stable
Signed-off-by: Greg Kroah-Hartman -
Some of 1-Wire devices commonly associated with physical access control
systems are attached/generate presence for as short as 100 ms - hence
the tens-to-hundreds milliseconds scan intervals are required.Signed-off-by: Dmitry Khromov
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
25 Mar, 2015
1 commit
-
of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)Signed-off-by: Fabian Frederick
Signed-off-by: Greg Kroah-Hartman
15 Dec, 2014
2 commits
-
Pull char/misc driver updates from Greg KH:
"Here's the big char/misc driver update for 3.19-rc1Lots of little things all over the place in different drivers, and a
new subsystem, "coresight" has been added. Full details are in the
shortlog"* tag 'char-misc-3.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (73 commits)
parport: parport_pc, do not remove parent devices early
spmi: Remove shutdown/suspend/resume kernel-doc
carma-fpga-program: drop videobuf dependency
carma-fpga: drop videobuf dependency
carma-fpga-program.c: fix compile errors
i8k: Fix temperature bug handling in i8k_get_temp()
cxl: Name interrupts in /proc/interrupt
CXL: Return error to PSL if IRQ demultiplexing fails & print clearer warning
coresight-replicator: remove .owner field for driver
coresight: fixed comments in coresight.h
coresight: fix typo in comment in coresight-priv.h
coresight: bindings for coresight drivers
coresight: Adding ABI documentation
w1: support auto-load of w1_bq27000 module.
w1: avoid potential u16 overflow
cn: verify msg->len before making callback
mei: export fw status registers through sysfs
mei: read and print all six FW status registers
mei: txe: add cherrytrail device id
mei: kill cached host and me csr values
... -
Pull driver core update from Greg KH:
"Here's the set of driver core patches for 3.19-rc1.They are dominated by the removal of the .owner field in platform
drivers. They touch a lot of files, but they are "simple" changes,
just removing a line in a structure.Other than that, a few minor driver core and debugfs changes. There
are some ath9k patches coming in through this tree that have been
acked by the wireless maintainers as they relied on the debugfs
changes.Everything has been in linux-next for a while"
* tag 'driver-core-3.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (324 commits)
Revert "ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries"
fs: debugfs: add forward declaration for struct device type
firmware class: Deletion of an unnecessary check before the function call "vunmap"
firmware loader: fix hung task warning dump
devcoredump: provide a one-way disable function
device: Add dev__once variants
ath: ath9k: use debugfs_create_devm_seqfile() helper for seq_file entries
ath: use seq_file api for ath9k debugfs files
debugfs: add helper function to create device related seq_file
drivers/base: cacheinfo: remove noisy error boot message
Revert "core: platform: add warning if driver has no owner"
drivers: base: support cpu cache information interface to userspace via sysfs
drivers: base: add cpu_device_create to support per-cpu devices
topology: replace custom attribute macros with standard DEVICE_ATTR*
cpumask: factor out show_cpumap into separate helper function
driver core: Fix unbalanced device reference in drivers_probe
driver core: fix race with userland in device_add()
sysfs/kernfs: make read requests on pre-alloc files use the buffer.
sysfs/kernfs: allow attributes to request write buffer be pre-allocated.
fs: sysfs: return EGBIG on write if offset is larger than file size
...
27 Nov, 2014
2 commits
-
1/ change request_module call to zero-pad single digit
family numbers. This appears to be the intention of
the code, but not what it actually does.This means that the alias created for W1_FAMILY_SMEM_01
might actually be useful.2/ Define a family name for the BQ27000 battery charge monitor.
Unfortunately this is the same number as W1_FAMILY_SMEM_01
so if both a compiled on a system, one module might need to
be blacklisted.3/ Add a MODULE_ALIAS for the bq27000.
Acked-by: Evgeniy Polyakov
Signed-off-by: NeilBrown
Signed-off-by: Greg Kroah-Hartman -
Reported-by: Dan Carpenter
Acked-by: Evgeniy Polyakov
Signed-off-by: David Fries
Signed-off-by: Greg Kroah-Hartman
11 Nov, 2014
1 commit
-
This driver has no 'compatible' string and so is not found when
using device-tree.Add one with value to match
hdqw1w: 1w@480b2000 {
device in omap3.dtsi.Signed-off-by: NeilBrown
Acked-by: Evgeniy Polyakov
Signed-off-by: Tony Lindgren
08 Nov, 2014
1 commit
-
Adjust the bulk message timeout to the other ones (1000ms). Otherwise the
following dmesg errors can be seen on a Raspberry Pi:
[ 31.492386] Failed to read 1-wire data from 0x81: err=-110.
[ 31.504168] 0x81: count=-110, status:
[ 31.613404] Failed to read 1-wire data from 0x81: err=-110.
[ 31.621915] 0x81: count=-110, status:
[ 43.260968] Failed to read 1-wire data from 0x81: err=-110.
[ 43.270998] 0x81: count=-110, status:
[ 43.379959] Failed to read 1-wire data from 0x81: err=-110.
[ 43.388854] 0x81: count=-110, status:Signed-off-by: Alexander Stein
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
20 Oct, 2014
1 commit
-
A platform_driver does not need to set an owner, it will be populated by the
driver core.Signed-off-by: Wolfram Sang
24 Jun, 2014
1 commit
-
commit 94859308a21b "w1: new w1_ds2406 driver" added a new driver
that uses the crc16 library, but didn't ensure that the core is
there. This adds the necessary Kconfig statements, just like we
have it for other w1 drivers.Reported-by: kbuild test robot
Signed-off-by: Arnd Bergmann
Acked-by: Scott Alfter
Cc: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
20 Jun, 2014
2 commits
-
This patch replaces all calls to the "printk" function within the "masters"
subdirectory by calls to the appropriate "pr_*" function thus addressing
the following warning generated by the checkpatch script:WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...Signed-off-by: Fjodor Schelichow
Signed-off-by: Roman Sommer
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman -
This patch replaces all calls to the "printk" function within the main "w1"
directory by calls to the appropriate "pr_*" function thus addressing
the following warning generated by the checkpatch script:WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...Signed-off-by: Fjodor Schelichow
Signed-off-by: Roman Sommer
Acked-by: Evgeniy Polyakov
Signed-off-by: Greg Kroah-Hartman
