24 Sep, 2016

2 commits

  • Check for watchdog_ops structures that are only stored in the ops field of
    a watchdog_device structure. This field is declared const, so watchdog_ops
    structures that have this property can be declared as const also.

    The semantic patch that makes this change is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r disable optional_qualifier@
    identifier i;
    position p;
    @@
    static struct watchdog_ops i@p = { ... };

    @ok@
    identifier r.i;
    struct watchdog_device e;
    position p;
    @@
    e.ops = &i@p;

    @bad@
    position p != {r.p,ok.p};
    identifier r.i;
    struct watchdog_ops e;
    @@
    e@i@p

    @depends on !bad disable optional_qualifier@
    identifier r.i;
    @@
    static
    +const
    struct watchdog_ops i = { ... };
    //

    Signed-off-by: Julia Lawall
    Reviewed-by: Guenter Roeck
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Julia Lawall
     
  • Currently even if no users are there the suspend tries to
    stop the watchdog and resume starts it.

    so after resume the watchdog starts and resets the board.
    Fix the same by adding a check for users.

    Reviewed-by: Guenter Roeck
    Signed-off-by: Shubhrajyoti Datta
    Signed-off-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck

    Shubhrajyoti Datta
     

28 Dec, 2015

1 commit


13 Dec, 2015

1 commit


21 Jan, 2015

1 commit


21 Oct, 2014

1 commit