Eric Lee / smarc-fsl-linux-kernel

18 Nov, 2013

1 commit

  • 487722cf2   watchdog: Get rid of MODULE_ALIAS_MISCDEV statements ... Browse Code »

    I just can't find any value in MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
    and MODULE_ALIAS_MISCDEV(TEMP_MINOR) statements.

    Either the device is enumerated and the driver already has a module
    alias (e.g. PCI, USB etc.) that will get the right driver loaded
    automatically.

    Or the device is not enumerated and loading its driver will lead to
    more or less intrusive hardware poking. Such hardware poking should be
    limited to a bare minimum, so the user should really decide which
    drivers should be tried and in what order. Trying them all in
    arbitrary order can't do any good.

    On top of that, loading that many drivers at once bloats the kernel
    log. Also many drivers will stay loaded afterward, bloating the output
    of "lsmod" and wasting memory. Some modules (cs5535_mfgpt which gets
    loaded as a dependency) can't even be unloaded!

    If defining char-major-10-130 is needed then it should happen in
    user-space.

    Signed-off-by: Jean Delvare
    Acked-by: Guenter Roeck
    Signed-off-by: Wim Van Sebroeck
    Cc: Stephen Warren
    Cc: Mike Frysinger
    Cc: Wan ZongShun
    Cc: Ben Dooks
    Cc: Kukjin Kim
    Cc: Zwane Mwaikambo
    Cc: Jim Cromie

    Jean Delvare
     

22 Jun, 2013

1 commit

  • cd6cbde6b   WATCHDOG: sb_wdog: Fix 32 bit build failure ... Browse Code »

    Fixes the following linking problem:
    drivers/watchdog/sb_wdog.c:211: undefined reference to `__udivdi3'

    This results from reading a 64 bit register, then dividing the value by
    1000000. For 32 bit kernels gcc will use the helper function __udivdi3
    from libgcc which the kernel intentionally doesn't provide.

    In the read registerbits 23..63 are always zero and only bits 0..22 are
    signficant. So a simple cast to truncate the read value to 32 bits
    fixes the issue.

    Reported and initial patch by Markos Chandras .

    Signed-off-by: Ralf Baechle
    Reported-by: Markos Chandras

    Ralf Baechle
     

28 Mar, 2012

1 commit

  • 27c766aaa   watchdog: Use pr_<fmt> and pr_<level> ... Browse Code »

    Use the current logging styles.

    Make sure all output has a prefix.
    Add missing newlines.
    Remove now unnecessary PFX, NAME, and miscellaneous other #defines.
    Coalesce formats.

    Signed-off-by: Joe Perches
    Signed-off-by: Wim Van Sebroeck

    Joe Perches
     

06 Nov, 2011

1 commit

16 Sep, 2010

1 commit

27 Apr, 2010

1 commit

09 Nov, 2009

1 commit

18 Jun, 2009

2 commits

29 Oct, 2008

1 commit

07 Aug, 2008

1 commit

06 Aug, 2008

1 commit

  • 0c06090c9   [WATCHDOG] Coding style - Indentation - part 2 ... Browse Code »

    This brings the watchdog drivers into line with coding style.
    This patch takes cares of the indentation as described in chapter 1.
    Main changes:
    * Re-structure the ioctl switch call for all drivers as follows:
    switch (cmd) {
    case WDIOC_GETSUPPORT:
    case WDIOC_GETSTATUS:
    case WDIOC_GETBOOTSTATUS:
    case WDIOC_GETTEMP:
    case WDIOC_SETOPTIONS:
    case WDIOC_KEEPALIVE:
    case WDIOC_SETTIMEOUT:
    case WDIOC_GETTIMEOUT:
    case WDIOC_GETTIMELEFT:
    default:
    }

    This to make the migration from the drivers to the uniform watchdog
    device driver easier in the future.

    Signed-off-by: Wim Van Sebroeck

    Wim Van Sebroeck
     

21 Jun, 2008

1 commit

19 Feb, 2008

1 commit