16 Oct, 2016
1 commit
-
Pull befs fixes from Luis de Bethencourt:
"I recently took maintainership of the befs file system [0]. This is
the first time I send you a git pull request, so please let me know if
all the below is OK.Salah Triki and myself have been cleaning the code and fixing a few
small bugs.Sorry I couldn't send this sooner in the merge window, I was waiting
to have my GPG key signed by kernel members at ELCE in Berlin a few
days ago."[0] https://lkml.org/lkml/2016/7/27/502
* tag 'befs-v4.9-rc1' of git://github.com/luisbg/linux-befs: (39 commits)
befs: befs: fix style issues in datastream.c
befs: improve documentation in datastream.c
befs: fix typos in datastream.c
befs: fix typos in btree.c
befs: fix style issues in super.c
befs: fix comment style
befs: add check for ag_shift in superblock
befs: dump inode_size superblock information
befs: remove unnecessary initialization
befs: fix typo in befs_sb_info
befs: add flags field to validate superblock state
befs: fix typo in befs_find_key
befs: remove unused BEFS_BT_PARMATCH
fs: befs: remove ret variable
fs: befs: remove in vain variable assignment
fs: befs: remove unnecessary *befs_sb variable
fs: befs: remove useless initialization to zero
fs: befs: remove in vain variable assignment
fs: befs: Insert NULL inode to dentry
fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect
...
08 Oct, 2016
39 commits
-
Fixing the following checkpatch.pl errors:
ERROR: "foo * bar" should be "foo *bar"
+ befs_blocknr_t blockno, befs_block_run * run);WARNING: Missing a blank line after declarations
+ struct buffer_head *bh;
+ befs_debug(sb, "---> %s length: %llu", __func__, len);WARNING: Block comments use * on subsequent lines
+ /*
+ Double indir block, plus all the indirect blocks it maps.(and other instances of these)
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Convert function descriptions to kernel-doc style.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Fixing typos in kernel-doc function descriptions in fs/befs/btree.c.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
Fixing the following checkpatch.pl error:
ERROR: "foo * bar" should be "foo *bar"
+befs_load_sb(struct super_block *sb, befs_super_block * disk_sb)And the following warnings:
WARNING: suspect code indent for conditional statements (8, 12)
+ if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_LE)
+ befs_sb->byte_order = BEFS_BYTESEX_LE;WARNING: suspect code indent for conditional statements (8, 12)
+ else if (disk_sb->fs_byte_order == BEFS_BYTEORDER_NATIVE_BE)
+ befs_sb->byte_order = BEFS_BYTESEX_BE;WARNING: break quoted strings at a space character
+ befs_error(sb, "blocksize(%u) cannot be larger"
+ "than system pagesize(%lu)", befs_sb->block_size,WARNING: line over 80 characters
+ if (befs_sb->log_start != befs_sb->log_end || befs_sb->flags == BEFS_DIRTY) {Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
The description of befs_load_sb was confusing the kernel-doc system since,
because it starts with /**, it thinks it will document the function with
kernel-doc formatting. Which it isn't.Fix other comment style issues in the file while we are at it.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
ag_shift and blocks_per_ag contain the same information in different ways,
same as block_shift and block_size do. It is worth checking this two are
consistent, but since blocks_per_ag isn't documented as mandatory to use
some implementations of befs don't enforce this, so making it non-fatal if
they don't match and just having it as a warning.Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
befs_dump_super_block() wasn't giving the inode_size information when
dumping all elements of the superblock. Add this element to have complete
information of the superblock.Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
There is no need to init block, since it will be overwitten later by
iaddr2blockno().Signed-off-by: Salah Triki
Signed-off-by: Luis de Bethencourt -
Fixing jornal to Journal.
Signed-off-by: Salah Triki
Signed-off-by: Luis de Bethencourt -
For validating superblock state, add flags field to befs_sb_info, read the state from the disk
and check if it is equal to BEFS_DIRTY.Signed-off-by: Salah Triki
Signed-off-by: Luis de Bethencourt -
Fixing skeep to skip.
Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
befs_btree_find(), the only caller of befs_find_key(), only cares about if
the return from that function is BEFS_BT_MATCH or not. It never uses the
partial match given with BEFS_BT_PARMATCH. Make the overflow return clearer
by having BEFS_BT_OVERFLOW instead of BEFS_BT_PARMATCH.Signed-off-by: Luis de Bethencourt
Signed-off-by: Salah Triki -
ret is initialized to -EIO and is never modified, so remove ret and use
-EIO directly.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
There is no need to init res, since it will be overwitten later by
befs_fblock2brun().Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
value by this function is only used once.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
node_off is unconditionally set to bt_super.root_node_ptr, so no need to
init it to zero.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
There is no need to set *value, it will be overwritten later.
Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
As VFS expects, lookup inserts NULL inode to dentry when the named inode
does not exist.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
The calls to brelse are useless since dbl_indir_block and indir_block
are NULL.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
Constant has to be capitalized.
Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
The only caller of befs_find_brun_direct is befs_fblock2brun, which
already validates that the block is within the range of direct blocks.
So remove the duplicate validation.Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt -
Fixing a grammatical error in the documentation.
Signed-off-by: Luis de Bethencourt
-
The only place the values of free_node_ptr and max_size are read is in
befs_dump_index_entry(), which both times it is called, it is passed the on
disk superblock. Removing assignment of unused values.Signed-off-by: Luis de Bethencourt
-
befs_error() is used in potential errors that could happen in befs to
provide informational log messages. befs_debug() is silent when
CONFIG_BEFS_DEBUG=no, and very verbose when switched on, which is why it is
used for general debugging but not for errors.Fix a few cases where the befs debug utility usage isn't following the
expected pattern. To make sure we have consistent information in the logs.Signed-off-by: Luis de Bethencourt
-
Replace goto with simpler while loop to make befs_readdir() more readable.
Signed-off-by: Luis de Bethencourt
-
Use macro directly instead of via assigning it to an unchanging variable.
Signed-off-by: Luis de Bethencourt
Acked-by: Salah Triki -
No need to dereference dentry twice to get the name when we already have
it stored in a local variable.Signed-off-by: Luis de Bethencourt
-
This comment with a mysterious unfinished line confuses the kernel-doc
system since, because it starts with /**, it thinks it is documenting a
function.Signed-off-by: Luis de Bethencourt
-
Log error only when silent flag is not set.
Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors")
Signed-off-by: Luis de Bethencourt
Acked-by: Salah Triki -
Since befs_bread merely calls sb_bread, replace it by sb_bread.
Link: http://lkml.kernel.org/r/1466800258-4542-1-git-send-email-salah.triki@gmail.com
Signed-off-by: Salah Triki
Acked-by: Luis de Bethencourt
Signed-off-by: Andrew Morton -
befs_iaddr_is_empty() and befs_brun_size() are unused. Remove them.
Link: http://lkml.kernel.org/r/1465700235-22881-3-git-send-email-luisbg@osg.samsung.com
Signed-off-by: Luis de Bethencourt
Signed-off-by: Andrew Morton -
Documentation of function befs_load_cb() lists it as load_befs_sb(). Fix
the misnomer.Link: http://lkml.kernel.org/r/1465700235-22881-2-git-send-email-luisbg@osg.samsung.com
Signed-off-by: Luis de Bethencourt
Signed-off-by: Andrew Morton -
Confirm sb_min_blocksize() succeeded before continuing.
Link: http://lkml.kernel.org/r/1465700235-22881-1-git-send-email-luisbg@osg.samsung.com
Signed-off-by: Luis de Bethencourt
Signed-off-by: Andrew Morton -
Remove pr_err since kmem_cache_create log error and dump stack.
Link: http://lkml.kernel.org/r/e6d03cbc9542495dc6174b59e32fcd41c1393cfc.1464226521.git.salah.triki@acm.org
Signed-off-by: Salah Triki -
Remove befs_error since when kmalloc fails there is a generic out of
memory and stack dump.Link: http://lkml.kernel.org/r/3de4d388d98bbb570462a5eb8e64623e17fb5d74.1464226521.git.salah.triki@acm.org
Signed-off-by: Salah Triki
Signed-off-by: Andrew Morton -
Remove pr_err since when kzalloc fails there is a generic out of memory
and stack dump.Link: http://lkml.kernel.org/r/c5a7f2d42ec0fc8465c118248e88cd221c483391.1464226521.git.salah.triki@acm.org
Signed-off-by: Salah Triki
Signed-off-by: Andrew Morton -
Log errors only when silent flag is not set.
Link: http://lkml.kernel.org/r/d400aaf5a7430de79bd956e40ec075fb1cb08474.1464226521.git.salah.triki@acm.org
Signed-off-by: Salah Triki
Signed-off-by: Andrew Morton -
Control is transfered to unacquire_none when sb->s_fs_info is equal to
NULL, so the assignment to NULL is useless and it is moved above
unacquire_none.Link: http://lkml.kernel.org/r/ed41da113fc693c7daa4e8813ca04cc766ddfc05.1464226521.git.salah.triki@acm.org
Signed-off-by: Salah Triki
Signed-off-by: Andrew Morton
