18 May, 2016

1 commit

  • Wrong return code was being returned on SMB3 rmdir of
    non-empty directory.

    For SMB3 (unlike for cifs), we attempt to delete a directory by
    set of delete on close flag on the open. Windows clients set
    this flag via a set info (SET_FILE_DISPOSITION to set this flag)
    which properly checks if the directory is empty.

    With this patch on smb3 mounts we correctly return
    "DIRECTORY NOT EMPTY"
    on attempts to remove a non-empty directory.

    Signed-off-by: Steve French
    CC: Stable
    Acked-by: Sachin Prabhu

    Steve French
     

15 Feb, 2014

1 commit

  • SMB3 servers can respond with MaxTransactSize of more than 4M
    that can cause a memory allocation error returned from kmalloc
    in a lock codepath. Also the client doesn't support multicredit
    requests now and allows buffer sizes of 65536 bytes only. Set
    MaxTransactSize to this maximum supported value.

    Cc: stable@vger.kernel.org # 3.7+
    Signed-off-by: Pavel Shilovsky
    Acked-by: Jeff Layton
    Signed-off-by: Steve French

    Pavel Shilovsky
     

27 Jun, 2013

1 commit

  • SMB3 uses a much faster method of signing (which is also better in other ways),
    AES-CMAC. With the kernel now supporting AES-CMAC since last release, we
    are overdue to allow SMB3 signing (today only CIFS and SMB2 and SMB2.1,
    but not SMB3 and SMB3.1 can sign) - and we need this also for checking
    secure negotation and also per-share encryption (two other new SMB3 features
    which we need to implement).

    This patch needs some work in a few areas - for example we need to
    move signing for SMB2/SMB3 from per-socket to per-user (we may be able to
    use the "nosharesock" mount option in the interim for the multiuser case),
    and Shirish found a bug in the earlier authentication overhaul
    (setting signing flags properly) - but those can be done in followon
    patches.

    Signed-off-by: Shirish Pargaonkar
    Signed-off-by: Steve French

    Steve French
     

25 Sep, 2012

5 commits


25 Jul, 2012

1 commit