Eric Lee / smarc-fsl-linux-kernel

26 Mar, 2015

1 commit

  • 98cf21c61   hfsplus: fix B-tree corruption after insertion at position 0 ... Browse Code »

    Fix B-tree corruption when a new record is inserted at position 0 in the
    node in hfs_brec_insert(). In this case a hfs_brec_update_parent() is
    called to update the parent index node (if exists) and it is passed
    hfs_find_data with a search_key containing a newly inserted key instead
    of the key to be updated. This results in an inconsistent index node.
    The bug reproduces on my machine after an extents overflow record for
    the catalog file (CNID=4) is inserted into the extents overflow B-tree.
    Because of a low (reserved) value of CNID=4, it has to become the first
    record in the first leaf node.

    The resulting first leaf node is correct:

    ----------------------------------------------------
    | key0.CNID=4 | key1.CNID=123 | key2.CNID=456, ... |
    ----------------------------------------------------

    But the parent index key0 still contains the previous key CNID=123:

    -----------------------
    | key0.CNID=123 | ... |
    -----------------------

    A change in hfs_brec_insert() makes hfs_brec_update_parent() work
    correctly by preventing it from getting fd->record=-1 value from
    __hfs_brec_find().

    Along the way, I removed duplicate code with unification of the if
    condition. The resulting code is equivalent to the original code
    because node is never 0.

    Also hfs_brec_update_parent() will now return an error after getting a
    negative fd->record value. However, the return value of
    hfs_brec_update_parent() is not checked anywhere in the file and I'm
    leaving it unchanged by this patch. brec.c lacks error checking after
    some other calls too, but this issue is of less importance than the one
    being fixed by this patch.

    Signed-off-by: Sergei Antonov
    Cc: Joe Perches
    Reviewed-by: Vyacheslav Dubeyko
    Acked-by: Hin-Tak Leung
    Cc: Anton Altaparmakov
    Cc: Al Viro
    Cc: Christoph Hellwig
    Cc:
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Sergei Antonov
     

01 May, 2013

2 commits

  • d61426732   hfs/hfsplus: convert printks to pr_<level> ... Browse Code »

    Use a more current logging style.

    Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
    hfsplus now uses "hfsplus: " for all messages.
    Coalesce formats.
    Prefix debugging messages too.

    Signed-off-by: Joe Perches
    Cc: Vyacheslav Dubeyko
    Cc: Hin-Tak Leung
    Cc: Christoph Hellwig
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     
  • c2b3e1f76   hfs/hfsplus: convert dprint to hfs_dbg ... Browse Code »

    Use a more current logging style.

    Rename macro and uses.
    Add do {} while (0) to macro.
    Add DBG_ to macro.
    Add and use hfs_dbg_cont variant where appropriate.

    Signed-off-by: Joe Perches
    Cc: Vyacheslav Dubeyko
    Cc: Hin-Tak Leung
    Cc: Christoph Hellwig
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Joe Perches
     

28 Feb, 2013

1 commit

22 Jul, 2011

1 commit

17 Dec, 2010

1 commit

23 Nov, 2010

1 commit

14 Oct, 2010

3 commits

  • 13571a697   hfsplus: validate btree flags ... Browse Code »

    Signed-off-by: Christoph Hellwig

    Christoph Hellwig
     
  • 9250f9259   hfsplus: handle more on-disk corruptions without oopsing ... Browse Code »

    hfs seems prone to bad things when it encounters on disk corruption. Many
    values are read from disk, and used as lengths to memcpy, as an example.
    This patch fixes up several of these problematic cases.

    o sanity check the on-disk maximum key lengths on mount
    (these are set to a defined value at mkfs time and shouldn't differ)
    o check on-disk node keylens against the maximum key length for each tree
    o fix hfs_btree_open so that going out via free_tree: doesn't wind
    up in hfs_releasepage, which wants to follow the very pointer
    we were trying to set up:
    HFS_SB(sb)->cat_tree = hfs_btree_open()
    .
    failure gets to hfs_releasepage and tries to follow HFS_SB(sb)->cat_tree

    Tested with the fsfuzzer; it survives more than it used to.

    [hch: ported of commit cf0594625083111ae522496dc1c256f7476939c2 from hfs]
    [hch: added the fixes from 5581d018ed3493d226e7a4d645d9c8a5af6c36b]

    Signed-off-by: Eric Sandeen
    Signed-off-by: Christoph Hellwig

    Eric Sandeen
     
  • b6b41424f   hfsplus: hfs_bnode_find() can fail, resulting in hfs_bnode_split() breakage ... Browse Code »

    oops and fs corruption; the latter can happen even on valid fs in case of oom.

    [hch: port of commit 3d10a15d6919488204bdb264050d156ced20d9aa from hfs]

    Signed-off-by: Al Viro
    Signed-off-by: Christoph Hellwig

    Al Viro
     

19 Jan, 2006

1 commit

  • 634725a92   [PATCH] hfs: cleanup HFS+ prints ... Browse Code »

    Add the log level and a "hfs: " prefix to all kernel prints. (HFS and HFS+
    will use the same prefix, as they share some code and could be merged at some
    point.)

    Signed-off-by: Roman Zippel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Roman Zippel
     

17 Apr, 2005

1 commit

  • 1da177e4c   Linux-2.6.12-rc2 ... Browse Code »

    Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds