Eric Lee / smarc-fsl-linux-kernel

23 Jul, 2012

1 commit

  • ddb24bbac   logfs: create a pagecache page if it is not present ... Browse Code »

    While writing the partial journal entries we assumed that the page
    associated with the journal would always in locatable. This incorrect
    assumption resulted in the following BUG

    kernel BUG at /home/benixon/WD_SMR/kernels/linux-3.3.7-logfs/fs/logfs/journal.c:569!
    EIP is at logfs_write_area+0xb6/0x109 [logfs]
    EAX: 00000000 EBX: 00000000 ECX: ef6efea4 EDX: 00000000
    ESI: 001b9000 EDI: f009e000 EBP: c3c13f14 ESP: c3c13ef0
    DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
    Process sync (pid: 1799, ti=c3c12000 task=f07825b0 task.ti=c3c12000)
    Stack:
    01001000 c3c13f26 781b9000 00000000 f009e000 f7286000 f1f83400 f8445071
    f1f83400 c3c13f30 f8445ae9 c3c13f20 0000100a 000ee000 f009e000 00000001
    c3c13f5c f8445d17 c05eb0ee 00000000 f1f83400 ef718000 f009e25c ea9c3d80
    Call Trace:
    [] ? account_shadow+0x16d/0x16d [logfs]
    [] logfs_write_je+0x2a/0x44 [logfs]
    [] logfs_write_anchor+0x114/0x228 [logfs]
    [] ? empty+0x5/0x5
    [] logfs_sync_fs+0x1e/0x31 [logfs]
    [] __sync_filesystem+0x5d/0x6f
    [] sync_one_sb+0x15/0x17
    [] iterate_supers+0x59/0x9a
    [] ? __sync_filesystem+0x6f/0x6f
    [] sys_sync+0x29/0x4f
    [] sysenter_do_call+0x12/0x28
    EIP: [] logfs_write_area+0xb6/0x109 [logfs] SS:ESP 0068:c3c13ef0
    ---[ end trace ef6e9ef52601a945 ]---

    The fix is to create the pagecache page if it is not locatable.

    Reported-and-tested-by: Benixon Dhas
    Signed-off-by: Prasad Joshi

    Prasad Joshi
     

28 Jan, 2012

1 commit

23 Dec, 2010

1 commit

  • eabb26cac   logfs: fix deadlock in logfs_get_wblocks, hold and wait on super->s_write_mutex ... Browse Code »

    do_logfs_journal_wl_pass() should use GFP_NOFS for memory allocation GC
    code calls btree_insert32 with GFP_KERNEL while holding a mutex
    super->s_write_mutex.

    The same mutex is used in address_space_operations->writepage(), and a
    call to writepage() could be triggered as a result of memory allocation
    in btree_insert32, causing a deadlock.

    Addresses https://bugzilla.kernel.org/show_bug.cgi?id=20342

    Signed-off-by: Prasad Joshi
    Cc: Joern Engel
    Cc: Florian Mickler
    Cc: "Rafael J. Wysocki"
    Cc: Maciej Rutecki
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Prasad Joshi
     

10 Aug, 2010

1 commit

05 May, 2010

1 commit

22 Apr, 2010

1 commit

  • 255f41c59   Merge git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs ... Browse Code »

    * git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs:
    [LogFS] Split large truncated into smaller chunks
    [LogFS] Set s_bdi
    [LogFS] Prevent mempool_destroy NULL pointer dereference
    [LogFS] Move assertion
    [LogFS] Plug 8 byte information leak
    [LogFS] Prevent memory corruption on large deletes
    [LogFS] Remove unused method

    Fix trivial conflict with added header includes in fs/logfs/super.c

    Linus Torvalds
     

13 Apr, 2010

3 commits

05 Apr, 2010

1 commit

30 Mar, 2010

3 commits

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     
  • 6be7fa06e   [LogFS] Erase new journal segments ... Browse Code »

    If the device contains on old logfs image and the journal is moved to
    segment that have never been used by the current logfs and not all
    journal segments are erased before the next mount, the old content can
    confuse mount code. To prevent this, always erase the new journal
    segments.

    Signed-off-by: Joern Engel

    Joern Engel
     
  • 0943846ae   [LogFS] Move reserved segments with journal ... Browse Code »

    Fixes a GC livelock.

    Signed-off-by: Joern Engel

    Joern Engel
     

29 Mar, 2010

1 commit

06 Mar, 2010

1 commit

05 Mar, 2010

2 commits

  • c6d383014   [LogFS] Only write journal if dirty ... Browse Code »

    This prevents unnecessary journal writes. More importantly it prevents
    an oops due to a journal write on failed mount.

    Joern Engel
     
  • 9421502b4   [LogFS] Fix bdev erases ... Browse Code »

    Erases for block devices were always just emulated by writing 0xff.
    Some time back the write was removed and only the page cache was
    changed to 0xff. Superficialy a good idea with two problems:
    1. Touching the page cache isn't necessary either.
    2. However, writing out 0xff _is_ necessary for the journal. As the
    journal is scanned linearly, an old non-overwritten commit entry
    can be used on next mount and cause havoc.

    This should fix both aspects.

    Joern Engel
     

07 Dec, 2009

1 commit

  • 5c564c2a0   [LogFS] Silence gcc ... Browse Code »

    Andrew Morton sayeth:
    fs/logfs/journal.c: In function 'logfs_init_journal':
    fs/logfs/journal.c:266: warning: 'last_len' may be used uninitialized in this function

    Can this be squished please?

    Joern Engel
     

21 Nov, 2009

1 commit