05 Aug, 2014
8 commits
-
Remove the old nfsd_for_n_state function and move nfsd_find_client
higher up into the file to get rid of forward declaration. Remove
the struct nfsd_fault_inject_op arguments from the operations as
they are no longer needed by any of them.Finally, remove the old "standard" get and set routines, which
also eliminates the client_mutex from this code.Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
...instead of relying on the client_mutex.
Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
...instead of relying on the client_mutex.
Also, fix up the printk output that is generated when the file is read.
It currently says that it's reporting the number of open files, but
it's actually reporting the number of openowners.Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
...instead of relying on the client_mutex.
Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
...which uses the client_lock for protection instead of client_mutex.
Also remove nfsd_forget_client as there are no more callers.Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
...that relies on the client_lock instead of client_mutex.
Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
Add a new "get" routine for forget_clients that relies on the
client_lock instead of the client_mutex.Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields -
Now that we've added more granular locking in other places, it's time
to address the fault injection code. This code is currently quite
reliant on the client_mutex for protection. Start to change this by
adding a new set of fault injection op vectors.For now they all use the legacy ones. In later patches we'll add new
routines that can deal with more granular locking.Also, move some of the printk routines into the callers to make the
results of the operations more uniform.Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields
23 Jun, 2014
1 commit
-
Currently rpc_pton() fails to handle the case where you echo an address
into the file, as it barfs on the newline. Ensure that we NULL out the
first occurrence of any newline.Signed-off-by: Jeff Layton
Signed-off-by: J. Bruce Fields
09 May, 2014
1 commit
-
Signed-off-by: Kinglong Mee
Signed-off-by: J. Bruce Fields
01 Mar, 2013
1 commit
-
Pull nfsd changes from J Bruce Fields:
"Miscellaneous bugfixes, plus:- An overhaul of the DRC cache by Jeff Layton. The main effect is
just to make it larger. This decreases the chances of intermittent
errors especially in the UDP case. But we'll need to watch for any
reports of performance regressions.- Containerized nfsd: with some limitations, we now support
per-container nfs-service, thanks to extensive work from Stanislav
Kinsbursky over the last year."Some notes about conflicts, since there were *two* non-data semantic
conflicts here:- idr_remove_all() had been added by a memory leak fix, but has since
become deprecated since idr_destroy() does it for us now.- xs_local_connect() had been added by this branch to make AF_LOCAL
connections be synchronous, but in the meantime Trond had changed the
calling convention in order to avoid a RCU dereference.There were a couple of more obvious actual source-level conflicts due to
the hlist traversal changes and one just due to code changes next to
each other, but those were trivial.* 'for-3.9' of git://linux-nfs.org/~bfields/linux: (49 commits)
SUNRPC: make AF_LOCAL connect synchronous
nfsd: fix compiler warning about ambiguous types in nfsd_cache_csum
svcrpc: fix rpc server shutdown races
svcrpc: make svc_age_temp_xprts enqueue under sv_lock
lockd: nlmclnt_reclaim(): avoid stack overflow
nfsd: enable NFSv4 state in containers
nfsd: disable usermode helper client tracker in container
nfsd: use proper net while reading "exports" file
nfsd: containerize NFSd filesystem
nfsd: fix comments on nfsd_cache_lookup
SUNRPC: move cache_detail->cache_request callback call to cache_read()
SUNRPC: remove "cache_request" argument in sunrpc_cache_pipe_upcall() function
SUNRPC: rework cache upcall logic
SUNRPC: introduce cache_detail->cache_request callback
NFS: simplify and clean cache library
NFS: use SUNRPC cache creation and destruction helper for DNS cache
nfsd4: free_stid can be static
nfsd: keep a checksum of the first 256 bytes of request
sunrpc: trim off trailing checksum before returning decrypted or integrity authenticated buffer
sunrpc: fix comment in struct xdr_buf definition
...
23 Feb, 2013
1 commit
-
Signed-off-by: Al Viro
05 Feb, 2013
1 commit
-
These routines are used by server and client code, so having them in a
separate header would be best.Signed-off-by: Jeff Layton
Acked-by: Trond Myklebust
Signed-off-by: J. Bruce Fields
11 Dec, 2012
2 commits
-
If len == 0 we end up with size = (0 - 1), which could cause bad things
to happen in copy_from_user().Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields -
I honestly have no idea where I got 129 from, but it's a much bigger
value than the actual buffer size (INET6_ADDRSTRLEN).Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields
03 Dec, 2012
5 commits
-
Write the client's ip address to any state file and all appropriate
state for that client will be forgotten.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields -
Controlling the read and write functions allows me to add in "forget
client w.x.y.z", since we won't be limited to reading and writing only
u64 values.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields -
I also log basic information that I can figure out about the type of
state (such as number of locks for each client IP address). This can be
useful for checking that state was actually dropped and later for
checking if the client was able to recover.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields -
The eventual goal is to forget state based on ip address, so it makes
sense to call this function in a for-each-client loop until the correct
amount of state is forgotten. I also use this patch as an opportunity
to rename the forget function from "func()" to "forget()".Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields -
Each function touches state in some way, so getting the lock earlier
can help simplify code.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields
29 Nov, 2012
1 commit
-
There were only a small number of functions in this file and since they
all affect stored state I think it makes sense to put them in state.h
instead. I also dropped most static inline declarations since there are
no callers when fault injection is not enabled.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields
01 Jun, 2012
1 commit
-
debugfs read operations were returning the contents of an uninitialized u64.
Signed-off-by: Weston Andros Adamson
Signed-off-by: J. Bruce Fields
21 Mar, 2012
1 commit
-
all of those should be umode_t...
Signed-off-by: Al Viro
08 Nov, 2011
1 commit
-
Fault injection on the NFS server makes it easier to test the client's
state manager and recovery threads. Simulating errors on the server is
easier than finding the right conditions that cause them naturally.This patch uses debugfs to add a simple framework for fault injection to
the server. This framework is a config option, and can be enabled
through CONFIG_NFSD_FAULT_INJECTION. Assuming you have debugfs mounted
to /sys/debug, a set of files will be created in /sys/debug/nfsd/.
Writing to any of these files will cause the corresponding action and
write a log entry to dmesg.Signed-off-by: Bryan Schumaker
Signed-off-by: J. Bruce Fields