Eric Lee / smarc-fsl-linux-kernel

25 Jun, 2016

1 commit

  • 999653786   nfsd: check permissions when setting ACLs ... Browse Code »

    Use set_posix_acl, which includes proper permission checks, instead of
    calling ->set_acl directly. Without this anyone may be able to grant
    themselves permissions to a file by setting the ACL.

    Lock the inode to make the new checks atomic with respect to set_acl.
    (Also, nfsd was the only caller of set_acl not locking the inode, so I
    suspect this may fix other races.)

    This also simplifies the code, and ensures our ACLs are checked by
    posix_acl_valid.

    The permission checks and the inode locking were lost with commit
    4ac7249e, which changed nfsd to use the set_acl inode operation directly
    instead of going through xattr handlers.

    Reported-by: David Sinquin
    [agreunba@redhat.com: use set_posix_acl]
    Fixes: 4ac7249e
    Cc: Christoph Hellwig
    Cc: Al Viro
    Cc: stable@vger.kernel.org
    Signed-off-by: J. Bruce Fields

    Ben Hutchings
     

21 Jul, 2015

1 commit

16 Apr, 2015

1 commit

12 Jul, 2014

1 commit

23 May, 2014

1 commit

  • d40aa3372   nfsd: Remove assignments inside conditions ... Browse Code »

    Assignments should not happen inside an if conditional, but in the line
    before. This issue was reported by checkpatch.

    The semantic patch that makes this change is as follows
    (http://coccinelle.lip6.fr/):

    //

    @@
    identifier i1;
    expression e1;
    statement S;
    @@
    -if(!(i1 = e1)) S
    +i1 = e1;
    +if(!i1)
    +S

    //

    It has been tested by compilation.

    Signed-off-by: Benoit Taine
    Signed-off-by: J. Bruce Fields

    Benoit Taine
     

26 Jan, 2014

1 commit

  • 4ac7249ea   nfsd: use get_acl and ->set_acl ... Browse Code »

    Remove the boilerplate code to marshall and unmarhall ACL objects into
    xattrs and operate on the posix_acl objects directly. Also move all
    the ACL handling code into nfs?acl.c where it belongs.

    Signed-off-by: Christoph Hellwig
    Signed-off-by: Al Viro

    Christoph Hellwig
     

26 Feb, 2013

1 commit

18 Dec, 2012

1 commit

21 Aug, 2012

1 commit

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

16 Dec, 2009

1 commit

15 Dec, 2009

2 commits

14 Nov, 2009

1 commit

05 Nov, 2009

1 commit

  • 1b7e0403c   nfsd: register NFS_ACL with rpcbind ... Browse Code »

    Modify the NFS server to register the NFS_ACL services with the rpcbind
    daemon. This allows the client to ping for the existence of the NFS_ACL
    support via commands such as "rpcinfo -t nfs_acl".

    This patch also modifies the NFS_ACL support so that responses to
    version 2 NULLPROC requests can be made.

    The changelog for the patch which turned off this functionality
    mentioned something about not registering the NFS_ACL as being part of
    some tradition. I can't find this tradition and the only other
    implementation which supports NFS_ACL does register them with the
    rpcbind daemon.

    Signed-off-by: Peter Staubach
    Signed-off-by: J. Bruce Fields

    Peter Staubach
     

24 Jun, 2008

1 commit

  • 8837abcab   nfsd: rename MAY_ flags ... Browse Code »

    Rename nfsd_permission() specific MAY_* flags to NFSD_MAY_* to make it
    clear, that these are not used outside nfsd, and to avoid name and
    number space conflicts with the VFS.

    [comment from hch: rename MAY_READ, MAY_WRITE and MAY_EXEC as well]

    Signed-off-by: Miklos Szeredi
    Signed-off-by: J. Bruce Fields

    Miklos Szeredi
     

02 Feb, 2008

1 commit

  • aefa89d17   nfsd: Fix inconsistent assignment ... Browse Code »

    Dereferenced pointer "dentry" without checking and assigned to inode
    in the declaration.

    (We could just delete the NULL checks that follow instead, as we never
    get to the encode function in this particular case. But it takes a
    little detective work to verify that fact, so it's probably safer to
    leave the checks in place.)

    Cc: Steve French
    Signed-off-by: Prasad V Potluri
    Signed-off-by: J. Bruce Fields

    Prasad P
     

13 Nov, 2007

1 commit

  • ac8587dcb   knfsd: fix spurious EINVAL errors on first access of new filesystem ... Browse Code »

    The v2/v3 acl code in nfsd is translating any return from fh_verify() to
    nfserr_inval. This is particularly unfortunate in the case of an
    nfserr_dropit return, which is an internal error meant to indicate to
    callers that this request has been deferred and should just be dropped
    pending the results of an upcall to mountd.

    Thanks to Roland for bug report and data collection.

    Cc: Roland
    Acked-by: Andreas Gruenbacher
    Signed-off-by: J. Bruce Fields
    Reviewed-By: NeilBrown
    Signed-off-by: Linus Torvalds

    J. Bruce Fields
     

20 Feb, 2007

1 commit

09 Dec, 2006

1 commit

  • cb65a5ba3   [PATCH] NFS2: Calculate 'w' a bit later in nfsaclsvc_encode_getaclres() ... Browse Code »

    NFS2: Calculate 'w' a bit later in nfsaclsvc_encode_getaclres()
    This is a small performance optimization since we can return before
    needing 'w'. It also saves a few bytes of .text :
    Before:
    text data bss dec hex filename
    2406 212 0 2618 a3a fs/nfsd/nfs2acl.o
    After:
    text data bss dec hex filename
    2400 212 0 2612 a34 fs/nfsd/nfs2acl.o

    Signed-off-by: Jesper Juhl
    Cc: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Jesper Juhl
     

21 Oct, 2006

3 commits

04 Oct, 2006

3 commits

  • bc5fea429   [PATCH] knfsd: register all RPC programs with portmapper by default ... Browse Code »

    The NFSACL patches introduced support for multiple RPC services listening on
    the same transport. However, only the first of these services was registered
    with portmapper. This was perfectly fine for nfsacl, as you traditionally do
    not want these to show up in a portmapper listing.

    The patch below changes the default behavior to always register all services
    listening on a given transport, but retains the old behavior for nfsacl
    services.

    Signed-off-by: Olaf Kirch
    Signed-off-by: Neil Brown
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Olaf Kirch
     
  • 445243594   [PATCH] knfsd: Replace two page lists in struct svc_rqst with one ... Browse Code »

    We are planning to increase RPCSVC_MAXPAGES from about 8 to about 256. This
    means we need to be a bit careful about arrays of size RPCSVC_MAXPAGES.

    struct svc_rqst contains two such arrays. However the there are never more
    that RPCSVC_MAXPAGES pages in the two arrays together, so only one array is
    needed.

    The two arrays are for the pages holding the request, and the pages holding
    the reply. Instead of two arrays, we can simply keep an index into where the
    first reply page is.

    This patch also removes a number of small inline functions that probably
    server to obscure what is going on rather than clarify it, and opencode the
    needed functionality.

    Also remove the 'rq_restailpage' variable as it is *always* 0. i.e. if the
    response 'xdr' structure has a non-empty tail it is always in the same pages
    as the head.

    check counters are initilised and incr properly
    check for consistant usage of ++ etc
    maybe extra some inlines for common approach
    general review

    Signed-off-by: Neil Brown
    Cc: Magnus Maatta
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    NeilBrown
     
  • f30c22695   fix file specification in comments ... Browse Code »

    Many files include the filename at the beginning, serveral used a wrong one.

    Signed-off-by: Uwe Zeisberger
    Signed-off-by: Adrian Bunk

    Uwe Zeisberger
     

21 Dec, 2005

1 commit

23 Jun, 2005

1 commit