Eric Lee / smarc-fsl-linux-kernel

26 Aug, 2014

1 commit

29 Feb, 2012

1 commit

02 Nov, 2011

1 commit

04 Aug, 2011

1 commit

  • 31475dd61   mm: a few small updates for radix-swap ... Browse Code »

    Remove PageSwapBacked (!page_is_file_cache) cases from
    add_to_page_cache_locked() and add_to_page_cache_lru(): those pages now
    go through shmem_add_to_page_cache().

    Remove a comment on maximum tmpfs size from fsstack_copy_inode_size(),
    and add a comment on swap entries to invalidate_mapping_pages().

    And mincore_page() uses find_get_page() on what might be shmem or a
    tmpfs file: allow for a radix_tree_exceptional_entry(), and proceed to
    find_get_page() on swapper_space if so (oh, swapper_space needs #ifdef).

    Signed-off-by: Hugh Dickins
    Acked-by: Rik van Riel
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Hugh Dickins
     

17 Dec, 2009

2 commits

20 Feb, 2007

1 commit

23 Dec, 2006

1 commit

  • ba3ff12fc   [PATCH] fsstack: Remove inode copy ... Browse Code »

    Trevor found a file size problem in eCryptfs in recent kernels, and he
    tracked it down to an fsstack change.

    This was the eCryptfs copy_attr_all:

    > -void ecryptfs_copy_attr_all(struct inode *dest, const struct inode *src)
    > -{
    > - dest->i_mode = src->i_mode;
    > - dest->i_nlink = src->i_nlink;
    > - dest->i_uid = src->i_uid;
    > - dest->i_gid = src->i_gid;
    > - dest->i_rdev = src->i_rdev;
    > - dest->i_atime = src->i_atime;
    > - dest->i_mtime = src->i_mtime;
    > - dest->i_ctime = src->i_ctime;
    > - dest->i_blkbits = src->i_blkbits;
    > - dest->i_flags = src->i_flags;
    > -}

    This is the fsstack copy_attr_all:

    > +void fsstack_copy_attr_all(struct inode *dest, const struct inode *src,
    > + int (*get_nlinks)(struct inode *))
    > +{
    > + if (!get_nlinks)
    > + dest->i_nlink = src->i_nlink;
    > + else
    > + dest->i_nlink = (*get_nlinks)(dest);
    > +
    > + dest->i_mode = src->i_mode;
    > + dest->i_uid = src->i_uid;
    > + dest->i_gid = src->i_gid;
    > + dest->i_rdev = src->i_rdev;
    > + dest->i_atime = src->i_atime;
    > + dest->i_mtime = src->i_mtime;
    > + dest->i_ctime = src->i_ctime;
    > + dest->i_blkbits = src->i_blkbits;
    > + dest->i_flags = src->i_flags;
    > +
    > + fsstack_copy_inode_size(dest, src);
    > +}

    The addition of copy_inode_size breaks eCryptfs, since eCryptfs needs to
    interpolate the file sizes (eCryptfs has extra space in the lower file for
    the header). The setting of the upper inode size occurs elsewhere in
    eCryptfs, and the new copy_attr_all now undoes what eCryptfs was doing
    right beforehand.

    I see three ways of going forward from here. (1) Something like this patch
    needs to go in (assuming it jives with Unionfs), (2) we need to make a
    change to the fsstack API for more fine-grained control over copying
    attributes (e.g., by also including a callback function for calculating the
    right file size, which will require some more work on both eCryptfs and
    Unionfs), or (3) the fsstack patch on eCryptfs (commit
    0cc72dc7f050188d8d7344b1dd688cbc68d3cd30 made on Fri Dec 8 02:36:31 2006
    -0800) needs to be yanked in 2.6.20.

    I think the simplest solution, from eCryptfs' perspective, is to just
    remove the inode size copy.

    Remove inode size copy in general fsstack attr copy code. Stacked
    filesystems may need to interpolate the inode size, since the file
    size in the lower file may be different than the file size in the
    stacked layer.

    Signed-off-by: Michael Halcrow
    Acked-by: Josef "Jeff" Sipek
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Michael Halcrow
     

09 Dec, 2006

1 commit

  • 42cf11939   [PATCH] fsstack: Introduce fsstack_copy_{attr,inode}_* ... Browse Code »

    Introduce several fsstack_copy_* functions which allow stackable filesystems
    (such as eCryptfs and Unionfs) to easily copy over (currently only) inode
    attributes. This prevents code duplication and allows for code reuse.

    [akpm@osdl.org: Remove unneeded wrapper]
    [bunk@stusta.de: fs/stack.c should #include ]
    Signed-off-by: Josef "Jeff" Sipek
    Cc: Michael Halcrow
    Signed-off-by: Adrian Bunk
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Josef "Jeff" Sipek