15 Oct, 2014
1 commit
-
Resolve "logical 'and' applied to non-boolean constant" warnings"
that appear in W=2 builds by adding !! to a bit test.Signed-off-by: Mark Rustad
Signed-off-by: Jeff Kirsher
Signed-off-by: David S. Miller
20 Nov, 2013
3 commits
-
Register generic netlink multicast groups as an array with
the family and give them contiguous group IDs. Then instead
of passing the global group ID to the various functions that
send messages, pass the ID relative to the family - for most
families that's just 0 because the only have one group.This avoids the list_head and ID in each group, adding a new
field for the mcast group ID offset to the family.At the same time, this allows us to prevent abusing groups
again like the quota and dropmon code did, since we can now
check that a family only uses a group it owns.Signed-off-by: Johannes Berg
Signed-off-by: David S. Miller -
This doesn't really change anything, but prepares for the
next patch that will change the APIs to pass the group ID
within the family, rather than the global group ID.Signed-off-by: Johannes Berg
Signed-off-by: David S. Miller -
As suggested by David Miller, make genl_register_family_with_ops()
a macro and pass only the array, evaluating ARRAY_SIZE() in the
macro, this is a little safer.The openvswitch has some indirection, assing ops/n_ops directly in
that code. This might ultimately just assign the pointers in the
family initializations, saving the struct genl_family_and_ops and
code (once mcast groups are handled differently.)Signed-off-by: Johannes Berg
Signed-off-by: David S. Miller
08 Nov, 2012
8 commits
-
These macros no longer exist in kernel version v3.5-rc1.
Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg -
This is done by introducing drbd_nla_find_nested() which handles the flag
before calling nla_find_nested().Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg -
We need to remove the flag before checking for valid types.
Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg -
Make it more clear in the flag names which flags are internal to drbd, and
which are not.The check for mandatory attributes is the only extension visible at the netlink
layer. Attributes with this flag set would look like unknown attributes to
some kernel versions. The netlink layer would ignore them and also skip
consistency checks on the attribute type and legth. To avoid this, we check
for mandatory attributes first, remove the mandatory flag, and then process the
attributes normally.Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg -
Note: All input values are still treated as signed; unsigned long long values
are still broken.Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg -
Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg -
Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg -
This commit breaks the API again.
Move per-volume former syncer options into disk_conf.
Move per-connection former syncer options into net_conf.
Renamed the remainign sync_conf to res_optsSyncer settings have been changeable at runtime, so we need to prepare
for these settings to be runtime-changeable in their new home as well.Introduce new configuration operations, and share the netlink attribute
between "attach" (create new disk) and "disk-opts" (change options).
Same for "connect" and "net-opts".Some fields cannot be changed at runtime, however.
Introduce a new flag GENLA_F_INVARIANT to be able to trigger on that in
the generated validation and assignment functions.Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg
04 Nov, 2012
1 commit
-
Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg
14 Oct, 2011
1 commit
-
This adds the new API header and helper files.
Signed-off-by: Philipp Reisner
Signed-off-by: Lars Ellenberg