Eric Lee / smarc-fsl-linux-kernel

07 Oct, 2012

1 commit

  • 3b64b1881   [SCSI] libfc: fix lun reset failure bugs in fc_fcp_resp handling of FCP_RSP_INFO ... Browse Code »

    In LUN RESET testing involving NetApp targets, it is observed that LUN
    RESET is failing. The fc_fcp_resp() is not completing the completion
    for the LUN RESET task since fc_fcp_resp assumes that the FCP_RSP_INFO
    is 8 bytes with the 4 byte reserved field, where in case of NetApp targets
    the FCP_RSP to LUN RESET only has 4 bytes of FCP_RSP_INFO. This leads
    fc_fcp_resp to error out w/o completing the task completion, eventually
    causing LUN RESET to be escalated to host reset, which is not very nice.

    Per FCP-3 r04, clause 9.5.15 and Table 23, the FCP_RSP_INFO field can be either
    4 bytes or 8 bytes, with the last 4 bytes as "Reserved (if any)". Therefore it
    is valid to have 4 bytes FCP_RSP_INFO like some of the NetApp targets behave.
    Fixing this by validating the FCP_RSP_INFO against both the two spec allowed
    length.

    Reported-by: Frank Zhang
    Signed-off-by: Yi Zou
    Tested-by: Ross Brattain
    Signed-off-by: Robert Love
    Signed-off-by: James Bottomley

    Yi Zou
     

26 Feb, 2012

1 commit

  • e35fa8c2d   scsi: Use struct scsi_lun in fc/fcp.h ... Browse Code »

    This allows us to use scsilun_to_int without an ugly cast.

    Fix up places that use scsilun_to_int on fcp->fc_lun accordingly.

    In fc target, this leaves ft_cmd.lun unused, so remove it.

    Signed-off-by: Andy Grover
    Cc: Christoph Hellwig
    Cc: Kiran Patil
    Cc: James Bottomley
    Signed-off-by: Nicholas Bellinger

    Andy Grover
     

31 Mar, 2011

1 commit

02 Nov, 2010

1 commit

  • b595076a1   tree-wide: fix comment/printk typos ... Browse Code »

    "gadget", "through", "command", "maintain", "maintain", "controller", "address",
    "between", "initiali[zs]e", "instead", "function", "select", "already",
    "equal", "access", "management", "hierarchy", "registration", "interest",
    "relative", "memory", "offset", "already",

    Signed-off-by: Uwe Kleine-König
    Signed-off-by: Jiri Kosina

    Uwe Kleine-König
     

11 Apr, 2010

1 commit

05 Dec, 2009

2 commits

  • 0a55256d1   [SCSI] libfc: Add target reset flag to FCP header file ... Browse Code »

    While the target reset task management function has been deprecated in
    newer specs, it is still in use by SCSI FC drivers and there is no
    real replacement. Add the target reset flag to the FCP header file to
    allow usage of this definition in SCSI FC drivers.

    Reviewed-by: Swen Schillig
    Signed-off-by: Christof Schmitt
    Signed-off-by: James Bottomley

    Christof Schmitt
     
  • ab593b187   [SCSI] libfc: register FC4 features with the FC switch ... Browse Code »

    Customers and certification tests have pointed out that we don't
    show up on the switch management software as an initiator.

    On some MDS switches 'show fcns database' command shows libfc
    initiators as 'fcp' not 'fcp:init' like other initiators.

    On others switches, I think the switch gets the features by doing a PRLI,
    but it may be only certain models or under certain configurations.

    Fix this by registering our FC4 features with the RFF_ID CT request
    after local port login and after the RFT_ID.

    Signed-off-by: Joe Eykholt
    Signed-off-by: Robert Love
    Signed-off-by: James Bottomley

    Joe Eykholt
     

30 Dec, 2008

1 commit