Eric Lee / smarc-fsl-linux-kernel

12 Oct, 2016

1 commit

  • f58b3c91f   autofs: move inclusion of linux/limits.h to uapi ... Browse Code »

    linux/limits.h should be included by uapi instead of linux/auto_fs.h
    so as not to cause compile error in userspace.

    # cat << EOF > ./test1.c
    > #include
    > #include
    > int main(void) {
    > return 0;
    > }
    > EOF
    # gcc -Wall -g ./test1.c
    In file included from ./test1.c:2:0:
    /usr/include/linux/auto_fs.h:54:12: error: 'NAME_MAX' undeclared here (not in a function)
    char name[NAME_MAX+1];
    ^

    Link: http://lkml.kernel.org/r/20160812024856.12352.24092.stgit@pluto.themaw.net
    Signed-off-by: Tomohiro Kusumi
    Signed-off-by: Ian Kent
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tomohiro Kusumi
     

16 Mar, 2016

2 commits

09 Feb, 2013

1 commit

  • 4f4ffc3a5   unbreak automounter support on 64-bit kernel with 32-bit userspace (v2) ... Browse Code »

    automount-support is broken on the parisc architecture, because the existing
    #if list does not include a check for defined(__hppa__). The HPPA (parisc)
    architecture is similiar to other 64bit Linux targets where we have to define
    autofs_wqt_t (which is passed back and forth to user space) as int type which
    has a size of 32bit across 32 and 64bit kernels.

    During the discussion on the mailing list, H. Peter Anvin suggested to invert
    the #if list since only specific platforms (specifically those who do not have
    a 32bit userspace, like IA64 and Alpha) should have autofs_wqt_t as unsigned
    long type.

    This suggestion is probably the best way to go, since Arm64 (and maybe others?)
    seems to have a non-working automounter. So in the long run even for other new
    upcoming architectures this inverted check seem to be the best solution, since
    it will not require them to change this #if again (unless they are 64bit only).

    Signed-off-by: Helge Deller
    Acked-by: H. Peter Anvin
    Acked-by: Ian Kent
    Acked-by: Catalin Marinas
    CC: James Bottomley
    CC: Rolf Eike Beer

    Helge Deller
     

13 Oct, 2012

1 commit