08 May, 2015

1 commit

  • ACCESS_ONCE doesn't work reliably on non-scalar types. This patch removes
    the rest of the existing usages of ACCESS_ONCE() in the scheduler, and use
    the new READ_ONCE() and WRITE_ONCE() APIs as appropriate.

    Signed-off-by: Jason Low
    Signed-off-by: Peter Zijlstra (Intel)
    Acked-by: Thomas Gleixner
    Acked-by: Rik van Riel
    Acked-by: Waiman Long
    Cc: Andrew Morton
    Cc: Aswin Chandramouleeswaran
    Cc: Borislav Petkov
    Cc: Davidlohr Bueso
    Cc: Frederic Weisbecker
    Cc: H. Peter Anvin
    Cc: Linus Torvalds
    Cc: Mel Gorman
    Cc: Mike Galbraith
    Cc: Oleg Nesterov
    Cc: Paul E. McKenney
    Cc: Preeti U Murthy
    Cc: Scott J Norton
    Cc: Steven Rostedt
    Link: http://lkml.kernel.org/r/1430251224-5764-2-git-send-email-jason.low2@hp.com
    Signed-off-by: Ingo Molnar

    Jason Low
     

11 Dec, 2012

1 commit


30 Oct, 2012

1 commit

  • Due to these two commits:

    8323f26ce342 sched: Fix race in task_group()
    800d4d30c8f2 sched, autogroup: Stop going ahead if autogroup is disabled

    ... autogroup scheduling's dynamic knobs are wrecked.

    With both patches applied, all you have to do to crash a box is
    disable autogroup during boot up, then reboot.. boom, NULL pointer
    dereference due to 800d4d30 not allowing autogroup to move things,
    and 8323f26ce making that the only way to switch runqueues.

    Remove most of the (dysfunctional) knobs and turn the remaining
    sched_autogroup_enabled knob readonly.

    If the user fiddles with cgroups hereafter, once tasks
    are moved, autogroup won't mess with them again unless
    they call setsid().

    No knobs, no glitz, nada, just a cute little thing folks can
    turn on if they don't want to muck about with cgroups and/or
    systemd.

    Signed-off-by: Mike Galbraith
    Cc: Xiaotian Feng
    Cc: Peter Zijlstra
    Cc: Xiaotian Feng
    Cc: Linus Torvalds
    Cc: Andrew Morton
    Cc: Oleg Nesterov
    Cc: # v3.6
    Link: http://lkml.kernel.org/r/1351451963.4999.8.camel@maggy.simpson.net
    Signed-off-by: Ingo Molnar

    Mike Galbraith
     

17 Nov, 2011

1 commit